1
0
forked from Mirrors/itch-dl

Force use UTF-8 end-to-end for site downloading

Itch always uses UTF-8. This change prevents garbled output with
non-Latin scripts if requests or BS4 does not guess that correctly.
This commit is contained in:
Ryszard Knop
2023-01-29 15:22:24 +01:00
parent fb2e4c6736
commit e61ef0cba3
2 changed files with 24 additions and 5 deletions

View File

@@ -191,7 +191,7 @@ class GameDownloader:
file to the provided path and returns the final URL that was downloaded."""
try:
# No timeouts, chunked uploads, default retry strategy, should be all good?
with self.client.get(url, data=credentials, stream=True) as r:
with self.client.get(url, data=credentials, stream=True, guess_encoding=True) as r:
r.raise_for_status()
if download_path is not None: # ...and it will be for external downloads.
@@ -320,8 +320,8 @@ class GameDownloader:
except Exception as e:
errors.append(f"Cover art download failed (this is not fatal): {e}")
with open(paths['site'], 'w') as f:
f.write(site.prettify())
with open(paths['site'], 'wb') as f:
f.write(site.prettify(encoding='utf-8'))
with open(paths['metadata'], 'w') as f:
json.dump(metadata, f, indent=4)