From e803e779e7d82ccf170c323b85d0395c290a5e97 Mon Sep 17 00:00:00 2001 From: pythoninthegrass <4097471+pythoninthegrass@users.noreply.github.com> Date: Sat, 12 Aug 2023 14:09:42 -0500 Subject: [PATCH] Add version todo Currently checks string vs. integer comparison. Leads to false positives (e.g., 2.99 is marked as older than 2.98) --- NonSteamLaunchers.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/NonSteamLaunchers.sh b/NonSteamLaunchers.sh index d1ec960..424b625 100755 --- a/NonSteamLaunchers.sh +++ b/NonSteamLaunchers.sh @@ -31,6 +31,7 @@ exec >> ${logged_in_home}/Downloads/NonSteamLaunchers-install.log 2>&1 # Version number (major.minor) version=v2.99 +# TODO: tighten logic to check whether major/minor version is up-to-date via `-eq`, `-lt`, or `-gt` operators # Check repo releases via GitHub API then display current stable version check_for_updates() { # Set the URL to the GitHub API for the repository