From bfc2fad49f00e7b5b038e3368b548450876d2c74 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:26:20 +0800 Subject: [PATCH 01/12] Check whether the Pull Request is regulated (#142) --- .github/pull_request_template.md | 12 ++++++++++++ .github/workflows/pull_request_check.yml | 25 ++++++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 .github/pull_request_template.md create mode 100644 .github/workflows/pull_request_check.yml diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..6afc729 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,12 @@ + + +Checklist + +- [ ] Referenced all related issues in the PR body (e.g. "Closes #xyz") +- [ ] Have tested the modifications diff --git a/.github/workflows/pull_request_check.yml b/.github/workflows/pull_request_check.yml new file mode 100644 index 0000000..36ccbbb --- /dev/null +++ b/.github/workflows/pull_request_check.yml @@ -0,0 +1,25 @@ +name: Pull Request checker + +on: + pull_request_target: + types: [opened, edited] + +jobs: + autoclose: + runs-on: ubuntu-latest + steps: + - name: Check Pull Request + uses: tachiyomiorg/issue-moderator-action@v1 + with: + auto-close-rules: | + [ + { + "type": "body", + "regex": ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*", + "message": "The acknowledgment section was not removed." + } + ] + auto-close-ignore-label: | + do-not-autoclose + bug + enhancement From fe0d7c60cec928a0b391a51216716eadc9e81ecf Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:30:41 +0800 Subject: [PATCH 02/12] Update pull_request_check.yml --- .github/workflows/pull_request_check.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull_request_check.yml b/.github/workflows/pull_request_check.yml index 36ccbbb..d90f595 100644 --- a/.github/workflows/pull_request_check.yml +++ b/.github/workflows/pull_request_check.yml @@ -1,7 +1,7 @@ name: Pull Request checker on: - pull_request_target: + pull_request: types: [opened, edited] jobs: From 45dbec9492793e6e7c7ba36b0c88d148aed49ba6 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:46:57 +0800 Subject: [PATCH 03/12] Update anti-spam workflows --- .github/workflows/anti_spam.yml | 25 ++++++++++++++++++++++++ .github/workflows/pull_request_check.yml | 25 ------------------------ 2 files changed, 25 insertions(+), 25 deletions(-) create mode 100644 .github/workflows/anti_spam.yml delete mode 100644 .github/workflows/pull_request_check.yml diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml new file mode 100644 index 0000000..45b1af8 --- /dev/null +++ b/.github/workflows/anti_spam.yml @@ -0,0 +1,25 @@ +name: Anti-spam + +on: + issues: + types: [opened] + pull_request_target: + types: [opened, edited] + +jobs: + autoclose: + runs-on: ubuntu-latest + steps: + - name: Anti-spam + uses: dessant/repo-lockdown@v2 + with: + exclude-issue-labels: | + bug + enhancement + issue-lock-reason: spam + exclude-pr-labels: | + bug + enhancement + do-not-autoclose + pr-labels: spam + pr-lock-reason: spam diff --git a/.github/workflows/pull_request_check.yml b/.github/workflows/pull_request_check.yml deleted file mode 100644 index d90f595..0000000 --- a/.github/workflows/pull_request_check.yml +++ /dev/null @@ -1,25 +0,0 @@ -name: Pull Request checker - -on: - pull_request: - types: [opened, edited] - -jobs: - autoclose: - runs-on: ubuntu-latest - steps: - - name: Check Pull Request - uses: tachiyomiorg/issue-moderator-action@v1 - with: - auto-close-rules: | - [ - { - "type": "body", - "regex": ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*", - "message": "The acknowledgment section was not removed." - } - ] - auto-close-ignore-label: | - do-not-autoclose - bug - enhancement From 95aba7bee7e875586003e1e15ccce84e43915f65 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:48:10 +0800 Subject: [PATCH 04/12] Update anti_spam.yml --- .github/workflows/anti_spam.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index 45b1af8..940fed0 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -3,7 +3,7 @@ name: Anti-spam on: issues: types: [opened] - pull_request_target: + pull_request: types: [opened, edited] jobs: From 72e2b10c58102d64308b300b7a41fdf1e53408f0 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:51:14 +0800 Subject: [PATCH 05/12] Update anti_spam.yml --- .github/workflows/anti_spam.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index 940fed0..841e9a9 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -23,3 +23,10 @@ jobs: do-not-autoclose pr-labels: spam pr-lock-reason: spam + - name: Delete workflow runs + uses: Mattraks/delete-workflow-runs@v2 + with: + token: ${{ github.token }} + repository: ${{ github.repository }} + retain_days: 0 + keep_minimum_runs: 0 From 5aed4ee14d686e08fdd5890ee77201158c8e5828 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 12:58:18 +0800 Subject: [PATCH 06/12] Update anti-spam workflows --- .github/pull_request_template.md | 1 + .github/workflows/anti_spam.yml | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6afc729..0a0a043 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,6 +4,7 @@ Don't forget to check all base themes and tablet mode for relevant changes. DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT. + Please set the label to bugfix or enhancement, otherwise it will be closed. --> Checklist diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index 841e9a9..e6f7372 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -18,11 +18,13 @@ jobs: enhancement issue-lock-reason: spam exclude-pr-labels: | - bug + bugfix enhancement do-not-autoclose pr-labels: spam pr-lock-reason: spam + skip-closed-pr-comment: true + skip-closed-issue-comment: true - name: Delete workflow runs uses: Mattraks/delete-workflow-runs@v2 with: From 80a30f46d1b32cd7eb40a44f21838fbf155b931b Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 13:01:02 +0800 Subject: [PATCH 07/12] Update pull_request_template.md --- .github/pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 0a0a043..1acb2c8 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,7 +1,6 @@ Checklist diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index e6f7372..9b71277 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -10,7 +10,7 @@ jobs: autoclose: runs-on: ubuntu-latest steps: - - name: Anti-spam + - name: Check issue uses: dessant/repo-lockdown@v2 with: exclude-issue-labels: | @@ -25,6 +25,22 @@ jobs: pr-lock-reason: spam skip-closed-pr-comment: true skip-closed-issue-comment: true + process-only: issues + - name: Check pull request + uses: tachiyomiorg/issue-moderator-action@v1 + with: + auto-close-rules: | + [ + { + "type": "body", + "regex": ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*", + "message": "The acknowledgment section was not removed." + } + ] + auto-close-ignore-label: | + do-not-autoclose + bugfix + enhancement - name: Delete workflow runs uses: Mattraks/delete-workflow-runs@v2 with: From b59758382c50c2e9a6ec2ca4665e745e1bcb967b Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 13:25:55 +0800 Subject: [PATCH 09/12] Update anti_spam.yml --- .github/workflows/anti_spam.yml | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index 9b71277..48b42f9 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -26,21 +26,8 @@ jobs: skip-closed-pr-comment: true skip-closed-issue-comment: true process-only: issues - - name: Check pull request - uses: tachiyomiorg/issue-moderator-action@v1 - with: - auto-close-rules: | - [ - { - "type": "body", - "regex": ".*DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT.*", - "message": "The acknowledgment section was not removed." - } - ] - auto-close-ignore-label: | - do-not-autoclose - bugfix - enhancement + - name: Check PR + uses: sumally/github-check-tasklist-action@v1 - name: Delete workflow runs uses: Mattraks/delete-workflow-runs@v2 with: From f59f0120068620e2668134542aa73668a15256a5 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 13:28:12 +0800 Subject: [PATCH 10/12] Update anti_spam.yml --- .github/workflows/anti_spam.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/anti_spam.yml index 48b42f9..b48b89d 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/anti_spam.yml @@ -10,6 +10,13 @@ jobs: autoclose: runs-on: ubuntu-latest steps: + - name: Delete workflow runs + uses: Mattraks/delete-workflow-runs@v2 + with: + token: ${{ github.token }} + repository: ${{ github.repository }} + retain_days: 0 + keep_minimum_runs: 0 - name: Check issue uses: dessant/repo-lockdown@v2 with: @@ -28,10 +35,3 @@ jobs: process-only: issues - name: Check PR uses: sumally/github-check-tasklist-action@v1 - - name: Delete workflow runs - uses: Mattraks/delete-workflow-runs@v2 - with: - token: ${{ github.token }} - repository: ${{ github.repository }} - retain_days: 0 - keep_minimum_runs: 0 From b0fee9c1910c0d1e508dfa9467d3002392187e30 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Sun, 25 Sep 2022 22:24:52 +0800 Subject: [PATCH 11/12] Update issue validation workflow --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 +- .github/ISSUE_TEMPLATE/feature_request.yml | 2 +- .../{anti_spam.yml => issue_moderator.yml} | 27 +++++++++---------- 3 files changed, 14 insertions(+), 17 deletions(-) rename .github/workflows/{anti_spam.yml => issue_moderator.yml} (52%) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index ad3c06b..0213dfb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,7 +1,7 @@ name: Bug report/反馈 Bug description: Report errors or unexpected behavior./反馈错误或异常行为。 labels: [bug] -title: "[Bug] " +title: "[Bug] Short description." body: - type: markdown attributes: diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 239a4d1..9f82683 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -2,7 +2,7 @@ name: Feature request/新特性请求 description: Suggest an idea./提出建议 labels: [enhancement] -title: "[Feature Request] " +title: "[Feature Request] Short description." body: - type: textarea attributes: diff --git a/.github/workflows/anti_spam.yml b/.github/workflows/issue_moderator.yml similarity index 52% rename from .github/workflows/anti_spam.yml rename to .github/workflows/issue_moderator.yml index b48b89d..4dda6d2 100644 --- a/.github/workflows/anti_spam.yml +++ b/.github/workflows/issue_moderator.yml @@ -1,4 +1,4 @@ -name: Anti-spam +name: Issue moderator on: issues: @@ -18,20 +18,17 @@ jobs: retain_days: 0 keep_minimum_runs: 0 - name: Check issue - uses: dessant/repo-lockdown@v2 + uses: tachiyomiorg/issue-moderator-action@v1 with: - exclude-issue-labels: | - bug - enhancement - issue-lock-reason: spam - exclude-pr-labels: | - bugfix - enhancement - do-not-autoclose - pr-labels: spam - pr-lock-reason: spam - skip-closed-pr-comment: true - skip-closed-issue-comment: true - process-only: issues + repo-token: ${{ secrets.GITHUB_TOKEN }} + auto-close-rules: | + [ + { + "type": "title", + "regex": ".*Short description.*", + "message": "You did not fill out the description in the title" + } + ] + auto-close-ignore-label: do-not-autoclose - name: Check PR uses: sumally/github-check-tasklist-action@v1 From c770a2ba7decbb64086be1c586a7f3c63fb89751 Mon Sep 17 00:00:00 2001 From: Howard Wu <40033067+Howard20181@users.noreply.github.com> Date: Mon, 26 Sep 2022 18:20:30 +0800 Subject: [PATCH 12/12] Fork detachment announcements --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index c8594e0..ce25e91 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # Magisk on WSA (with Google Apps) +:warning: For fork developers: Please detach the fork from [upstream](https://github.com/LSPosed/MagiskOnWSALocal) before building with Actions, Github will count the forked Actions usage to the upstream repository, which means if a forked repository abuses Actions, the repository that gets disabled will be upstream. We are not against forks, but please detach them from our repository. If you do not make changes one day after receiving the detachment request, our organization will ban you. + ## Support for generating from these systems - Linux (x86_64 or arm64)