Optimizing scripts

MagiskOnWSAOld/Update Check/KernelSUUpdateCheck.py

@@ -3,20 +3,21 @@ import json
 import requests
 import logging
 import subprocess
+
 logging.captureWarnings(True)
 env_file = os.getenv('GITHUB_ENV')
 new_version_found = False
-currentver = requests.get(f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/kernelsu.appversion").text.replace('\n', '')
+currentver = requests.get(
+    f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/kernelsu.appversion").text.replace('\n', '')
 git = (
     "git checkout -f update || git switch --discard-changes --orphan update"
 )
 with open('kernelsu.appversion', 'w') as file:
     file.write(currentver)
 if not new_version_found:
-    latestver = ""
-    kernelsumsg = ""
-    latestver = json.loads(requests.get(f"https://api.github.com/repos/tiann/kernelsu/releases/latest").content)['tag_name'].replace('v', '').replace('\n', '')
-    kernelsumsg="Update KernelSU Version from `v" + currentver + "` to `v" + latestver + "`"
+    latestver = json.loads(requests.get(f"https://api.github.com/repos/tiann/kernelsu/releases/latest").content)[
+        'tag_name'].replace('v', '').replace('\n', '')
+    kernelsumsg = "Update KernelSU Version from `v" + currentver + "` to `v" + latestver + "`"
     if currentver != latestver:
         print("New version found: " + latestver)
         new_version_found = True
@@ -26,9 +27,9 @@ if not new_version_found:
             file.truncate()
             file.write(latestver)
         with open(env_file, "a") as wr:
-             wr.write(f"KERNEL_SU_MSG={kernelsumsg}\n")
+            wr.write(f"KERNEL_SU_MSG={kernelsumsg}\n")
     else:
-        kernelsumsg = "KernelSU Version: `" + latestver + "`"
+        kernelsumsg = f"KernelSU Version: `{latestver}`"
         with open(env_file, "a") as wr:
-             wr.write(f"KERNEL_SU_MSG={kernelsumsg}\n")
-    file.close() 
+            wr.write(f"KERNEL_SU_MSG={kernelsumsg}\n")
+    file.close()

MagiskOnWSAOld/Update Check/MTGUpdateCheck.py

@@ -3,20 +3,22 @@ import json
 import requests
 import logging
 import subprocess
+
 logging.captureWarnings(True)
 env_file = os.getenv('GITHUB_ENV')
 new_version_found = False
-currentver = requests.get(f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/gapps.appversion").text.replace('\n', '')
+currentver = requests.get(
+    f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/gapps.appversion").text.replace('\n', '')
 git = (
     "git checkout -f update || git switch --discard-changes --orphan update"
 )
 with open('gapps.appversion', 'w') as file:
-  file.write(currentver)
+    file.write(currentver)
 if not new_version_found:
-    latestver = ""
-    mtgmsg = ""
-    latestver = json.loads(requests.get(f"https://api.github.com/repos/MustardChef/MindTheGappsArchived/releases/latest").content)['name'].replace('\n', '')
-    mtgmsg="Update MindTheGapps Version from `v" + currentver + "` to `v" + latestver + "`"
+    latestver = \
+    json.loads(requests.get(f"https://api.github.com/repos/MustardChef/MindTheGappsArchived/releases/latest").content)[
+        'name'].replace('\n', '')
+    mtgmsg = "Update MindTheGapps Version from `v" + currentver + "` to `v" + latestver + "`"
     if currentver != latestver:
         print("New version found: " + latestver)
         new_version_found = True
@@ -26,9 +28,9 @@ if not new_version_found:
             file.truncate()
             file.write(latestver)
         with open(env_file, "a") as wr:
-           wr.write(f"MTG_MSG={mtgmsg}\n")
+            wr.write(f"MTG_MSG={mtgmsg}\n")
     else:
         mtgmsg = "MindTheGapps Package Version: `" + latestver + "`"
         with open(env_file, "a") as wr:
-           wr.write(f"MTG_MSG={mtgmsg}\n")
-    file.close()   
+            wr.write(f"MTG_MSG={mtgmsg}\n")
+    file.close()

MagiskOnWSAOld/Update Check/MagiskCanaryUpdateCheck.py

@@ -3,20 +3,22 @@ import json
 import requests
 import logging
 import subprocess
+
 logging.captureWarnings(True)
 env_file = os.getenv('GITHUB_ENV')
 new_version_found = False
-currentver = requests.get(f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/magiskcanary.appversion").text.replace('\n', '')
+currentver = requests.get(
+    f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/magiskcanary.appversion").text.replace('\n', '')
 git = (
     "git checkout -f update || git switch --discard-changes --orphan update"
 )
 with open('magiskcanary.appversion', 'w') as file:
     file.write(currentver)
 if not new_version_found:
-    latestver = ""
-    magiskcanarymsg = ""
-    latestver = json.loads(requests.get(f"https://github.com/topjohnwu/magisk-files/raw/master/canary.json").content)['magisk']['version'].replace('\n', '')
-    magiskcanarymsg="Update Magisk Canary Version from `v" + currentver + "` to `v" + latestver + "`"
+    latestver = \
+    json.loads(requests.get(f"https://github.com/topjohnwu/magisk-files/raw/master/canary.json").content)['magisk'][
+        'version'].replace('\n', '')
+    magiskcanarymsg = "Update Magisk Canary Version from `v" + currentver + "` to `v" + latestver + "`"
     if currentver != latestver:
         print("New version found: " + latestver)
         new_version_found = True
@@ -28,7 +30,7 @@ if not new_version_found:
         with open(env_file, "a") as wr:
             wr.write(f"MAGISK_CANARY_MSG={magiskcanarymsg}\n")
     else:
-        magiskcanarymsg = "Magisk Canary Version: `" + latestver + "`" 
+        magiskcanarymsg = "Magisk Canary Version: `" + latestver + "`"
         with open(env_file, "a") as wr:
             wr.write(f"MAGISK_CANARY_MSG={magiskcanarymsg}\n")
-    file.close()        
+    file.close()

MagiskOnWSAOld/Update Check/MagiskStableUpdateCheck.py

@@ -3,20 +3,22 @@ import json
 import requests
 import logging
 import subprocess
+
 logging.captureWarnings(True)
 env_file = os.getenv('GITHUB_ENV')
 new_version_found = False
 git = (
     "git checkout -f update || git switch --discard-changes --orphan update"
 )
-currentver = requests.get(f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/magiskstable.appversion").text.replace('\n', '')
+currentver = requests.get(
+    f"https://raw.githubusercontent.com/MustardChef/WSABuilds/update/magiskstable.appversion").text.replace('\n', '')
 with open('magiskstable.appversion', 'w') as file:
     file.write(currentver)
 if not new_version_found:
-    latestver = ""
-    magiskstablemsg = ""
-    latestver = json.loads(requests.get(f"https://github.com/topjohnwu/magisk-files/raw/master/stable.json").content)['magisk']['version'].replace('\n', '')
-    magiskstablemsg="Update Magisk Stable Version from `v" + currentver + "` to `v" + latestver + "`"
+    latestver = \
+    json.loads(requests.get(f"https://github.com/topjohnwu/magisk-files/raw/master/stable.json").content)['magisk'][
+        'version'].replace('\n', '')
+    magiskstablemsg = "Update Magisk Stable Version from `v" + currentver + "` to `v" + latestver + "`"
     if currentver != latestver:
         print("New version found: " + latestver)
         new_version_found = True
@@ -28,7 +30,7 @@ if not new_version_found:
         with open(env_file, "a") as wr:
             wr.write(f"MAGISK_STABLE_MSG={magiskstablemsg}\n")
     else:
-        magiskstablemsg = "Magisk Stable Version: `" + latestver + "`" 
+        magiskstablemsg = "Magisk Stable Version: `" + latestver + "`"
         with open(env_file, "a") as wr:
             wr.write(f"MAGISK_STABLE_MSG={magiskstablemsg}\n")
     file.close()