From 1a8d1270117e6c823a3089c7ac598148212dffbf Mon Sep 17 00:00:00 2001 From: sanni Date: Thu, 6 Oct 2022 10:20:02 +0200 Subject: [PATCH] Increase romName array size from 17 to 22 Crashed with Lufia II(Estpolis II) before. --- Cart_Reader/Cart_Reader.ino | 10 ++++++---- Cart_Reader/SNES.ino | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Cart_Reader/Cart_Reader.ino b/Cart_Reader/Cart_Reader.ino index 674ec62..c6e4b71 100644 --- a/Cart_Reader/Cart_Reader.ino +++ b/Cart_Reader/Cart_Reader.ino @@ -4,7 +4,7 @@ This project represents a community-driven effort to provide an easy to build and easy to modify cartridge dumper. - Date: 28.09.2022 + Date: 06.10.2022 Version: 10.0 SD lib: https://github.com/greiman/SdFat @@ -376,7 +376,8 @@ boolean root = 0; boolean filebrowse = 0; // Common -char romName[17]; +// 21 chars for SNES ROM name, one char for termination +char romName[22]; unsigned long sramSize = 0; int romType = 0; byte saveType; @@ -401,9 +402,10 @@ unsigned long writeErrors; // Operation mode byte mode; -//remember folder number to create a new folder for every save +//remember folder number to create a new folder for every game int foldern; -char folder[36]; +// 4 chars for console type, 4 chars for SAVE/ROM, 21 chars for ROM name, 4 chars for folder number, 3 chars for slashes, one char for termination, one char savety +char folder[38]; // Array that holds the data byte sdBuffer[512]; diff --git a/Cart_Reader/SNES.ino b/Cart_Reader/SNES.ino index 7cf96c5..225d777 100644 --- a/Cart_Reader/SNES.ino +++ b/Cart_Reader/SNES.ino @@ -1011,7 +1011,7 @@ boolean checkcart_SNES() { // Get name byte myByte = 0; byte myLength = 0; - for (unsigned int i = 0xFFC0; i < 0xFFD4; i++) { + for (unsigned int i = 0xFFC0; i < 0xFFD5; i++) { myByte = snesHeader[i - headerStart]; if (isprint(myByte) && myByte != '<' && myByte != '>' && myByte != ':' && myByte != '"' && myByte != '/' && myByte != '\\' && myByte != '|' && myByte != '?' && myByte != '*') { romName[myLength] = char(myByte);