From 40238b18a12a8b6c2f56ad0a8331307b653caee2 Mon Sep 17 00:00:00 2001 From: Ancyker Date: Tue, 7 May 2024 17:16:51 -0400 Subject: [PATCH] Fixed (added) missing FS() macro on some FSTRING constants This was causing two symptoms/bugs: * OSCR_LOG.txt was being spammed with random data. * The size of OSCR_LOG.txt would get so big that copying the log would take a long time, possibly minutes. Oftentimes this caused the display to appear to hang after searching for the CRC (after "->") but before displaying the result. If using the global log and a version of master since e61ac414d89556c941f0b8ca76e5d7d6684037f0 you should delete OSCR_LOG.txt from your SD card as it will likely be very large and continue to cause dumping to be slow. --- Cart_Reader/Cart_Reader.ino | 2 +- Cart_Reader/N64.ino | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Cart_Reader/Cart_Reader.ino b/Cart_Reader/Cart_Reader.ino index 0d566af..00358e0 100644 --- a/Cart_Reader/Cart_Reader.ino +++ b/Cart_Reader/Cart_Reader.ino @@ -2566,7 +2566,7 @@ void display_Clear() { display.setCursor(0, 8); #endif #ifdef ENABLE_GLOBAL_LOG - if (!dont_log && loggingEnabled) myLog.println(FSTRING_EMPTY); + if (!dont_log && loggingEnabled) myLog.println(FS(FSTRING_EMPTY)); #endif } diff --git a/Cart_Reader/N64.ino b/Cart_Reader/N64.ino index aeb70ff..d9380f7 100644 --- a/Cart_Reader/N64.ino +++ b/Cart_Reader/N64.ino @@ -3057,7 +3057,7 @@ void savesummary_N64(boolean checkfound, char crcStr[9], unsigned long timeElaps myFile.print(F("Time\t: ")); myFile.println(timeElapsed); - myFile.println(FSTRING_SPACE); + myFile.println(FS(FSTRING_SPACE)); // Close the file: myFile.close();