Merge pull request #1027 from partlyhuman/lynx-fix-electrocop

Fix for overdumping Electrocop/Lynx
This commit is contained in:
sanni 2024-09-16 09:07:28 +02:00 committed by GitHub
commit 7ad07067c9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -40,7 +40,7 @@
// | 34 |- SWVCC
// +----+
//
// Version 1.1
// Version 1.2
// By @partlyhuman
// This implementation would not be possible without the invaluable
// documentation on
@ -125,9 +125,11 @@ static bool waitPressButton_LYNX(bool ret = false) {
static void compareStride_LYNX(uint8_t b, int i, int stride) {
uint8_t other = readByte_LYNX(i + stride);
if (other == 0xff) {
// If this is a flash cart, these in-between spaces should be formatted to all 1's
if (other == 0xff || other == 0x00) {
// If this is NOR flash, these in-between spaces should be formatted to all 1's
// in which case, we DON'T report this as an unmirrored area
// Additionally, we have encountered commercial carts where the maskrom is larger than it needs to be
// and in this case, the maskrom will be initialized to 0s, not 1s.
return;
}
if (b != other) {