Mirrors/cartreader
2
0
Fork 0
mirror of https://github.com/sanni/cartreader.git synced 2024-11-14 08:55:06 +01:00
Code Issues Projects Releases Wiki Activity

Fix buffer overflow in fileBrowser

Browse Source
This commit is contained in:
splash5 2019-10-07 11:34:22 +08:00
parent 22c88cd3fd
commit 991c7f8d6c
1 changed files with 22 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
Cart_Reader/Cart_Reader.ino
View File

@ -204,14 +204,18 @@ char menuOptions[7][20];
boolean ignoreError = 0; boolean ignoreError = 0;
// File browser // File browser
char fileName[26]; #define FILENAME_LENGTH 32
char filePath[50]; #define FILEPATH_LENGTH 64
#define FILEOPTS_LENGTH 20
char fileName[FILENAME_LENGTH];
char filePath[FILEPATH_LENGTH];
byte currPage; byte currPage;
byte lastPage; byte lastPage;
byte numPages; byte numPages;
boolean root = 0; boolean root = 0;
boolean filebrowse = 0; boolean filebrowse = 0;
char fileOptions[30][20]; char fileOptions[30][FILEOPTS_LENGTH];
// Common // Common
char romName[17]; char romName[17];
@ -1256,7 +1260,7 @@ unsigned char questionBox_OLED(const __FlashStringHelper* question, char answers
Filebrowser Module Filebrowser Module
*****************************************/ *****************************************/
void fileBrowser(const __FlashStringHelper* browserTitle) { void fileBrowser(const __FlashStringHelper* browserTitle) {
char fileNames[30][26]; char fileNames[30][FILENAME_LENGTH];
int currFile; int currFile;
filebrowse = 1; filebrowse = 1;
@ -1264,7 +1268,7 @@ void fileBrowser(const __FlashStringHelper* browserTitle) {
filePath[0] = '\0'; filePath[0] = '\0';
// Temporary char array for filename // Temporary char array for filename
char nameStr[26]; char nameStr[FILENAME_LENGTH];
browserstart: browserstart:
@ -1280,7 +1284,7 @@ browserstart:
while (myFile.openNext(sd.vwd(), O_READ)) { while (myFile.openNext(sd.vwd(), O_READ)) {
// Get name of file // Get name of file
myFile.getName(nameStr, 27); myFile.getName(nameStr, FILENAME_LENGTH);
// Ignore if hidden // Ignore if hidden
if (myFile.isHidden()) { if (myFile.isHidden()) {
@ -1288,21 +1292,17 @@ browserstart:
// Indicate a directory. // Indicate a directory.
else if (myFile.isDir()) { else if (myFile.isDir()) {
// Copy full dirname into fileNames // Copy full dirname into fileNames
sprintf(fileNames[currFile], "%s%s", "/", nameStr); snprintf(fileNames[currFile], FILENAME_LENGTH, "%s%s", "/", nameStr);
// Truncate to 19 letters for LCD
nameStr[19] = '\0';
// Copy short string into fileOptions // Copy short string into fileOptions
sprintf(fileOptions[currFile], "%s%s", "/", nameStr); snprintf(fileOptions[currFile], FILEOPTS_LENGTH, "%s%s", "/", nameStr);
currFile++; currFile++;
} }
// It's just a file // It's just a file
else if (myFile.isFile()) { else if (myFile.isFile()) {
// Copy full filename into fileNames // Copy full filename into fileNames
sprintf(fileNames[currFile], "%s", nameStr); snprintf(fileNames[currFile], FILENAME_LENGTH, "%s", nameStr);
// Truncate to 19 letters for LCD
nameStr[19] = '\0';
// Copy short string into fileOptions // Copy short string into fileOptions
sprintf(fileOptions[currFile], "%s", nameStr); snprintf(fileOptions[currFile], FILEOPTS_LENGTH, "%s", nameStr);
currFile++; currFile++;
} }
myFile.close(); myFile.close();
@ -1354,7 +1354,7 @@ page:
for (byte i = 0; i < 8; i++ ) { for (byte i = 0; i < 8; i++ ) {
// Copy short string into fileOptions // Copy short string into fileOptions
sprintf( answers[i], "%s", fileOptions[ ((currPage - 1) * 7 + i)] ); snprintf( answers[i], FILEOPTS_LENGTH, "%s", fileOptions[ ((currPage - 1) * 7 + i)] );
} }
// Create menu with title and 1-7 options to choose from // Create menu with title and 1-7 options to choose from
@ -1383,31 +1383,31 @@ page:
switch (answer) switch (answer)
{ {
case 0: case 0:
strcpy(fileName, fileNames[0 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[0 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 1: case 1:
strcpy(fileName, fileNames[1 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[1 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 2: case 2:
strcpy(fileName, fileNames[2 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[2 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 3: case 3:
strcpy(fileName, fileNames[3 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[3 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 4: case 4:
strcpy(fileName, fileNames[4 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[4 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 5: case 5:
strcpy(fileName, fileNames[5 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[5 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 6: case 6:
strcpy(fileName, fileNames[6 + ((currPage - 1) * 7)]); strncpy(fileName, fileNames[6 + ((currPage - 1) * 7)], FILENAME_LENGTH - 1);
break; break;
case 7: case 7: