Mirrors/cartreader
2
0
Fork 0
mirror of https://github.com/sanni/cartreader.git synced 2024-09-21 23:58:36 +02:00
Code Issues Projects Releases Wiki Activity

PCE.ino: Skip strcpy to menuOptionspceCart

Browse Source 
Values can be directly composed/initialised in menuOptionspceCart, avoiding
the need to strcpy to it.
This saves about 100 bytes of ram by dropping a few global char arrays.
Re-duplicates "Reset" string initialiser, but this should not be a big
deal.
This commit is contained in:
Vincent Pelletier 2022-10-22 01:34:13 +00:00
parent e7ef7fd4bd
commit ae2e90a6cd
1 changed files with 13 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
Cart_Reader/PCE.ino
View File

@ -58,14 +58,15 @@ static const char pceMenuItem3[] PROGMEM = "Turbochip";
static const char *const menuOptionspce[] PROGMEM = { pceMenuItem1, pceMenuItem2, pceMenuItem3, string_reset2 }; static const char *const menuOptionspce[] PROGMEM = { pceMenuItem1, pceMenuItem2, pceMenuItem3, string_reset2 };
// PCE card menu items // PCE card menu items
static const char pceCartMenuItem1[] = "Read ROM"; static char menuOptionspceCart[7][20] = {
static char pceCartMenuItem2[20]; "Read ROM",
static char pceCartMenuItem3[20]; "", // Read RAM Bank %d
//static const char pceCartMenuItem4[] = "Reset"; (stored in common strings array) "", //Write RAM Bank %d
static const char pceCartMenuItem5[] = "Inc Bank Number"; "Reset",
static const char pceCartMenuItem6[] = "Dec Bank Number"; "Inc Bank Number",
static char pceCartMenuItem7[20]; "Dec Bank Number",
static char menuOptionspceCart[7][20]; "" // ROM size now %dK / Force ROM size
};
// Turbochip menu items // Turbochip menu items
static const char pceTCMenuItem1[] PROGMEM = "Read ROM"; static const char pceTCMenuItem1[] PROGMEM = "Read ROM";
@ -795,20 +796,13 @@ void pceMenu() {
unsigned char mainMenu; unsigned char mainMenu;
if (pce_internal_mode == HUCARD || pce_internal_mode == HUCARD_NOSWAP) { if (pce_internal_mode == HUCARD || pce_internal_mode == HUCARD_NOSWAP) {
sprintf(pceCartMenuItem2, "Read RAM Bank %d", tennokoe_bank_index + 1); sprintf(menuOptionspceCart[1], "Read RAM Bank %d", tennokoe_bank_index + 1);
sprintf(pceCartMenuItem3, "Write RAM Bank %d", tennokoe_bank_index + 1); sprintf(menuOptionspceCart[2], "Write RAM Bank %d", tennokoe_bank_index + 1);
strcpy(menuOptionspceCart[0], pceCartMenuItem1);
strcpy(menuOptionspceCart[1], pceCartMenuItem2);
strcpy(menuOptionspceCart[2], pceCartMenuItem3);
strcpy(menuOptionspceCart[3], string_reset2); // (stored in common strings array)
strcpy(menuOptionspceCart[4], pceCartMenuItem5);
strcpy(menuOptionspceCart[5], pceCartMenuItem6);
if (pce_force_rom_size > 0) { if (pce_force_rom_size > 0) {
sprintf(pceCartMenuItem7, "ROM size now %dK", pce_force_rom_size); sprintf(menuOptionspceCart[6], "ROM size now %dK", pce_force_rom_size);
} else { } else {
sprintf(pceCartMenuItem7, "Force ROM size"); sprintf(menuOptionspceCart[6], "Force ROM size");
} }
strcpy(menuOptionspceCart[6], pceCartMenuItem7);
mainMenu = question_box(F("PCE HuCARD menu"), menuOptionspceCart, 7, 0); mainMenu = question_box(F("PCE HuCARD menu"), menuOptionspceCart, 7, 0);
// wait for user choice to come back from the question box menu // wait for user choice to come back from the question box menu