Mirrors/cartreader
2
0
Fork 0
mirror of https://github.com/sanni/cartreader.git synced 2025-03-12 22:36:36 +01:00
Code Issues Projects Releases Wiki Activity

Update Cart_Reader.ino

Browse Source 
- Remove incomingByte global variable, mark all uses as local
   variables. This leads to a tiny (yet measurable) decrease in global
   variable use, and no change in sketch memory use. Of course, the
   variable now resides in the stack, but only while the functions using
   it exist, which isn't always.
This commit is contained in:
Gabriel Marcano 2024-12-22 22:54:38 -08:00
parent 1a16fcf875
commit b2578512e5
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Cart_Reader/Cart_Reader.ino
View File

@ -267,11 +267,6 @@ boolean holdEventPast2 = false; // whether or not the hold event happened a
boolean longholdEventPast2 = false; // whether or not the long hold event happened already
#endif
#ifdef ENABLE_SERIAL
// For incoming serial data
int incomingByte;
#endif
// Variables for the menu
int choice = 0;
// Temporary array that holds the menu option read out of progmem
@ -2955,7 +2950,7 @@ byte questionBox_Serial(const __FlashStringHelper* question __attribute__((unuse
}
// Read the incoming byte:
incomingByte = Serial.read() - 48;
int incomingByte = Serial.read() - 48;
// Page up (u)
if (incomingByte == 69) {
@ -3197,7 +3192,7 @@ void checkUpdater() {
uint8_t checkButton() {
while (Serial.available() == 0) {
}
incomingByte = Serial.read() - 48;
int incomingByte = Serial.read() - 48;
//Next
if (incomingByte == 52) {
@ -3223,7 +3218,7 @@ void wait_serial() {
}
while (Serial.available() == 0) {
}
incomingByte = Serial.read() - 48;
int incomingByte = Serial.read() - 48;
/* if ((incomingByte == 53) && (fileName[0] != '\0')) {
// Open file on sd card
sd.chdir(folder);