Mirrors/cartreader
2
0
Fork 0
mirror of https://github.com/sanni/cartreader.git synced 2024-11-23 21:19:16 +01:00
Code Issues Projects Releases Wiki Activity

SFM.ino, SNES.ino: Rework compiler warnings resolution

Browse Source 
I am not sure why I changed some variables from 16 bit types to 8 bit types
when the warnings being resolved were only about signedness.
Fixes: a555f21 ("All: Resolve all compiler and linker warnings")
This commit is contained in:
Vincent Pelletier 2022-11-01 07:43:42 +00:00
parent cc17c70e30
commit c82815f0d5
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Cart_Reader/SFM.ino
View File

@ -912,7 +912,7 @@ void readROM_SFM() {
display_Update(); display_Update();
// Read up to 96 banks starting at bank 0×00. // Read up to 96 banks starting at bank 0×00.
for (byte currBank = 0; currBank < numBanks; currBank++) { for (word currBank = 0; currBank < numBanks; currBank++) {
// Dump the bytes to SD 512B at a time // Dump the bytes to SD 512B at a time
for (long currByte = 32768; currByte < 65536; currByte += 512) { for (long currByte = 32768; currByte < 65536; currByte += 512) {
for (int c = 0; c < 512; c++) { for (int c = 0; c < 512; c++) {
@ -1064,7 +1064,7 @@ void writeFlash_SFM(int startBank, uint32_t pos) {
draw_progressbar(0, totalProgressBar); draw_progressbar(0, totalProgressBar);
// Write lorom // Write lorom
for (byte currBank = 0; currBank < numBanks; currBank++) { for (word currBank = 0; currBank < numBanks; currBank++) {
for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 128) { for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 128) {
myFile.read(sdBuffer, 128); myFile.read(sdBuffer, 128);
// Write command sequence // Write command sequence
@ -1179,7 +1179,7 @@ byte blankcheck_SFM(int startBank) {
} }
} }
} else { } else {
for (byte currBank = 0; currBank < numBanks; currBank++) { for (word currBank = 0; currBank < numBanks; currBank++) {
for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte++) { for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte++) {
if (readBank_SFM(currBank, currByte) != 0xFF) { if (readBank_SFM(currBank, currByte) != 0xFF) {
currBank = numBanks; currBank = numBanks;
@ -1219,7 +1219,7 @@ unsigned long verifyFlash_SFM(int startBank, uint32_t pos) {
} }
} }
} else { } else {
for (byte currBank = 0; currBank < numBanks; currBank++) { for (word currBank = 0; currBank < numBanks; currBank++) {
for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 512) { for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 512) {
// Fill SDBuffer // Fill SDBuffer
myFile.read(sdBuffer, 512); myFile.read(sdBuffer, 512);
@ -1268,7 +1268,7 @@ void readFlash_SFM() {
} }
} }
} else { } else {
for (byte currBank = 0; currBank < numBanks; currBank++) { for (word currBank = 0; currBank < numBanks; currBank++) {
for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 512) { for (unsigned long currByte = 0x8000; currByte < 0x10000; currByte += 512) {
for (int c = 0; c < 512; c++) { for (int c = 0; c < 512; c++) {
sdBuffer[c] = readBank_SFM(currBank, currByte + c); sdBuffer[c] = readBank_SFM(currBank, currByte + c);

2
Cart_Reader/SNES.ino
View File

@ -1344,7 +1344,7 @@ void readROM_SNES() {
controlIn_SNES(); controlIn_SNES();
byte initialSOMap = readBank_SNES(0, 18439); byte initialSOMap = readBank_SNES(0, 18439);
for (byte currMemmap = 0; currMemmap < (numBanks / 16); currMemmap++) { for (word currMemmap = 0; currMemmap < (numBanks / 16); currMemmap++) {
dataOut(); dataOut();
controlOut_SNES(); controlOut_SNES();