Mirrors/cartreader
2
0
Fork 0
mirror of https://github.com/sanni/cartreader.git synced 2024-11-27 15:04:15 +01:00
Code Issues Projects Releases Wiki Activity

Card_Reader.ino: Optimise get_line for speed

Browse Source 
Do fewer calls to readfile->read, especially if the buffer is large enough
to fit an entire line, resulting in less call/return overhead.
This commit is contained in:
Vincent Pelletier 2022-10-25 15:09:08 +00:00
parent 50da6b9da7
commit daec1f3e35
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Cart_Reader/Cart_Reader.ino
View File

@ -590,28 +590,29 @@ void skip_line(FsFile* readfile) {
//Get line from file
void get_line(char* str_buf, FsFile* readfile, uint8_t maxi) {
int read_len;
// Status LED on
statusLED(true);
int i = 0;
while (readfile->available()) {
//If line size is more than maximum array, limit it.
if (i >= maxi) {
i = maxi - 1;
}
//Read 1 byte from file
str_buf[i] = readfile->read();
read_len = readfile->read(str_buf, maxi - 1);
for (int i = 0; i < read_len; i++) {
//if end of file or newline found, execute command
if (str_buf[i] == '\r') {
str_buf[i] = '\0';
readfile->read(); //dispose \n because \r\n
str_buf[i] = 0;
readfile->seekCur(i - read_len + 2); // +2 to skip over \n because \r\n
return;
}
}
str_buf[maxi - 1] = 0;
// EOL was not found, keep looking (slower)
while (readfile->available()) {
if (readfile->read() == '\r') {
readfile->read(); // read \n because \r\n
break;
}
i++;
} //End while
}
}
// Calculate CRC32 if needed and compare it to CRC read from database