Mirrors/lgogdownloader
2
0
Fork 0
mirror of https://github.com/Sude-/lgogdownloader.git synced 2025-02-08 16:33:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix skipped file downloads due to race condition

Browse Source 
If multiple threads detected that directory didn't exist at the same time and tried to create it then one thread would succeed in creating it first and other threads would be trying to create a directory that already exists.
boost::filesystem::create_directories() would then return false for those threads and skip the file download.

Having additional check to see if the directory exists after boost::filesystem::create_directories() returns false fixes the problem.
This commit is contained in:
Sude 2016-11-03 21:51:20 +02:00
parent fb565f4493
commit 4c480465b3
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/downloader.cpp
View File

@ -2960,7 +2960,7 @@ void Downloader::processDownloadQueue(Config conf, const unsigned int& tid)
{
if (!boost::filesystem::is_directory(directory))
{
msgQueue.push(Message(directory.string() + " is not directory", MSGTYPE_WARNING, msg_prefix));
msgQueue.push(Message(directory.string() + " is not directory, skipping file (" + filepath.filename().string() + ")", MSGTYPE_WARNING, msg_prefix));
continue;
}
}
@ -2968,8 +2968,14 @@ void Downloader::processDownloadQueue(Config conf, const unsigned int& tid)
{
if (!boost::filesystem::create_directories(directory))
{
msgQueue.push(Message("Failed to create directory: " + directory.string(), MSGTYPE_ERROR, msg_prefix));
continue;
/* Multiple threads could have tried to create the directory at the same time because they detected that the directory didn't exist at the time
* boost::filesystem::create_directories() could have returned false because of this race condition so we have to check again if directory exists */
if (!boost::filesystem::exists(directory))
{
// Failed to create directory and another thread hasn't created it either. Print error and skip the file download.
msgQueue.push(Message("Failed to create directory (" + directory.string() + "), skipping file (" + filepath.filename().string() + ")", MSGTYPE_ERROR, msg_prefix));
continue;
}
}
}