From 32e16756178a58a1d7909bf30461b621a98dd354 Mon Sep 17 00:00:00 2001 From: Jip Fr Date: Thu, 15 Jul 2021 18:29:29 +0200 Subject: [PATCH 1/3] chore: remove TODO comment --- src/components/VideoElement.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/components/VideoElement.js b/src/components/VideoElement.js index 381fb27c..a1cce9b6 100644 --- a/src/components/VideoElement.js +++ b/src/components/VideoElement.js @@ -27,8 +27,6 @@ export function VideoElement({ streamUrl, loading }) { hls.loadSource(streamUrl); }, [videoRef, streamUrl, loading]) - // TODO make better loading/error/empty state - if (error) return (Your browser is not supported) From 032331d7d7a18d1fff0d113eb2aa4035509b7b96 Mon Sep 17 00:00:00 2001 From: Jip Fr Date: Thu, 15 Jul 2021 18:41:51 +0200 Subject: [PATCH 2/3] style(theming): complete theming --- src/components/Progress.css | 2 +- src/components/Title.css | 2 +- src/components/TypeSelector.css | 6 +++--- src/components/VideoElement.css | 2 +- src/components/VideoElement.js | 2 +- src/index.css | 4 +--- src/views/Search.css | 2 +- 7 files changed, 9 insertions(+), 11 deletions(-) diff --git a/src/components/Progress.css b/src/components/Progress.css index a0116519..eb7e9d73 100644 --- a/src/components/Progress.css +++ b/src/components/Progress.css @@ -24,7 +24,7 @@ .progress .bar { width: 13rem; max-width: 100%; - background-color: #35363D; + background-color: var(--content); border-radius: 10px; height: 7px; display: inline-block; diff --git a/src/components/Title.css b/src/components/Title.css index c5691634..5e749821 100644 --- a/src/components/Title.css +++ b/src/components/Title.css @@ -12,7 +12,7 @@ } .title-size-small { font-size: 1.1rem; - color: #afb1b8; + color: var(--text-secondary); } .title-accent { diff --git a/src/components/TypeSelector.css b/src/components/TypeSelector.css index 39273f17..80902e74 100644 --- a/src/components/TypeSelector.css +++ b/src/components/TypeSelector.css @@ -13,7 +13,7 @@ position: absolute; width: 100%; bottom: 0; - background-color: #3a3c46; + background-color: var(--content); height: 4px; border-radius: 2px; } @@ -27,14 +27,14 @@ align-items: center; text-align: center; box-sizing: border-box; - color: #585A67; + color: var(--text-tertiary); font-weight: bold; cursor: pointer; user-select: none; } .typeSelector .choice:hover { - color: #afb1b8; + color: var(--text-secondary); } .typeSelector .choice.selected { diff --git a/src/components/VideoElement.css b/src/components/VideoElement.css index bb829039..cff2fd1d 100644 --- a/src/components/VideoElement.css +++ b/src/components/VideoElement.css @@ -1,6 +1,6 @@ .videoElement { width: 100%; - background-color: #111117; + background-color: var(--content); border-radius: 5px; } diff --git a/src/components/VideoElement.js b/src/components/VideoElement.js index a1cce9b6..f1aa506a 100644 --- a/src/components/VideoElement.js +++ b/src/components/VideoElement.js @@ -34,7 +34,7 @@ export function VideoElement({ streamUrl, loading }) { return Loading episode... if (!streamUrl || streamUrl.length === 0) - return No video selected + return No video selected return (