From 36eb8d599a746137fe1ec65af754303c492f179c Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:18:54 +0200 Subject: [PATCH 1/6] update linting action --- .github/workflows/linting.yml | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 33db8187..b43b4f01 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -14,21 +14,16 @@ jobs: runs-on: ubuntu-latest steps: - - name: Check out Git repository + - name: Checkout code uses: actions/checkout@v2 - - - name: Set up Node.js + + - name: Install Node.js uses: actions/setup-node@v1 with: node-version: 16 - - - name: Install Node.js dependencies + + - name: Install Yarn packages run: yarn install - + - name: Run linters - uses: wearerequired/lint-action@v2 - with: - eslint: true - eslint_args: --max-warnings=0 src - eslint_extensions: tsx,ts - eslint_auto_fix: false \ No newline at end of file + run: yarn lint From 660793395b8d638e071ff045fe145b4389565e93 Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:24:46 +0200 Subject: [PATCH 2/6] test commit --- src/App.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/App.tsx b/src/App.tsx index e67c09b8..178bbe1f 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -8,6 +8,7 @@ import { MediaView } from "./views/MediaView"; import { SearchView } from "./views/SearchView"; function App() { + const test = "abasdf"; return ( From 28d6011d064d355ae979ae22195a1f3d6ae41b27 Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:26:32 +0200 Subject: [PATCH 3/6] more tests --- src/App.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/App.tsx b/src/App.tsx index 178bbe1f..c78c40e6 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -9,6 +9,8 @@ import { SearchView } from "./views/SearchView"; function App() { const test = "abasdf"; + + return ( From 333e0468f3caf39fd7dd8037ae61d63211eeb8ff Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:27:30 +0200 Subject: [PATCH 4/6] whoops, ignore these commits --- src/App.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/App.tsx b/src/App.tsx index c78c40e6..419edab9 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -8,9 +8,7 @@ import { MediaView } from "./views/MediaView"; import { SearchView } from "./views/SearchView"; function App() { - const test = "abasdf"; - return ( From 1fd59b7ef24de140c86517c27ca92ee045eaece3 Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:31:13 +0200 Subject: [PATCH 5/6] change linting event target --- .github/workflows/linting.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index b43b4f01..6f02b962 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -5,7 +5,7 @@ on: branches: - master - dev - pull_request_target: + pull_request: types: [opened, reopened, synchronize] jobs: From 428e6eb95804d455af3944c825db092a2673023c Mon Sep 17 00:00:00 2001 From: Jelle van Snik Date: Mon, 2 May 2022 17:35:34 +0200 Subject: [PATCH 6/6] update linting config --- .github/workflows/linting.yml | 2 +- package.json | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 6f02b962..4120bd3c 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -26,4 +26,4 @@ jobs: run: yarn install - name: Run linters - run: yarn lint + run: yarn lint:strict diff --git a/package.json b/package.json index c706ce7f..eba69296 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,8 @@ "scripts": { "start": "react-scripts start", "build": "react-scripts build", - "lint": "eslint --ext .tsx,.ts src" + "lint": "eslint --ext .tsx,.ts src", + "lint:strict": "eslint --ext .tsx,.ts --max-warnings 0 src" }, "browserslist": { "production": [