Mirrors/movie-web
2
0
Fork 0
mirror of https://github.com/movie-web/movie-web.git synced 2024-12-24 18:41:48 +01:00
Code Issues Packages Projects Releases Wiki Activity

some small error boundary updates

Browse Source
This commit is contained in:
Jelle van Snik 2022-02-18 14:55:22 +01:00
parent 36737490a8
commit d362ca2af4
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
README.md
View File

@ -45,3 +45,4 @@ Check out [this project's issues](https://github.com/JamesHawkinss/movie-web/iss
- [x] Better looking error boundary - [x] Better looking error boundary
- [ ] sort search results so they aren't sorted by provider - [ ] sort search results so they aren't sorted by provider
- [ ] Get rid of react warnings - [ ] Get rid of react warnings
- [ ] Link Github and Discord in error boundary

5
src/components/layout/ErrorBoundary.tsx
View File

@ -42,7 +42,6 @@ export class ErrorBoundary extends Component<{}, ErrorBoundaryState> {
render() { render() {
if (!this.state.hasError) return this.props.children; if (!this.state.hasError) return this.props.children;
// TODO make pretty
return ( return (
<div className="flex min-h-screen w-full flex-col items-center justify-center px-4 py-12"> <div className="flex min-h-screen w-full flex-col items-center justify-center px-4 py-12">
<div className="flex flex-col items-center justify-start text-center"> <div className="flex flex-col items-center justify-start text-center">
@ -54,8 +53,8 @@ export class ErrorBoundary extends Component<{}, ErrorBoundaryState> {
</p> </p>
</div> </div>
{this.state.error ? ( {this.state.error ? (
<div className="bg-denim-300 mt-12 max-w-4xl rounded px-6 py-4"> <div className="bg-denim-300 w-4xl mt-12 max-w-full rounded px-6 py-4">
<p className="mb-2 break-words font-bold text-white"> <p className="mb-1 break-words font-bold text-white">
{this.state.error.name} - {this.state.error.description} {this.state.error.name} - {this.state.error.description}
</p> </p>
<p className="break-words">{this.state.error.path}</p> <p className="break-words">{this.state.error.path}</p>

1
src/views/SearchView.tsx
View File

@ -19,7 +19,6 @@ import { useLoading } from "hooks/useLoading";
import { IconPatch } from "components/Buttons/IconPatch"; import { IconPatch } from "components/Buttons/IconPatch";
function SearchLoading() { function SearchLoading() {
throw new Error("testing");
return <Loading className="my-12" text="Fetching your favourite shows..." />; return <Loading className="my-12" text="Fetching your favourite shows..." />;
} }