Mirrors/movie-web
2
0
Fork 0
mirror of https://github.com/movie-web/movie-web.git synced 2024-11-13 08:35:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

source reset bug fixes (HLS fix & volume fix)

Browse Source
This commit is contained in:
Jelle van Snik 2023-02-12 13:06:30 +01:00
parent 886ffe78ef
commit dcc158e705
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/video/state/init.ts
View File

@ -12,7 +12,7 @@ export function resetForSource(s: VideoPlayerState) {
isDragSeeking: false,
isFirstLoading: true,
hasPlayedOnce: false,
volume: 0,
volume: state.mediaPlaying.volume, // volume settings needs to persist through resets
};
state.progress = {
time: 0,

10
src/video/state/providers/videoStateProvider.ts
View File

@ -129,18 +129,22 @@ export function createVideoStateProvider(
},
setSource(source) {
if (!source) {
resetStateForSource(descriptor, state);
player.src = "";
state.source = null;
resetStateForSource(descriptor, state);
updateSource(descriptor, state);
return;
}
// reset before assign new one so the old HLS instance gets destroyed
resetStateForSource(descriptor, state);
if (source?.type === MWStreamType.HLS) {
if (player.canPlayType("application/vnd.apple.mpegurl")) {
// HLS supported natively by browser
player.src = source.source;
} else {
// HLS support
// HLS through HLS.js
if (!Hls.isSupported()) {
state.error = {
name: `Not supported`,
@ -168,6 +172,7 @@ export function createVideoStateProvider(
hls.loadSource(source.source);
}
} else if (source.type === MWStreamType.MP4) {
// standard MP4 stream
player.src = source.source;
}
@ -178,7 +183,6 @@ export function createVideoStateProvider(
url: source.source,
caption: null,
};
resetStateForSource(descriptor, state);
updateSource(descriptor, state);
},
setCaption(id, url) {