From e4ad8789b9309509104e3fd0b381d05b2a50ceb9 Mon Sep 17 00:00:00 2001
From: mrjvs <jellevs@gmail.com>
Date: Sat, 20 Jan 2024 13:54:32 +0100
Subject: [PATCH] Add todos and fix some highlights

---
 src/pages/onboarding/OnboardingExtension.tsx |  2 ++
 src/pages/onboarding/OnboardingProxy.tsx     |  1 +
 src/pages/parts/settings/SetupPart.tsx       | 14 ++++++++++----
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/pages/onboarding/OnboardingExtension.tsx b/src/pages/onboarding/OnboardingExtension.tsx
index ce699884..ffa4bc84 100644
--- a/src/pages/onboarding/OnboardingExtension.tsx
+++ b/src/pages/onboarding/OnboardingExtension.tsx
@@ -47,6 +47,7 @@ export function ExtensionStatus(props: {
         <p>{t("onboarding.extension.status.loading")}</p>
       </>
     );
+  // TODO make proper actions for all of these states below
   if (props.status === "disallowed")
     content = <p>{t("onboarding.extension.status.disallowed")}</p>;
   else if (props.status === "failed")
@@ -81,6 +82,7 @@ export function OnboardingExtensionPage() {
   );
   useInterval(exec, 1000);
 
+  // TODO proper link to install extension
   return (
     <MinimalPageLayout>
       <PageTitle subpage k="global.pages.onboarding" />
diff --git a/src/pages/onboarding/OnboardingProxy.tsx b/src/pages/onboarding/OnboardingProxy.tsx
index 24595568..1d3b6b7c 100644
--- a/src/pages/onboarding/OnboardingProxy.tsx
+++ b/src/pages/onboarding/OnboardingProxy.tsx
@@ -40,6 +40,7 @@ export function OnboardingProxyPage() {
     }
   }, [url, completeAndRedirect, setProxySet]);
 
+  // TODO proper link to proxy deployment docs
   return (
     <MinimalPageLayout>
       <PageTitle subpage k="global.pages.onboarding" />
diff --git a/src/pages/parts/settings/SetupPart.tsx b/src/pages/parts/settings/SetupPart.tsx
index e9508d48..074f920d 100644
--- a/src/pages/parts/settings/SetupPart.tsx
+++ b/src/pages/parts/settings/SetupPart.tsx
@@ -76,6 +76,7 @@ function useIsSetup() {
 function SetupCheckList(props: {
   status: Status;
   grey?: boolean;
+  highlight?: boolean;
   children?: ReactNode;
 }) {
   const { t } = useTranslation();
@@ -98,9 +99,10 @@ function SetupCheckList(props: {
       <div>
         <p
           className={classNames({
-            "text-type-dimmed opacity-75": props.grey,
+            "!text-white": props.grey && props.highlight,
+            "!text-type-dimmed opacity-75": props.grey && !props.highlight,
             "text-type-danger": props.status === "error",
-            "text-white !opacity-100": props.status === "success",
+            "text-white": props.status === "success",
           })}
         >
           {props.children}
@@ -119,7 +121,7 @@ export function SetupPart() {
   const { t } = useTranslation();
   const navigate = useNavigate();
   const { loading, setupStates, globalState } = useIsSetup();
-  if (loading || !setupStates) return <p>Loading states...</p>;
+  if (loading || !setupStates) return <p>Loading states...</p>; // TODO proper loading screen
 
   const textLookupMap: Record<
     Status,
@@ -174,7 +176,11 @@ export function SetupPart() {
           <SetupCheckList status={setupStates.proxy}>
             {t("settings.connections.setup.items.proxy")}
           </SetupCheckList>
-          <SetupCheckList grey status={setupStates.defaultProxy}>
+          <SetupCheckList
+            grey
+            highlight={globalState === "unset"}
+            status={setupStates.defaultProxy}
+          >
             {t("settings.connections.setup.items.default")}
           </SetupCheckList>
         </div>