From fde90d4e8f88bc51bcd0869cd846110aeea344b0 Mon Sep 17 00:00:00 2001 From: James Hawkins Date: Mon, 2 May 2022 19:12:04 +0100 Subject: [PATCH] Review comments --- .eslintrc.js | 6 +++++- src/providers/list/xemovie/index.ts | 6 +----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 8e91e06d..6f5cb2dc 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -1,5 +1,5 @@ const a11yOff = Object.keys(require('eslint-plugin-jsx-a11y').rules) - .reduce((acc, rule) => { acc[`jsx-a11y/${rule}`] = 'off'; return acc }, {}) + .reduce((acc, rule) => { acc[`jsx-a11y/${rule}`] = 'off'; return acc }, {}) module.exports = { extends: [ @@ -37,6 +37,10 @@ module.exports = { "@typescript-eslint/no-shadow": ["error"], "no-restricted-syntax": "off", "react/jsx-props-no-spreading": "off", + "consistent-return": "off", + "no-continue": "off", + "no-eval": "off", + "no-await-in-loop": "off", "react/jsx-filename-extension": [ "error", { extensions: [".js", ".tsx", ".jsx"] }, diff --git a/src/providers/list/xemovie/index.ts b/src/providers/list/xemovie/index.ts index 24e14bde..7fe16ab2 100644 --- a/src/providers/list/xemovie/index.ts +++ b/src/providers/list/xemovie/index.ts @@ -53,7 +53,6 @@ export const xemovieScraper: MWMediaProvider = { const aElement = parent.querySelector("a"); if (!aElement) return; - // eslint-disable-next-line consistent-return return { title: parent.querySelector("div > div > a > h6")?.textContent, year: parent.querySelector("div.float-right")?.textContent, @@ -76,17 +75,14 @@ export const xemovieScraper: MWMediaProvider = { const scripts = Array.from(new DOMParser().parseFromString(res, "text/html").querySelectorAll("script")); for (const script of scripts) { - // eslint-disable-next-line no-continue if (!script.textContent) continue; if (script.textContent.match(/https:\/\/[a-z][0-9]\.xemovie\.com/)) { - // eslint-disable-next-line - let data = JSON.parse(JSON.stringify(eval(`(${script.textContent.replace("const data = ", "").split("};")[0]}})`))); + const data = JSON.parse(JSON.stringify(eval(`(${script.textContent.replace("const data = ", "").split("};")[0]}})`))); streamUrl = data.playlist[0].file; for (const [index, subtitleTrack] of data.playlist[0].tracks.entries()) { const subtitleBlob = URL.createObjectURL( - // eslint-disable-next-line no-await-in-loop await fetch(`${CORS_PROXY_URL}${subtitleTrack.file}`).then((captionRes) => captionRes.blob()) ); // do this so no need for CORS errors