From 4dfb8c8926e7ad591063b72d595ea47123ff15f4 Mon Sep 17 00:00:00 2001 From: Andreas Date: Sat, 8 May 2021 11:01:29 +0200 Subject: [PATCH] Add guidelines for images and videos (#643) * Add guidelines for images and videos --- .../assets/tachiyomi-handbrake-profile.json | 111 ++++++++++++++++++ CONTRIBUTING.md | 22 ++++ 2 files changed, 133 insertions(+) create mode 100644 .github/assets/tachiyomi-handbrake-profile.json diff --git a/.github/assets/tachiyomi-handbrake-profile.json b/.github/assets/tachiyomi-handbrake-profile.json new file mode 100644 index 00000000..dca1ac12 --- /dev/null +++ b/.github/assets/tachiyomi-handbrake-profile.json @@ -0,0 +1,111 @@ +{ + "PresetList": [ + { + "AlignAVStart": false, + "AudioCopyMask": [ + "copy:aac", + "copy:ac3", + "copy:dtshd", + "copy:dts", + "copy:mp3", + "copy:truehd", + "copy:flac", + "copy:eac3" + ], + "AudioEncoderFallback": "ac3", + "AudioLanguageList": [], + "AudioList": [ + { + "AudioBitrate": 128, + "AudioCompressionLevel": 0.0, + "AudioEncoder": "av_aac", + "AudioMixdown": "stereo", + "AudioNormalizeMixLevel": false, + "AudioSamplerate": "auto", + "AudioTrackQualityEnable": false, + "AudioTrackQuality": -1.0, + "AudioTrackGainSlider": 0.0, + "AudioTrackDRCSlider": 0.0 + } + ], + "AudioSecondaryEncoderMode": true, + "AudioTrackSelectionBehavior": "first", + "ChapterMarkers": false, + "ChildrenArray": [], + "Default": false, + "FileFormat": "av_webm", + "Folder": false, + "FolderOpen": false, + "Mp4HttpOptimize": false, + "Mp4iPodCompatible": false, + "PictureAutoCrop": true, + "PictureBottomCrop": 0, + "PictureLeftCrop": 0, + "PictureRightCrop": 0, + "PictureTopCrop": 0, + "PictureDARWidth": 512, + "PictureDeblockPreset": "off", + "PictureDeblockTune": "medium", + "PictureDeblockCustom": "strength=strong:thresh=20:blocksize=8", + "PictureDeinterlaceFilter": "decomb", + "PictureCombDetectPreset": "default", + "PictureCombDetectCustom": "", + "PictureDeinterlacePreset": "default", + "PictureDeinterlaceCustom": "", + "PictureDenoiseCustom": "", + "PictureDenoiseFilter": "off", + "PictureDenoisePreset": "light", + "PictureDenoiseTune": "none", + "PictureSharpenCustom": "", + "PictureSharpenFilter": "off", + "PictureSharpenPreset": "medium", + "PictureSharpenTune": "none", + "PictureDetelecine": "off", + "PictureDetelecineCustom": "", + "PictureItuPAR": false, + "PictureKeepRatio": true, + "PictureLooseCrop": false, + "PictureModulus": 2, + "PicturePAR": "auto", + "PicturePARWidth": 3452, + "PicturePARHeight": 4369, + "PictureWidth": 0, + "PictureHeight": 0, + "PictureForceHeight": 0, + "PictureForceWidth": 0, + "PresetName": "Tachiyomi HandBrake Profile", + "Type": 1, + "UsesPictureFilters": true, + "UsesPictureSettings": 0, + "SubtitleAddCC": false, + "SubtitleAddForeignAudioSearch": true, + "SubtitleAddForeignAudioSubtitle": false, + "SubtitleBurnBehavior": "foreign", + "SubtitleBurnBDSub": false, + "SubtitleBurnDVDSub": false, + "SubtitleLanguageList": [], + "SubtitleTrackSelectionBehavior": "none", + "VideoAvgBitrate": 0, + "VideoColorMatrixCode": 0, + "VideoEncoder": "VP9", + "VideoFramerate": "24", + "VideoFramerateMode": "pfr", + "VideoGrayScale": false, + "VideoScaler": "swscale", + "VideoPreset": "medium", + "VideoTune": "", + "VideoLevel": "auto", + "VideoOptionExtra": "", + "VideoQualityType": 2, + "VideoQualitySlider": 21.0, + "VideoQSVDecode": false, + "VideoQSVAsyncDepth": 4, + "VideoTwoPass": true, + "VideoTurboTwoPass": false, + "x264UseAdvancedOptions": false + } + ], + "VersionMajor": 42, + "VersionMicro": 0, + "VersionMinor": 0 +} \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6250a7a5..05ba49de 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,6 +5,7 @@ Before submitting your contribution, please make sure to take a moment and read - [Code of Conduct](./CODE_OF_CONDUCT.md) - [Development Setup](#development-setup) - [Project Structure](#project-structure) +- [Images and Videos guidelines](#images-and-videos-guidelines) ## Development Setup @@ -82,6 +83,27 @@ $ npm run lint - `package.json`: contains information about which plugins are installed in the project. +## Images and Videos guidelines + +### Common +- Use the Android Emulator + +- Use the white theme + +- Preferably use local source or a self-hosted extension + - If you are going to show a manga + +- Resize to have a width of 648px + +### Images +- Use `.png` format + +### Videos +- Use `.webm` format + - Encode it with our [HandBrake profile](../.github/tachiyomi-handbrake-profile.json) + +- Remove audio track + ## Credits Thank you to all the people who have already contributed!