From 6a660e98fdf4cc5950016a35592d9a52fc5de551 Mon Sep 17 00:00:00 2001
From: Soitora <simon.mattila@protonmail.com>
Date: Wed, 29 Jul 2020 19:36:55 +0200
Subject: [PATCH] Create global constants file (#273)

* Create global constants file

* Update constants import for all files

* Tweak project style guides

Change printWidth from 80, recommended project widths were at 100/120 so I choose 120.

Also while I'm doing it, tweak the EndOfLine setting to prevent VS Code from going ham on LF/CRLF sets.

* Remove the ESLint ignore lines in PR

And other import whitespace near it

* SNAKE_CASE constants instead of camelCase
---
 .eslintrc.json                               |  6 ++++--
 .prettierrc                                  |  3 ++-
 src/.vuepress/components/DownloadButtons.vue | 12 ++++--------
 src/.vuepress/components/ExtensionList.vue   |  6 ++----
 src/.vuepress/components/ReleaseNotes.vue    |  6 ++----
 src/.vuepress/components/VersionTag.vue      |  6 ++----
 src/.vuepress/constants.js                   |  4 ++++
 src/.vuepress/theme/components/Home.vue      | 15 ++++-----------
 8 files changed, 24 insertions(+), 34 deletions(-)
 create mode 100644 src/.vuepress/constants.js

diff --git a/.eslintrc.json b/.eslintrc.json
index b0d38a5b..6d35f3aa 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -23,10 +23,12 @@
 		"markdown"
 	],
 	"rules": {
-		"prettier/prettier": "error",
+		"prettier/prettier": ["error", {
+		   "endOfLine":"auto"
+		 }],
 		"import/no-unresolved": [
 			2,
 			{ "ignore": ["^@"] }
 		]
 	}
-}
\ No newline at end of file
+}
diff --git a/.prettierrc b/.prettierrc
index 15e442db..ddbf76db 100644
--- a/.prettierrc
+++ b/.prettierrc
@@ -1,7 +1,8 @@
 {
 	"tabWidth": 4,
 	"useTabs": true,
+	"printWidth": 120,
 	"trailingComma": "es5",
 	"bracketSpacing": true,
-	"endOfLine": "lf"
+	"endOfLine": "auto"
 }
diff --git a/src/.vuepress/components/DownloadButtons.vue b/src/.vuepress/components/DownloadButtons.vue
index 2215f426..dba72dbf 100644
--- a/src/.vuepress/components/DownloadButtons.vue
+++ b/src/.vuepress/components/DownloadButtons.vue
@@ -11,11 +11,7 @@
 
 <script>
 import axios from "axios";
-
-const RELEASE_URL =
-	"https://api.github.com/repos/inorichi/tachiyomi/releases/latest";
-
-const PREVIEW_URL = "https://tachiyomi.kanade.eu/latest";
+import { GITHUB_LATEST_API, GITHUB_LATEST_RELEASE, KANADE_LATEST } from "../constants";
 
 export default {
 	props: {
@@ -53,7 +49,7 @@ export default {
 	},
 
 	async mounted() {
-		const { data } = await axios.get(RELEASE_URL);
+		const { data } = await axios.get(GITHUB_LATEST_API);
 		// Maybe eventually some release has more than the apk in assets.
 		const apkAsset = data.assets.find((a) => a.name.includes(".apk"));
 		// Set the values.
@@ -85,7 +81,7 @@ export default {
 			window.location.assign(
 				this.$props.downloadStableUrl ||
 					this.$data.browserDownloadUrl ||
-					RELEASE_URL
+					GITHUB_LATEST_RELEASE
 			);
 			window.ga(
 				"send",
@@ -116,7 +112,7 @@ export default {
 				},
 			});
 			window.location.assign(
-				this.$props.downloadPreviewUrl || PREVIEW_URL
+				this.$props.downloadPreviewUrl || KANADE_LATEST
 			);
 			window.ga(
 				"send",
diff --git a/src/.vuepress/components/ExtensionList.vue b/src/.vuepress/components/ExtensionList.vue
index 62933fcc..e2945429 100644
--- a/src/.vuepress/components/ExtensionList.vue
+++ b/src/.vuepress/components/ExtensionList.vue
@@ -47,9 +47,7 @@ import axios from "axios";
 import groupBy from "lodash.groupby";
 import sortBy from "lodash.sortby";
 import ISO6391 from "iso-639-1";
-
-const EXTENSION_JSON =
-	"https://raw.githubusercontent.com/inorichi/tachiyomi-extensions/repo/index.json";
+import { GITHUB_EXTENSION_JSON } from "../constants";
 
 export default {
 	data() {
@@ -59,7 +57,7 @@ export default {
 	},
 
 	async beforeMount() {
-		const { data } = await axios.get(EXTENSION_JSON);
+		const { data } = await axios.get(GITHUB_EXTENSION_JSON);
 		const values = Object.values(groupBy(data, "lang"));
 		this.$data.extensions = sortBy(values, [
 			(g) => this.langName(g[0].lang),
diff --git a/src/.vuepress/components/ReleaseNotes.vue b/src/.vuepress/components/ReleaseNotes.vue
index a62d6e65..a7524db4 100644
--- a/src/.vuepress/components/ReleaseNotes.vue
+++ b/src/.vuepress/components/ReleaseNotes.vue
@@ -5,9 +5,7 @@
 <script>
 import axios from "axios";
 import marked from "marked";
-
-const RELEASE_URL =
-	"https://api.github.com/repos/inorichi/tachiyomi/releases/latest";
+import { GITHUB_LATEST_API } from "../constants";
 
 export default {
 	data() {
@@ -17,7 +15,7 @@ export default {
 	},
 
 	async mounted() {
-		const { data } = await axios.get(RELEASE_URL);
+		const { data } = await axios.get(GITHUB_LATEST_API);
 		this.$data.releaseNotes = marked(data.body);
 	},
 };
diff --git a/src/.vuepress/components/VersionTag.vue b/src/.vuepress/components/VersionTag.vue
index fb295a83..b43a4dc0 100644
--- a/src/.vuepress/components/VersionTag.vue
+++ b/src/.vuepress/components/VersionTag.vue
@@ -11,9 +11,7 @@
 
 <script>
 import axios from "axios";
-
-const RELEASE_URL =
-	"https://api.github.com/repos/inorichi/tachiyomi/releases/latest";
+import { GITHUB_LATEST_API } from "../constants";
 
 export default {
 	props: {
@@ -29,7 +27,7 @@ export default {
 	},
 
 	async mounted() {
-		const { data } = await axios.get(RELEASE_URL);
+		const { data } = await axios.get(GITHUB_LATEST_API);
 		// Set the values.
 		this.$data.tagName = data.tag_name;
 	},
diff --git a/src/.vuepress/constants.js b/src/.vuepress/constants.js
new file mode 100644
index 00000000..2edf4f84
--- /dev/null
+++ b/src/.vuepress/constants.js
@@ -0,0 +1,4 @@
+export const GITHUB_EXTENSION_JSON = "https://raw.githubusercontent.com/inorichi/tachiyomi-extensions/repo/index.json";
+export const GITHUB_LATEST_RELEASE = "https://github.com/inorichi/tachiyomi/releases/latest";
+export const GITHUB_LATEST_API = "https://api.github.com/repos/inorichi/tachiyomi/releases/latest";
+export const KANADE_LATEST = "https://tachiyomi.kanade.eu/latest";
diff --git a/src/.vuepress/theme/components/Home.vue b/src/.vuepress/theme/components/Home.vue
index 7d73143e..ae6f1f8e 100644
--- a/src/.vuepress/theme/components/Home.vue
+++ b/src/.vuepress/theme/components/Home.vue
@@ -80,16 +80,9 @@
 
 <script>
 import axios from "axios";
-
 import CloudDownloadIcon from "vue-material-design-icons/CloudDownload.vue";
 import BookOpenVariantIcon from "vue-material-design-icons/BookOpenVariant.vue";
-
-const RELEASE_URL =
-	"https://api.github.com/repos/inorichi/tachiyomi/releases/latest";
-
-const LATEST_RELEASE = "https://github.com/inorichi/tachiyomi/releases/latest";
-
-const PREVIEW_URL = "https://tachiyomi.kanade.eu/latest";
+import { GITHUB_LATEST_API, GITHUB_LATEST_RELEASE, KANADE_LATEST } from "../../constants";
 
 export default {
 	name: "Home",
@@ -126,7 +119,7 @@ export default {
 	},
 
 	async mounted() {
-		const { data } = await axios.get(RELEASE_URL);
+		const { data } = await axios.get(GITHUB_LATEST_API);
 		const apkAsset = data.assets.find((a) => a.name.includes(".apk"));
 		this.$data.tagName = data.tag_name;
 		this.$data.browserDownloadUrl = apkAsset.browser_download_url;
@@ -194,7 +187,7 @@ export default {
 						},
 					});
 					window.location.assign(
-						this.$data.browserDownloadUrl || LATEST_RELEASE
+						this.$data.browserDownloadUrl || GITHUB_LATEST_RELEASE
 					);
 					window.ga(
 						"send",
@@ -263,7 +256,7 @@ export default {
 										"animate__animated animate__faster animate__zoomOut",
 								},
 							});
-							window.location.assign(PREVIEW_URL);
+							window.location.assign(KANADE_LATEST);
 							window.ga(
 								"send",
 								"event",