From 395ca3630c8cf3cd608f1b9093e3894518683516 Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Sat, 13 Jun 2020 16:25:26 -0400
Subject: [PATCH] Combine author and artist fields in manga info

---
 .../ui/manga/info/MangaInfoController.kt      | 29 ++----------
 .../res/layout-land/manga_info_controller.xml | 43 ++----------------
 .../main/res/layout/manga_info_controller.xml | 44 ++-----------------
 app/src/main/res/layout/source_list_item.xml  |  2 -
 app/src/main/res/values/strings.xml           |  2 -
 5 files changed, 12 insertions(+), 108 deletions(-)

diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt
index 5b49905b0d..620df130f0 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/manga/info/MangaInfoController.kt
@@ -137,21 +137,6 @@ class MangaInfoController(private val fromSource: Boolean = false) :
             }
             .launchIn(scope)
 
-        binding.mangaArtist.longClicks()
-            .onEach {
-                activity?.copyToClipboard(
-                    binding.mangaArtistLabel.text.toString(),
-                    binding.mangaArtist.text.toString()
-                )
-            }
-            .launchIn(scope)
-
-        binding.mangaArtist.clicks()
-            .onEach {
-                performGlobalSearch(binding.mangaArtist.text.toString())
-            }
-            .launchIn(scope)
-
         binding.mangaAuthor.longClicks()
             .onEach {
                 activity?.copyToClipboard(
@@ -231,18 +216,12 @@ class MangaInfoController(private val fromSource: Boolean = false) :
             manga.title
         }
 
-        // Update artist TextView.
-        binding.mangaArtist.text = if (manga.artist.isNullOrBlank()) {
+        // Update author/artist TextView.
+        val authors = listOf(manga.author, manga.artist).filter { !it.isNullOrBlank() }.distinct()
+        binding.mangaAuthor.text = if (authors.isEmpty()) {
             view.context.getString(R.string.unknown)
         } else {
-            manga.artist
-        }
-
-        // Update author TextView.
-        binding.mangaAuthor.text = if (manga.author.isNullOrBlank()) {
-            view.context.getString(R.string.unknown)
-        } else {
-            manga.author
+            authors.joinToString(", ")
         }
 
         // If manga source is known update source TextView.
diff --git a/app/src/main/res/layout-land/manga_info_controller.xml b/app/src/main/res/layout-land/manga_info_controller.xml
index 24c9761b23..934dd9c4b9 100644
--- a/app/src/main/res/layout-land/manga_info_controller.xml
+++ b/app/src/main/res/layout-land/manga_info_controller.xml
@@ -53,61 +53,26 @@
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="parent" />
 
-                <TextView
-                    android:id="@+id/manga_author_label"
-                    style="@style/TextAppearance.Medium.Body2"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/manga_info_author_label"
-                    android:textIsSelectable="false"
-                    app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/manga_full_title" />
-
                 <TextView
                     android:id="@+id/manga_author"
                     style="@style/TextAppearance.Regular.Body1.Secondary"
                     android:layout_width="0dp"
                     android:layout_height="wrap_content"
-                    android:layout_marginStart="8dp"
-                    android:ellipsize="end"
-                    android:maxLines="1"
-                    android:textIsSelectable="false"
-                    app:layout_constraintBaseline_toBaselineOf="@+id/manga_author_label"
-                    app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintStart_toEndOf="@+id/manga_author_label" />
-
-                <TextView
-                    android:id="@+id/manga_artist_label"
-                    style="@style/TextAppearance.Medium.Body2"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:text="@string/manga_info_artist_label"
                     android:textIsSelectable="false"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/manga_author_label" />
-
-                <TextView
-                    android:id="@+id/manga_artist"
-                    style="@style/TextAppearance.Regular.Body1.Secondary"
-                    android:layout_width="0dp"
-                    android:layout_height="wrap_content"
-                    android:layout_marginStart="8dp"
-                    android:ellipsize="end"
-                    android:maxLines="1"
-                    android:textIsSelectable="false"
-                    app:layout_constraintBaseline_toBaselineOf="@+id/manga_artist_label"
-                    app:layout_constraintEnd_toEndOf="parent"
-                    app:layout_constraintStart_toEndOf="@+id/manga_artist_label" />
+                    app:layout_constraintTop_toBottomOf="@+id/manga_full_title"
+                    tools:text="Author" />
 
                 <TextView
                     android:id="@+id/manga_chapters_label"
                     style="@style/TextAppearance.Medium.Body2"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
+                    android:layout_marginTop="8dp"
                     android:text="@string/manga_info_last_chapter_label"
                     android:textIsSelectable="false"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/manga_artist_label" />
+                    app:layout_constraintTop_toBottomOf="@+id/manga_author" />
 
                 <TextView
                     android:id="@+id/manga_chapters"
diff --git a/app/src/main/res/layout/manga_info_controller.xml b/app/src/main/res/layout/manga_info_controller.xml
index f5802c88c3..1f52c62b5a 100644
--- a/app/src/main/res/layout/manga_info_controller.xml
+++ b/app/src/main/res/layout/manga_info_controller.xml
@@ -70,7 +70,6 @@
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
                         android:maxLines="2"
-                        android:paddingBottom="8dp"
                         android:text="@string/manga_info_full_title_label"
                         android:textIsSelectable="false"
                         app:autoSizeMaxTextSize="20sp"
@@ -80,62 +79,27 @@
                         app:layout_constraintStart_toStartOf="parent"
                         app:layout_constraintTop_toTopOf="parent" />
 
-                    <TextView
-                        android:id="@+id/manga_author_label"
-                        style="@style/TextAppearance.Medium.Body2"
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:text="@string/manga_info_author_label"
-                        android:textIsSelectable="false"
-
-                        app:layout_constraintStart_toStartOf="parent"
-                        app:layout_constraintTop_toBottomOf="@+id/manga_full_title" />
-
                     <TextView
                         android:id="@+id/manga_author"
                         style="@style/TextAppearance.Regular.Body1.Secondary"
                         android:layout_width="0dp"
                         android:layout_height="wrap_content"
-                        android:layout_marginStart="8dp"
-                        android:ellipsize="end"
-                        android:maxLines="1"
                         android:textIsSelectable="false"
-                        app:layout_constraintBaseline_toBaselineOf="@+id/manga_author_label"
                         app:layout_constraintEnd_toEndOf="parent"
-                        app:layout_constraintStart_toEndOf="@+id/manga_author_label" />
-
-                    <TextView
-                        android:id="@+id/manga_artist_label"
-                        style="@style/TextAppearance.Medium.Body2"
-                        android:layout_width="wrap_content"
-                        android:layout_height="wrap_content"
-                        android:text="@string/manga_info_artist_label"
-                        android:textIsSelectable="false"
                         app:layout_constraintStart_toStartOf="parent"
-                        app:layout_constraintTop_toBottomOf="@+id/manga_author_label" />
-
-                    <TextView
-                        android:id="@+id/manga_artist"
-                        style="@style/TextAppearance.Regular.Body1.Secondary"
-                        android:layout_width="0dp"
-                        android:layout_height="wrap_content"
-                        android:layout_marginStart="8dp"
-                        android:ellipsize="end"
-                        android:maxLines="1"
-                        android:textIsSelectable="false"
-                        app:layout_constraintBaseline_toBaselineOf="@+id/manga_artist_label"
-                        app:layout_constraintEnd_toEndOf="parent"
-                        app:layout_constraintStart_toEndOf="@+id/manga_artist_label" />
+                        app:layout_constraintTop_toBottomOf="@+id/manga_full_title"
+                        tools:text="Author" />
 
                     <TextView
                         android:id="@+id/manga_chapters_label"
                         style="@style/TextAppearance.Medium.Body2"
                         android:layout_width="wrap_content"
                         android:layout_height="wrap_content"
+                        android:layout_marginTop="8dp"
                         android:text="@string/manga_info_last_chapter_label"
                         android:textIsSelectable="false"
                         app:layout_constraintStart_toStartOf="parent"
-                        app:layout_constraintTop_toBottomOf="@+id/manga_artist_label" />
+                        app:layout_constraintTop_toBottomOf="@+id/manga_author" />
 
                     <TextView
                         android:id="@+id/manga_chapters"
diff --git a/app/src/main/res/layout/source_list_item.xml b/app/src/main/res/layout/source_list_item.xml
index c1beaedf05..efff363a6c 100644
--- a/app/src/main/res/layout/source_list_item.xml
+++ b/app/src/main/res/layout/source_list_item.xml
@@ -26,9 +26,7 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginStart="8dp"
-        android:layout_marginTop="8dp"
         android:layout_marginEnd="8dp"
-        android:layout_marginBottom="8dp"
         android:ellipsize="end"
         android:maxLines="1"
         app:layout_constraintBottom_toBottomOf="parent"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 52091b0916..21ae2caf6f 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -459,8 +459,6 @@
     <string name="manga_info_full_title_label">Title</string>
     <string name="manga_added_library">Added to library</string>
     <string name="manga_removed_library">Removed from library</string>
-    <string name="manga_info_author_label">Author</string>
-    <string name="manga_info_artist_label">Artist</string>
     <string name="manga_info_chapters_label">Chapters</string>
     <string name="manga_info_last_chapter_label">Last chapter</string>
     <string name="manga_info_latest_data_label">Updated</string>