From 40ab3fe0a63cc16b7755a2e51a3505a3e09abc7d Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Sun, 31 May 2020 18:28:05 -0400
Subject: [PATCH] Tweak extension detail header design

---
 .../extension/ExtensionDetailsController.kt   |  2 ++
 .../layout/extension_detail_controller.xml    | 19 +++++++++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionDetailsController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionDetailsController.kt
index 85fe4397ab..d168b9e3ca 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionDetailsController.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/browse/extension/ExtensionDetailsController.kt
@@ -34,6 +34,7 @@ import eu.kanade.tachiyomi.extension.model.Extension
 import eu.kanade.tachiyomi.source.CatalogueSource
 import eu.kanade.tachiyomi.source.ConfigurableSource
 import eu.kanade.tachiyomi.source.Source
+import eu.kanade.tachiyomi.ui.base.controller.NoToolbarElevationController
 import eu.kanade.tachiyomi.ui.base.controller.NucleusController
 import eu.kanade.tachiyomi.util.preference.checkBoxPreference
 import eu.kanade.tachiyomi.util.preference.onChange
@@ -49,6 +50,7 @@ import uy.kohesive.injekt.injectLazy
 @SuppressLint("RestrictedApi")
 class ExtensionDetailsController(bundle: Bundle? = null) :
     NucleusController<ExtensionDetailControllerBinding, ExtensionDetailsPresenter>(bundle),
+    NoToolbarElevationController,
     PreferenceManager.OnDisplayPreferenceDialogListener,
     DialogPreference.TargetFragment {
 
diff --git a/app/src/main/res/layout/extension_detail_controller.xml b/app/src/main/res/layout/extension_detail_controller.xml
index 8b8b31d898..8ae510ecf0 100644
--- a/app/src/main/res/layout/extension_detail_controller.xml
+++ b/app/src/main/res/layout/extension_detail_controller.xml
@@ -20,11 +20,22 @@
         app:layout_constraintTop_toTopOf="parent"
         tools:visibility="visible" />
 
+    <FrameLayout
+        android:layout_width="0dp"
+        android:layout_height="0dp"
+        android:background="?attr/colorPrimary"
+        android:elevation="2dp"
+        app:layout_constraintBottom_toTopOf="@+id/extension_prefs_recycler"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintTop_toBottomOf="@+id/extension_warning_banner" />
+
     <ImageView
         android:id="@+id/extension_icon"
         android:layout_width="56dp"
         android:layout_height="56dp"
         android:layout_marginStart="16dp"
+        android:elevation="3dp"
         android:src="@mipmap/ic_launcher"
         app:layout_constraintBottom_toBottomOf="@id/extension_pkg"
         app:layout_constraintStart_toStartOf="parent"
@@ -36,7 +47,8 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginStart="16dp"
-        android:layout_marginTop="16dp"
+        android:layout_marginTop="8dp"
+        android:elevation="3dp"
         app:layout_constraintStart_toEndOf="@id/extension_icon"
         app:layout_constraintTop_toBottomOf="@id/extension_warning_banner"
         tools:text="Tachiyomi: Extension" />
@@ -47,6 +59,7 @@
         android:layout_height="wrap_content"
         android:layout_gravity="center"
         android:layout_weight="1"
+        android:elevation="3dp"
         android:gravity="center"
         app:layout_constraintStart_toStartOf="@id/extension_title"
         app:layout_constraintTop_toBottomOf="@id/extension_title"
@@ -58,6 +71,7 @@
         android:layout_height="wrap_content"
         android:layout_gravity="center"
         android:layout_weight="1"
+        android:elevation="3dp"
         android:gravity="center"
         app:layout_constraintStart_toStartOf="@id/extension_title"
         app:layout_constraintTop_toBottomOf="@id/extension_version"
@@ -68,6 +82,7 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginEnd="16dp"
+        android:elevation="3dp"
         android:ellipsize="middle"
         android:singleLine="true"
         app:layout_constraintEnd_toEndOf="parent"
@@ -92,7 +107,7 @@
         android:id="@+id/extension_prefs_recycler"
         android:layout_width="0dp"
         android:layout_height="0dp"
-        android:layout_marginTop="16dp"
+        android:layout_marginTop="8dp"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"