Simplify if/else

This commit is contained in:
inorichi 2015-10-13 00:15:03 +02:00
parent 0febdfb715
commit 82ac2b3223
2 changed files with 8 additions and 15 deletions

View File

@ -125,31 +125,23 @@ public class CatalogueListPresenter extends BasePresenter {
// If going to search mode // If going to search mode
else if (mSearchName.equals("") && !query.equals("")) { else if (mSearchName.equals("") && !query.equals("")) {
mSearchMode = true; mSearchMode = true;
mSearchName = query;
adapter.setItems(new ArrayList<>());
getMangasFromSearch(1);
} }
// If going to normal mode // If going to normal mode
else if (!mSearchName.equals("") && query.equals("")) { else if (!mSearchName.equals("") && query.equals("")) {
mSearchMode = false; mSearchMode = false;
mSearchName = query;
adapter.setItems(new ArrayList<>());
getMangasFromSource(1);
} }
// If query changes
else {
mSearchName = query; mSearchName = query;
adapter.setItems(new ArrayList<>()); adapter.getItems().clear();
getMangasFromSearch(1); loadMoreMangas(1);
}
view.setScrollListener(); view.setScrollListener();
} }
public void loadMoreMangas(int page) { public void loadMoreMangas(int page) {
if (!mSearchMode) { if (mSearchMode) {
getMangasFromSource(page);
} else {
getMangasFromSearch(page); getMangasFromSearch(page);
} else {
getMangasFromSource(page);
} }
} }

View File

@ -40,6 +40,7 @@ public abstract class Source {
.flatMap(response -> Observable.just(parsePopularMangasFromHtml(response))); .flatMap(response -> Observable.just(parsePopularMangasFromHtml(response)));
} }
// Get mangas from the source with a query
public Observable<List<Manga>> searchMangasFromNetwork(String query, int page) { public Observable<List<Manga>> searchMangasFromNetwork(String query, int page) {
return mNetworkService return mNetworkService
.getStringResponse(getSearchUrl(query, page), mNetworkService.NULL_CACHE_CONTROL, mRequestHeaders) .getStringResponse(getSearchUrl(query, page), mNetworkService.NULL_CACHE_CONTROL, mRequestHeaders)