From afc80d6a7c5e0e8cdeff713616e126d9313afa7c Mon Sep 17 00:00:00 2001
From: arkon <eugcheung94@gmail.com>
Date: Fri, 17 Dec 2021 14:14:48 -0500
Subject: [PATCH] Adjust global update preference wording and visibility

---
 .../tachiyomi/ui/setting/SettingsLibraryController.kt       | 6 ------
 app/src/main/res/menu/library.xml                           | 2 +-
 app/src/main/res/values/strings.xml                         | 6 +++---
 3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
index 53cf27505f..3b02647d85 100644
--- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
+++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsLibraryController.kt
@@ -202,8 +202,6 @@ class SettingsLibraryController : SettingsController() {
                 entryValues = arrayOf(MANGA_FULLY_READ, MANGA_ONGOING)
                 defaultValue = preferences.libraryUpdateMangaRestriction().defaultValue
 
-                visibleIfGlobalUpdateEnabled()
-
                 fun updateSummary() {
                     val restrictions = preferences.libraryUpdateMangaRestriction().get()
                         .sorted()
@@ -231,8 +229,6 @@ class SettingsLibraryController : SettingsController() {
                 key = Keys.libraryUpdateCategories
                 titleRes = R.string.categories
 
-                visibleIfGlobalUpdateEnabled()
-
                 onClick {
                     LibraryGlobalUpdateCategoriesDialog().showDialog(router)
                 }
@@ -275,7 +271,6 @@ class SettingsLibraryController : SettingsController() {
                 titleRes = R.string.pref_library_update_refresh_metadata
                 summaryRes = R.string.pref_library_update_refresh_metadata_summary
                 defaultValue = false
-                visibleIfGlobalUpdateEnabled()
             }
             if (trackManager.hasLoggedServices()) {
                 switchPreference {
@@ -283,7 +278,6 @@ class SettingsLibraryController : SettingsController() {
                     titleRes = R.string.pref_library_update_refresh_trackers
                     summaryRes = R.string.pref_library_update_refresh_trackers_summary
                     defaultValue = false
-                    visibleIfGlobalUpdateEnabled()
                 }
             }
         }
diff --git a/app/src/main/res/menu/library.xml b/app/src/main/res/menu/library.xml
index d57d0a345d..0fe7ba3b2a 100644
--- a/app/src/main/res/menu/library.xml
+++ b/app/src/main/res/menu/library.xml
@@ -21,7 +21,7 @@
     <item
         android:id="@+id/action_update_library"
         android:icon="@drawable/ic_refresh_24dp"
-        android:title="@string/action_update_library"
+        android:title="@string/pref_category_library_update"
         app:iconTint="?attr/colorOnSurface"
         app:showAsAction="ifRoom" />
 
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 8ed8c94d33..61806d17aa 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -207,15 +207,15 @@
     <string name="pref_jump_to_chapters">Jump to chapters on open</string>
 
     <string name="pref_category_library_update">Global update</string>
-    <string name="pref_library_update_interval">Update frequency</string>
-    <string name="update_never">Manual</string>
+    <string name="pref_library_update_interval">Automatic updates</string>
+    <string name="update_never">Off</string>
     <string name="update_6hour">Every 6 hours</string>
     <string name="update_12hour">Every 12 hours</string>
     <string name="update_24hour">Daily</string>
     <string name="update_48hour">Every 2 days</string>
     <string name="update_72hour">Every 3 days</string>
     <string name="update_weekly">Weekly</string>
-    <string name="pref_library_update_restriction">Device restrictions</string>
+    <string name="pref_library_update_restriction">Automatic updates device restrictions</string>
     <string name="connected_to_wifi">Only on Wi-Fi</string>
     <string name="charging">Charging</string>
     <string name="restrictions">Restrictions: %s</string>