From bed978a26a6cdb578e60621c72360f6163340159 Mon Sep 17 00:00:00 2001 From: MCAxiaz Date: Thu, 16 Jan 2020 18:44:22 -0800 Subject: [PATCH] force menu invalidation when expanding actionView from user interaction to properly layout menu items (#2503) --- .../ui/base/controller/BaseController.kt | 22 ++++++- .../browse/BrowseCatalogueController.kt | 59 ++++++++++--------- .../ui/extension/ExtensionController.kt | 3 +- .../tachiyomi/ui/library/LibraryController.kt | 5 +- 4 files changed, 57 insertions(+), 32 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt index 860c4d5908..941e39a01b 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt @@ -85,10 +85,11 @@ abstract class BaseController(bundle: Bundle? = null) : RestoreViewOnCreateContr } /** - * Workaround for disappearing menu items when collapsing an expandable item like a SearchView. + * Workaround for buggy menu item layout after expanding/collapsing an expandable item like a SearchView. * This method should be removed when fixed upstream. * Issue link: https://issuetracker.google.com/issues/37657375 */ + var expandActionViewFromInteraction = false fun MenuItem.fixExpand(onExpand: ((MenuItem) -> Boolean)? = null, onCollapse: ((MenuItem) -> Boolean)? = null) { setOnActionExpandListener(object : MenuItem.OnActionExpandListener { override fun onMenuItemActionExpand(item: MenuItem): Boolean { @@ -101,6 +102,25 @@ abstract class BaseController(bundle: Bundle? = null) : RestoreViewOnCreateContr return onCollapse?.invoke(item) ?: true } }) + + if (expandActionViewFromInteraction) { + expandActionViewFromInteraction = false + expandActionView() + } + } + + /** + * Workaround for menu items not disappearing when expanding an expandable item like a SearchView. + * [expandActionViewFromInteraction] should be set to true in [onOptionsItemSelected] when the expandable item is selected + * This method should be called as part of [MenuItem.OnActionExpandListener.onMenuItemActionExpand] + */ + fun invalidateMenuOnExpand(): Boolean { + return if (expandActionViewFromInteraction) { + activity?.invalidateOptionsMenu() + false + } else { + true + } } } diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/catalogue/browse/BrowseCatalogueController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/catalogue/browse/BrowseCatalogueController.kt index f73bb09380..1391a2321f 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/catalogue/browse/BrowseCatalogueController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/catalogue/browse/BrowseCatalogueController.kt @@ -215,37 +215,39 @@ open class BrowseCatalogueController(bundle: Bundle) : inflater.inflate(R.menu.catalogue_list, menu) // Initialize search menu - menu.findItem(R.id.action_search).apply { - val searchView = actionView as SearchView + val searchItem = menu.findItem(R.id.action_search) + val searchView = searchItem.actionView as SearchView - val query = presenter.query - if (!query.isBlank()) { - expandActionView() - searchView.setQuery(query, true) - searchView.clearFocus() - } - - val searchEventsObservable = searchView.queryTextChangeEvents() - .skip(1) - .filter { router.backstack.lastOrNull()?.controller() == this@BrowseCatalogueController } - .share() - val writingObservable = searchEventsObservable - .filter { !it.isSubmitted } - .debounce(1250, TimeUnit.MILLISECONDS, AndroidSchedulers.mainThread()) - val submitObservable = searchEventsObservable - .filter { it.isSubmitted } - - searchViewSubscription?.unsubscribe() - searchViewSubscription = Observable.merge(writingObservable, submitObservable) - .map { it.queryText().toString() } - .subscribeUntilDestroy { searchWithQuery(it) } - - fixExpand(onCollapse = { - searchWithQuery("") - true - }) + val query = presenter.query + if (!query.isBlank()) { + searchItem.expandActionView() + searchView.setQuery(query, true) + searchView.clearFocus() } + val searchEventsObservable = searchView.queryTextChangeEvents() + .skip(1) + .filter { router.backstack.lastOrNull()?.controller() == this@BrowseCatalogueController } + .share() + val writingObservable = searchEventsObservable + .filter { !it.isSubmitted } + .debounce(1250, TimeUnit.MILLISECONDS, AndroidSchedulers.mainThread()) + val submitObservable = searchEventsObservable + .filter { it.isSubmitted } + + searchViewSubscription?.unsubscribe() + searchViewSubscription = Observable.merge(writingObservable, submitObservable) + .map { it.queryText().toString() } + .subscribeUntilDestroy { searchWithQuery(it) } + + searchItem.fixExpand( + onExpand = { invalidateMenuOnExpand() }, + onCollapse = { + searchWithQuery("") + true + } + ) + // Setup filters button menu.findItem(R.id.action_set_filter).apply { icon.mutate() @@ -278,6 +280,7 @@ open class BrowseCatalogueController(bundle: Bundle) : override fun onOptionsItemSelected(item: MenuItem): Boolean { when (item.itemId) { + R.id.action_search -> expandActionViewFromInteraction = true R.id.action_display_mode -> swapDisplayMode() R.id.action_set_filter -> navView?.let { activity?.drawer?.openDrawer(GravityCompat.END) } R.id.action_open_in_browser -> openInBrowser() diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionController.kt index ff83e48efa..142b5485a0 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/extension/ExtensionController.kt @@ -80,6 +80,7 @@ open class ExtensionController : NucleusController(), override fun onOptionsItemSelected(item: MenuItem): Boolean { when (item.itemId) { + R.id.action_search -> expandActionViewFromInteraction = true R.id.action_settings -> { router.pushController((RouterTransaction.with(ExtensionFilterController())) .popChangeHandler(SettingsExtensionsFadeChangeHandler()) @@ -137,7 +138,7 @@ open class ExtensionController : NucleusController(), } // Fixes problem with the overflow icon showing up in lieu of search - searchItem.fixExpand() + searchItem.fixExpand(onExpand = { invalidateMenuOnExpand() }) } override fun onItemClick(view: View, position: Int): Boolean { diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt index e3e8edc274..9030a2fac7 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/library/LibraryController.kt @@ -321,7 +321,7 @@ class LibraryController( val searchItem = menu.findItem(R.id.action_search) val searchView = searchItem.actionView as SearchView - if (!query.isEmpty()) { + if (query.isNotEmpty()) { searchItem.expandActionView() searchView.setQuery(query, true) searchView.clearFocus() @@ -339,7 +339,7 @@ class LibraryController( searchRelay.call(query) } - searchItem.fixExpand() + searchItem.fixExpand(onExpand = { invalidateMenuOnExpand() }) } override fun onPrepareOptionsMenu(menu: Menu) { @@ -354,6 +354,7 @@ class LibraryController( override fun onOptionsItemSelected(item: MenuItem): Boolean { when (item.itemId) { + R.id.action_search -> expandActionViewFromInteraction = true R.id.action_filter -> { navView?.let { activity?.drawer?.openDrawer(GravityCompat.END) } }