From c0e48632290af95f138dcc33e79b3136ae0f29a9 Mon Sep 17 00:00:00 2001 From: arkon Date: Fri, 27 Nov 2020 21:36:42 -0500 Subject: [PATCH] Fix restore in Android 11 --- .../ui/setting/SettingsBackupController.kt | 88 ++++++++++--------- app/src/main/res/values/strings.xml | 1 + 2 files changed, 48 insertions(+), 41 deletions(-) diff --git a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsBackupController.kt b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsBackupController.kt index f167edfced..3fcd1b819b 100644 --- a/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsBackupController.kt +++ b/app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsBackupController.kt @@ -11,6 +11,7 @@ import android.os.Bundle import android.view.View import androidx.core.net.toUri import androidx.core.os.bundleOf +import androidx.documentfile.provider.DocumentFile import androidx.preference.PreferenceScreen import com.afollestad.materialdialogs.MaterialDialog import com.afollestad.materialdialogs.list.listItemsMultiChoice @@ -81,7 +82,18 @@ class SettingsBackupController : SettingsController() { titleRes = R.string.pref_restore_backup summaryRes = R.string.pref_restore_backup_summ - onClick { restore(context) } + onClick { + if (!BackupRestoreService.isRunning(context)) { + val intent = Intent(Intent.ACTION_GET_CONTENT) + intent.addCategory(Intent.CATEGORY_OPENABLE) + intent.type = "application/*" + val title = resources?.getString(R.string.file_select_backup) + val chooser = Intent.createChooser(intent, title) + startActivityForResult(chooser, CODE_BACKUP_RESTORE) + } else { + context.toast(R.string.restore_in_progress) + } + } } } preferenceCategory { @@ -193,33 +205,40 @@ class SettingsBackupController : SettingsController() { ) } CODE_BACKUP_RESTORE -> { - if (uri?.path != null) { - if (uri.path!!.endsWith(".proto.gz")) { - val options = arrayOf( - R.string.full_restore_offline, - R.string.full_restore_online - ) - .map { activity.getString(it) } - MaterialDialog(activity) - .title(R.string.full_restore_mode) - .listItemsSingleChoice( - items = options, - initialSelection = 0 - ) { _, index, _ -> - RestoreBackupDialog( - uri, - BackupConst.BACKUP_TYPE_FULL, - isOnline = index != 0 - ).showDialog(router) - } - .positiveButton(R.string.action_restore) - .show() - } else if (uri.path!!.endsWith(".json")) { - RestoreBackupDialog( - uri, - BackupConst.BACKUP_TYPE_LEGACY, - isOnline = true - ).showDialog(router) + uri?.path?.let { path -> + val fileName = DocumentFile.fromSingleUri(activity, uri)!!.name!! + when { + fileName.endsWith(".proto.gz") -> { + val options = arrayOf( + R.string.full_restore_offline, + R.string.full_restore_online + ) + .map { activity.getString(it) } + MaterialDialog(activity) + .title(R.string.full_restore_mode) + .listItemsSingleChoice( + items = options, + initialSelection = 0 + ) { _, index, _ -> + RestoreBackupDialog( + uri, + BackupConst.BACKUP_TYPE_FULL, + isOnline = index != 0 + ).showDialog(router) + } + .positiveButton(R.string.action_restore) + .show() + } + fileName.endsWith(".json") -> { + RestoreBackupDialog( + uri, + BackupConst.BACKUP_TYPE_LEGACY, + isOnline = true + ).showDialog(router) + } + else -> { + activity.toast(activity.getString(R.string.invalid_backup_file_type, fileName)) + } } } } @@ -237,19 +256,6 @@ class SettingsBackupController : SettingsController() { } } - private fun restore(context: Context) { - if (!BackupRestoreService.isRunning(context)) { - val intent = Intent(Intent.ACTION_GET_CONTENT) - intent.addCategory(Intent.CATEGORY_OPENABLE) - intent.type = "application/*" - val title = resources?.getString(R.string.file_select_backup) - val chooser = Intent.createChooser(intent, title) - startActivityForResult(chooser, CODE_BACKUP_RESTORE) - } else { - context.toast(R.string.restore_in_progress) - } - } - fun createBackup(flags: Int, type: Int) { backupFlags = flags val currentDir = preferences.backupsDirectory().get() diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 7c1ddfad27..77262d76c1 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -365,6 +365,7 @@ Not logged in: %1$s Backup created Invalid backup file + Invalid backup file: %1$s File is missing data. Backup does not contain any manga. Missing sources: