Fix extension update badge reset when app resumed (#6822)

This commit is contained in:
Ivan Iskandar 2022-03-25 22:11:16 +07:00 committed by GitHub
parent 5c0a43e8d6
commit ef600c0956
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 5 deletions

View File

@ -34,7 +34,7 @@ class ExtensionUpdateJob(private val context: Context, workerParams: WorkerParam
return@coroutineScope Result.failure() return@coroutineScope Result.failure()
} }
if (pendingUpdates.isNotEmpty()) { if (!pendingUpdates.isNullOrEmpty()) {
createUpdateNotification(pendingUpdates.map { it.name }) createUpdateNotification(pendingUpdates.map { it.name })
} }

View File

@ -39,10 +39,10 @@ internal class ExtensionGithubApi {
} }
} }
suspend fun checkForUpdates(context: Context): List<Extension.Installed> { suspend fun checkForUpdates(context: Context): List<Extension.Installed>? {
// Limit checks to once a day at most // Limit checks to once a day at most
if (Date().time < preferences.lastExtCheck().get() + TimeUnit.DAYS.toMillis(1)) { if (Date().time < preferences.lastExtCheck().get() + TimeUnit.DAYS.toMillis(1)) {
return emptyList() return null
} }
val extensions = findExtensions() val extensions = findExtensions()

View File

@ -361,8 +361,9 @@ class MainActivity : BaseViewBindingActivity<MainActivityBinding>() {
// Extension updates // Extension updates
try { try {
val pendingUpdates = ExtensionGithubApi().checkForUpdates(this@MainActivity) ExtensionGithubApi().checkForUpdates(this@MainActivity)?.let { pendingUpdates ->
preferences.extensionUpdatesCount().set(pendingUpdates.size) preferences.extensionUpdatesCount().set(pendingUpdates.size)
}
} catch (e: Exception) { } catch (e: Exception) {
logcat(LogPriority.ERROR, e) logcat(LogPriority.ERROR, e)
} }