Controllers now properly remove their toolbar items on pop

app/src/main/java/eu/kanade/tachiyomi/ui/base/controller/BaseController.kt

@@ -61,6 +61,7 @@ abstract class BaseController(bundle: Bundle? = null) : RestoreViewOnCreateContr
         if (type.isEnter) {
             setTitle()
         }
+        setHasOptionsMenu(type.isEnter)
         super.onChangeStarted(handler, type)
     }
 

app/src/main/java/eu/kanade/tachiyomi/ui/manga/MangaDetailsController.kt

@@ -468,7 +468,6 @@ class MangaDetailsController : BaseController,
             if (router.backstack.lastOrNull()?.controller() is DialogController)
                 return
             if (type == ControllerChangeType.POP_EXIT) {
-                setHasOptionsMenu(false)
                 setActionBar(false)
                 presenter.cancelScope()
             }

app/src/main/java/eu/kanade/tachiyomi/ui/setting/SettingsController.kt

@@ -79,6 +79,7 @@ abstract class SettingsController : PreferenceController() {
         if (type.isEnter) {
             setTitle()
         }
+        setHasOptionsMenu(type.isEnter)
         super.onChangeStarted(handler, type)
     }