Commit Graph

756 Commits

Author SHA1 Message Date
arkon
7fdbf40cd2 Minor cleanups
Pulling out some of the smaller changes that aren't related to the manga controller changes in #7244
2022-06-04 16:01:49 -04:00
AntsyLich
809da49301
Reader: Save reading progress with SQLDelight (#7185)
* Use SQLDelight in reader to update history

* Move chapter progress to sqldelight

* Review Changes

Co-Authored-By: inorichi <len@kanade.eu>

* Review Changes 2

Co-authored-by: FourTOne5 <59261191+FourTOne5@users.noreply.github.com>
Co-authored-by: inorichi <len@kanade.eu>
2022-05-28 09:09:27 -04:00
FourTOne5
ad17eb1386
Local Source - qol, cleanup and cover related fixes (#7166)
* Local Source - qol, cleanup and cover related fixes

* Review Changes
2022-05-24 18:02:02 -04:00
CVIUS
6580f5771f
Fix reader menu appearing then disappearing in webtoon viewer when there is no next chapter (#7115) 2022-05-17 17:20:37 -04:00
CVIUS
b21bcc2d45
Fix webtoon viewer showing transition view when going to next/prev chapter using next/prev button (#7133) 2022-05-17 17:20:18 -04:00
arkon
9f42306f79 Minor cleanup 2022-05-15 17:03:57 -04:00
CVIUS
4c9331c4e9
Settings cleanup (#7126)
* Settings cleanup

* Oops

* Also hide "Invert tap zones" if tap zones is set to "Disabled" in ReaderReadingModeSettings
2022-05-15 09:37:52 -04:00
CVIUS
f1ab34e27c
Save reader progress when activity is paused (#7121) 2022-05-14 08:51:04 -04:00
nzoba
63627c81eb
Add switch to DownloadPageLoader when chapter is downloaded (#7119) 2022-05-13 21:42:23 -04:00
arkon
b950370f12 Address some build warnings 2022-05-11 18:08:49 -04:00
arkon
39c0b74250 Fix tall image split math issues
- Round up per-split height to ensure the entire page ends up being split
- Handle the last split of a page potentially being shorter than the others
2022-05-06 23:10:56 -04:00
arkon
a9e629aea6 Minor cleanup
- Remove some unused StorIO queries
- Clean up tall image splitting a bit (no need for creating an unscaled scaled bitmap copy, or tracking coordinates)
- Clean up library updater a bit (still needs a lot of work though)
2022-05-06 22:48:00 -04:00
ItsLogic
5e32b8e49f
Fix chapter transition setting for one page chapters (#6998) 2022-04-24 15:21:21 -04:00
arkon
2b79295240 Revert "Revert history Compose/SQLDelight changes"
This reverts commit 96c894ce5b.
2022-04-22 17:35:18 -04:00
arkon
96c894ce5b Revert history Compose/SQLDelight changes 2022-04-22 17:27:58 -04:00
Andreas
c475acd1ea
Migrate History screen to Compose (#6922)
* Migrate History screen to Compose

- Migrate screen
- Strip logic from presenter into use cases and repository
- Setup for other screen being able to migrate to Compose with Theme

* Changes from review comments
2022-04-17 10:36:22 -04:00
arkon
c1976ef599 Avoid some crashes 2022-04-14 18:28:16 -04:00
arkon
4ecde9fc39 Gate update/download warnings to non-stable flavors 2022-04-10 12:17:45 -04:00
arkon
5afff31f72 Formatting 2022-04-08 16:44:23 -04:00
arkon
2dfafa387b Remove reader tapping option in favor of disabled nav layouts 2022-04-08 16:44:13 -04:00
manatails
175b77fe6f
Add option to disable navigation layout (#6876) 2022-04-08 16:32:25 -04:00
arkon
346652e508 Ensure media store scan is triggered after saving an image (fixes #6808) 2022-04-08 15:55:12 -04:00
arkon
f0eb42e72d Update linter 2022-04-08 15:30:39 -04:00
Ivan Iskandar
dbad60d03b
Base activities cleanup (#6848)
* secure delegate

* theming delegate
2022-04-02 09:54:21 -04:00
Andreas
f8eb9f94f4
Fix filename not having chapter title and page when sharing (#6827) 2022-03-26 12:40:29 -04:00
Andreas
1163aa4e4e
Share logic for saving page/cover (#6787)
* Use MediaStore on newer Android Q or newer

* Use flow instead of Observable

* Review comment fixes

* Use suspended function instead of flow
2022-03-19 16:46:23 -04:00
Sahaab
87ae86e1be Added reverse portrait reader rotation 2022-03-12 16:50:48 -05:00
Ivan Iskandar
fae43fedfa
ReaderActivity: Reduce anim duration when launched from resume FAB (#6762)
From enter 500ms exit 400ms
To both 350ms
2022-03-10 07:51:42 -05:00
Ivan Iskandar
10eef282fa
Coil 2.x upgrade (#6725)
* Migrate to Coil 2

* Adapt to use coil disk cache

* Update to alpha 7

* Update to alpha 8

* Update to rc01
2022-03-04 16:04:32 -05:00
Gauthier
2f07f226b8
Fix "Landscape zoom" and "Navigate to pan" for split images (#6647)
* fix: getPageHolder would always return the first split, as they share the same index

* split pages have the same number, we need an extra check to know whether we move forward or back
2022-02-17 22:09:03 -05:00
arkon
790d7b9170 Rename extension function to avoid confusion with androidx function 2022-02-12 11:23:10 -05:00
Gauthier
d8719ceee9
Navigate to pan / landscape zoom (#6481)
* pan if the image is zoomed instead of navigating away
quickly display full landscape image before zooming to fit height in fit to screen

* add Tap to pan preference, defaults to true
add landscape zoom preference, defaults to false

* hide landscape image zoom option if scale is not fit screen

* fix landscape image zoom for first image and loading image

* properly reload pagerholders when landscape zoom option is changed

* enable landscape zoom by default
2022-02-12 11:21:54 -05:00
arkon
aa5e428222 Filter archive files as sequence 2022-02-05 17:27:28 -05:00
Ivan Iskandar
7108993936
Unify reader error layout (#6512)
So nobody will think that the error layout is broken when they see different
layout.
2022-02-02 21:41:20 -05:00
Ivan Iskandar
b6553bdc34
ReaderActivity: Fix transition crash on Android 8 (#6542) 2022-02-02 21:40:48 -05:00
arkon
408c7b2ca6 Avoid unnecessary transition setup in reader if not transitioning 2022-02-01 10:31:44 -05:00
arkon
75a2110626 Update preference dependencies 2022-01-31 18:13:57 -05:00
arkon
edd213343b Remove some dead code 2022-01-18 17:54:17 -05:00
arkon
8a8f1d3205 Update crop border shortcut state when reading mode or manga set (fixes #6441) 2022-01-09 10:53:06 -05:00
arkon
544387d1a0 Avoid reader crash 2022-01-08 15:06:44 -05:00
Ivan Iskandar
b8f7653fb2
Use material components on reader error views (#6447)
* Use material components on reader error views

* Adjust image loading behavior

Don't set automatic background color right away and keep show progress indicator
until the page image is fully loaded.
2022-01-08 12:53:20 -05:00
jmir1
2e1572d7cc
fix crash in ReaderActivity (#6439) 2022-01-04 21:29:14 -05:00
arkon
0b9d436753 Fix some crashes 2022-01-02 11:25:35 -05:00
Seishirou101
5336c5b46e Add compress to CBZ on download (#6360) 2022-01-01 14:46:43 -05:00
arkon
78c2631b6f Move preference extension functions to utils 2021-12-31 16:32:24 -05:00
arkon
f3718257f5 Reduce redundancy in some preference declarations
The remaining ones could also be converted to FlowPreferences for this, but it's not really necessary.
2021-12-26 12:44:38 -05:00
Ivan Iskandar
6b52fc1e2d
Use elevated overlay on reader menu (#6347) 2021-12-16 22:57:31 -05:00
arkon
7f998ecdbd Revert download notification icon changes 2021-12-12 11:14:47 -05:00
arkon
ed4dea8686 Update notification icons
Although no recent version of Android even shows these....
2021-12-11 12:59:05 -05:00
Ivan Iskandar
bdef2cfdfb
Replace Resume FAB reveal animation with container transform (#6250) 2021-11-19 10:16:39 -05:00
Riztard Lanthorn
33a02b47d5
Hide cutout toggle button if fullscreen is off (#6150) 2021-10-30 12:19:15 -04:00
Andreas
8f00d34b0b
Change zoom from 3x to 5x (#6164)
Because some people actually read images with really small text

*I hope they have some extreme high quality pictures else I don't know how they read the raster images*
2021-10-27 23:33:36 -04:00
arkon
cb9c5a35cb Minor cleanup 2021-10-13 09:13:38 -04:00
arkon
a56997e98c Hide slider tooltip label everywhere 2021-10-09 10:44:08 -04:00
Ivan Iskandar
2e127dff1f
Replace Timber with Square Logcat and make logging configurable (#6062)
* Replace Timber with Square Logcat

* Configurable logger
2021-10-07 22:12:55 -04:00
arkon
675c0cefc3 Fix crash in single-page chapters 2021-10-04 11:06:23 -04:00
arkon
dc92ffed87 Switch to Material Slider in color filter settings 2021-10-03 11:58:52 -04:00
arkon
d149017c60 Switch to Material Slider for reader seekbar
Co-authored-by: Jays2Kings <Jays2Kings@users.noreply.github.com>
2021-10-03 11:14:49 -04:00
Ivan Iskandar
746d35b52b
Reuse reader's image view in MangaFullCoverDialog (#5824)
* MangaFullCoverDialog: Support animated drawable

* Scaled zoom duration

* Wrap reader's image view to be reused in MangaFullCoverDialog

* Cleanups

* Forgot animated stuff for webtoon view

* Cleanups

* Oopsie

* Cleanups

* Consistent max scale for SubsamplingScaleImageView

The max scale will be obtained from the default scale times 3 for
consistent 3x zoom scale.
2021-09-11 18:28:54 -04:00
tobinstultiens
a051079c6a
Allow exclusion on Delete After Read per category (#5857)
* Added the exclude category from delete after being read

* Stopped it from adding a wildcard to the import

* Placed the remove after read to the download manager
2021-09-11 18:09:24 -04:00
arkon
ec4e631760 Clean up some companion object usages 2021-09-05 14:34:29 -04:00
arkon
5ae4621da1 Queue tracking updates when offline (closes #1497)
Co-authored-by: Jays2Kings <Jays2Kings@users.noreply.github.com>
2021-09-04 16:37:35 -04:00
arkon
2f91c27df2 Don't allow focus on reader containers (closes #5727) 2021-09-04 15:23:00 -04:00
Ivan Iskandar
bd033db84c
Fix animated image detection (#5826) 2021-08-31 17:43:29 -04:00
arkon
1b699bb814 Fix reader action sheet not opening 2021-08-28 17:24:42 -04:00
arkon
333c035fed Clean up reader action sheet layout 2021-08-28 17:22:41 -04:00
Gauthier
2cd8733212
change Track.last_chapter_read to Float (#5802)
each TrackService can convert it to Int if decimal chapters are not supported
2021-08-28 10:37:45 -04:00
arkon
4b2a9bc621 Clean up imports 2021-08-27 16:45:59 -04:00
Taco
12a9d0575d
Use more Compat utilities (#5786)
* Use ActivityCompat.recreate

* Use more KTX extensions

* Use PackageInfoCompat.getLongVersionCode

* Remove unnecessary compat usages
2021-08-27 16:33:12 -04:00
Hunter Nickel
df683375b1
Apply system animation scale to parts of Tachiyomi that don't respect it by default (#5794)
* Add initial code for scaling animations, apply scale to reader nav overlay

* Rename extension function, apply system animator scale to ActionToolbar

* Apply system animator scale to expanding manga cover animation

* Apply system animator scale to image crossfade (also disables animated covers when browsing)

* Add documentation, make MotionScene Transition comment a bit more clear

* Disable animated covers in MangaInfoHeaderAdapter if animator duration scale is 0

* Disable animated covers in Library if animator duration scale is 0

* Convert loadAny listener to extension function
2021-08-27 08:44:09 -04:00
Ivan Iskandar
b3854ad382
Fix reader crash on Android 9 (#5789)
* Fix failed reader context creation on v28

* Re-apply the reader styles manually after overriding night mode

This commit replaces the ThemeCompat.rebase() call since the private API used is
in dark greylist max target P, thus making it unreachable.

* Revert "Fix failed reader context creation on v28"

This reverts commit 6e2104d7
2021-08-25 17:27:34 -04:00
Ivan Iskandar
887b157056
Add haptic feedback to reader page slider (#5763) 2021-08-21 18:05:57 -04:00
Ivan Iskandar
4eaccc966e
Hide reader progress indicator right away (#5750)
The image will be drawn over it so the animation won't be visible anyway
2021-08-19 18:12:31 -04:00
Andreas
3670d649b8
Make default category translatable (#5751)
* Make default category translatable

* Replace duplicate strings with common one
2021-08-19 18:10:43 -04:00
Ivan Iskandar
26b8df5354
Partial revert 914b686c8e (#5749)
Didn't mean to remove this line, this fixes resuming to read downloaded chapter.
2021-08-19 11:53:26 -04:00
Ivan Iskandar
11a8046c5f
PagerPageHolder: Move chooseBackground call to IO thread (#5737)
* ImageUtil.chooseBackground: Use built-in decoder

* PagerPageHolder: Move chooseBackground call to IO thread

Also move stuffs and reuse image stream as bytes
2021-08-19 09:15:45 -04:00
Ivan Iskandar
914b686c8e
ReaderTransitionView: Use context theme color for texts (#5738)
* Put themed reader context in adapter

This avoids creating themed context everytime the page holder is created, this
also allows the transition view to use the same themed context.

* Check against app night mode to create themed reader context

* ReaderTransitionView: Use context theme color for texts

The whole reader will need to be recreated when changing reader background while
webtoon mode is used, because recreating just the RecyclerView without messing
up the scroll position is impossible (I hope I just missed something).
2021-08-19 09:10:05 -04:00
Hunter Nickel
4c8dfd0c0c
Add toggle to invert page color in reader color filter settings (#5713) 2021-08-15 10:58:01 -04:00
Hunter Nickel
d1bb0fdf1d
Apply app theme styling to reader page errors and progress dialog (#5705) 2021-08-13 15:44:42 -04:00
Ivan Iskandar
5e77ae208d
Use correct color for reader loading indicator (#5685)
* Revert "Revert "Use correct color for reader loading indicator (#5645)" (fixes #5669)"

This reverts commit a4eba50c

* Fix crash on older APIs
2021-08-09 17:48:28 -04:00
arkon
1d10d29fa9 Replace AboutLibraries activity with custom controller 2021-08-07 11:50:20 -04:00
Andreas
7907a4fc24
Add ability to tweak auto hide sensitivity in Webtoon Reader (#5650)
* Tweak threshold

* Put setting under Webtoon instead

Because it only affects Webtoon related viewers
2021-08-07 10:34:47 -04:00
arkon
a4eba50cfd Revert "Use correct color for reader loading indicator (#5645)" (fixes #5669)
This reverts commit 7a1b6142df.
2021-08-06 17:30:51 -04:00
Ivan Iskandar
7a1b6142df
Use correct color for reader loading indicator (#5645)
Night theme color will be used when black or gray background color is used.
2021-08-06 14:22:04 -04:00
Ivan Iskandar
40aa3b7e18
Fix wonky webtoon layout when image is loaded at the top of the screen (#5660) 2021-08-05 17:51:03 -04:00
Ivan Iskandar
5aea21a194
Remove reader page number inset margin (#5661) 2021-08-05 17:50:37 -04:00
Andreas
7660751f7f
Don't hide menu when scrolling through with ReaderSeekBar (#5611) 2021-07-31 12:04:13 -04:00
Ivan Iskandar
39b7024be0
Fix webtoon page takes up entire screen even if it's smaller (#5622) 2021-07-29 09:16:01 -04:00
Ivan Iskandar
cc55453076
ReaderProgressIndicator: Set indeterminate as default state (#5605)
Will also set to indeterminate if progress is 0.
2021-07-27 17:30:35 -04:00
Ivan Iskandar
c42d517f6b
Apply default night mode earlier (#5593) 2021-07-24 11:14:25 -04:00
Andreas
356cd4ef52
Auto hide reader menu when user starts reading again (#5578)
* Hide reader menu when user starts reading again

* Hide menu on zoom and scrolling around during zoom

Didn't work for webtoon

* Only listen when menu is visible
2021-07-21 17:58:32 -04:00
Ivan Iskandar
6ba779fb7a
Reader loading progress indicator changes (#5587)
* Use CircularProgressIndicator on PageHolder

Manually rotate the CircularProgressIndicator inside a wrapper view instead of
drawing our own custom indicator.

* Use CircularProgressIndicator on TransitionHolder
2021-07-20 17:38:19 -04:00
Andreas
c0647c3110
Make default tracking status depend if the user has read chapter or not (#5567)
- When user reads a chapter change tracking status to reading
2021-07-17 11:26:29 -04:00
Ivan Iskandar
b7c2890250
Don't show navigation overlay if tap navigation is disabled (#5534)
* Don't show navigation overlay if tap navigation is disabled

* Apply feedback
2021-07-15 08:44:53 -04:00
Ivan Iskandar
ae97bb0445
Replace material-dialogs usage with Material Components' (#5423)
* Use Material Components' dialogs

For all dialogs that has direct replacement.

* Convert text input dialogs

* Convert quad-state multi choices dialogs

* Convert date picker dialogs

This also changes the flow to remove selected start/finish tracking date and
the track item itself

* Remove material-dialogs dependencies
2021-07-14 18:04:03 -04:00
Hunter Nickel
7fd75b7501
Hide the reader seekbar for single-page chapters (#5551) 2021-07-14 17:56:50 -04:00
SBence
fb35d7af59
Sanitize manga title in page download subfolder name (#5514) 2021-07-07 21:58:53 -04:00
Andreas
c254aa6fcc
Make Automatic Reader Theme pick background/text color based on dark mode preference (#5505)
* Make Automatic Reader Theme pick background/text color based on theme

* Use extension method
2021-07-07 18:12:11 -04:00
Ivan Iskandar
0eadc028b6
Merge light and dark themes (#5470)
* Merge AMOLED and regular dark themes

This allows all variants of dark themes to use black backgrounds as a
separate preference.

* Merge light and dark themes

* Fix ReaderSeekBar color on Dark Blue theme

* Color fixes

* Fix Dark Blue bars ripple

* Simplify night mode check
2021-07-02 08:44:04 -04:00
Ivan Iskandar
82f3677168
Fix reader toolbar alpha applied to other components outside its activity (#5483) 2021-07-01 18:11:44 -04:00
Ivan Iskandar
e2cf157857
Reader fixes after #5450 (#5465)
* Fix ReaderActivity system bars behavior

* Fix ReaderActivity transition view text color

* Don't change reader navbar color when windowLightNavigationBar is not available
2021-06-27 11:39:26 -04:00
Ivan Iskandar
64c95305b9
Match ReaderActivity theme with the rest of the app (#5450)
* Match ReaderActivity theme with the rest of the app

* Fix viewer inset when fullscreen reader is off

* Fix incorrect toolbar color after recreate

* Remove animated inset

* Move isDarkMode to PreferencesHelper
2021-06-25 23:28:19 -04:00
arkon
8d25ce7323 Surface exceptions when fetching pages properly (fixes #5377) 2021-06-12 10:49:30 -04:00
arkon
71d225c562 Address some build warnings 2021-06-05 17:49:20 -04:00
Hunter Nickel
fdf178d4df
Add behavior for modifying reader buttons depending on prev/next chapters (#5305) 2021-06-05 10:37:21 -04:00
arkon
edeee54fb2 Set orientation icon correctly when opening reader 2021-06-05 10:25:54 -04:00
arkon
281a3911f6 Add share and save cover actions (closes #3011) 2021-06-02 22:51:10 -04:00
arkon
1feac9c559 Show toast when toggling crop borders
Consistent with reading mode and orientation shortcuts.
2021-05-30 10:54:24 -04:00
Ivan Iskandar
9f744bc445
More bottom sheet improvements (#5183)
* Edge-to-edge bottom sheet when possible

* ReaderSettingsSheet: Animate background dim changes

* Adjust modal bottom sheet in-out animation

* Use public method to get bottom sheet behavior

* Set bottom sheet peek size to 50% screen height

The current auto peek height gives too low value on landscape orientation

* Set bottom sheet navigation bar scrim when needed
2021-05-28 22:36:09 -04:00
inorichi
8c18a14dfd Display animated webp whenever possible, otherwise fallback to static image. Fixes #5139 2021-05-25 19:42:48 +02:00
arkon
70d9b0c390 Organize some classes 2021-05-24 12:34:54 -04:00
arkon
065cf42aea Fix reader chapter sort ordering (fixes #5157) 2021-05-23 14:30:09 -04:00
arkon
aefd2bf6f8 Use same chapter sorting logic in manga and reader views 2021-05-23 11:28:04 -04:00
arkon
ce9fb2f1fe Update reader chapter list filtering to handle not downloaded/bookmarked (closes #5107) 2021-05-23 11:27:52 -04:00
arkon
2a7ed1375a Fallback to default viewer properly (closes #5068) 2021-05-22 17:41:53 -04:00
arkon
2f7f00c7a2 Try to avoid crashing when source fails to return pages 2021-05-22 11:41:10 -04:00
arkon
940c5b3838 Refactor BaseBottomSheetDialog to set maxWidth with newer API 2021-05-19 22:20:45 -04:00
arkon
09c07faafd Avoid invalid reading mode/orientation selections
Related to #5068
2021-05-15 15:29:21 -04:00
arkon
47c120e58c Fix rotation shortcut tooltip 2021-05-08 09:14:01 -04:00
Andreas
122cdae5bc
Automatic background color for PagerViewer (#4996)
* Add J2K implementation of automatic background

Co-authored-by: Jays2Kings <8617760+Jays2Kings@users.noreply.github.com>

* Tweak the monstrosity called automatic background

* Add ability to choose Automatic as a background

* More tweaks

Co-authored-by: Jays2Kings <8617760+Jays2Kings@users.noreply.github.com>
2021-05-04 22:46:42 -04:00
Ivan Iskandar
cb203ef02c
Show notification to disable Incognito Mode when it's enabled (#4976)
* Show notification to disable Incognito Mode when it's enabled

* Finish ReaderActivity and BrowseSourceController when incognito is disabled

* CLeanup strings

* Only register DisableIncognitoReceiver when needed
2021-04-30 22:36:54 -04:00
arkon
908c9bc624 Reader grayscale filter (closes #2822) 2021-04-30 22:35:49 -04:00
Andreas
fe373a95a2
Fix bugs in dual-page split (#4983)
If more bugs appear probably better to go back to the main thread and process dual-pages every time a page is shown as it did before
2021-04-30 09:14:20 -04:00
Andreas
0fef546a0d
Add manga-wised rotation mode settings (#4841)
* Add manga-wised rotation mode settings

Based on #3522

Co-authored-by: bboyz269 <4453811+bboyz269@users.noreply.github.com>

* Fix small mistakes

* Complete TODOs

* Rename functions

rotation -> orientation

* Fix orientation icon not changing

Bug from video

* Fix bug with force portrait not being force if a default value

Bug from video

* Backup viewer_flag as a seperate field in so legacy/forks doesn't crash

* Make viewer_flags nullable so old backups viewer gets restored

* Add migration for old rotation and viewer to new defaults ones

* Rename variable in enums

* Fix migration after OrientationType was changed

* Remove untrue comment

Co-authored-by: bboyz269 <4453811+bboyz269@users.noreply.github.com>
2021-04-28 08:32:47 -04:00
Ivan Iskandar
93e6136795
Use Coil (#4870)
* Use Coil

* Remove coil-transformations lib

* Add MangaCoverFetcher

* Remove Glide

* MangaCoverFetcher: Allow skipping custom cover usage

* Adjust coil caching policy for some non-library items

* Allow coil to use RGB565 only on low ram devices

* Fix image loading progress view not showing

a

* Increase coil crossfade duration

Same as default glide duration

* Add back request clearing
2021-04-28 08:32:00 -04:00
arkon
71c9df5279 Lint fixes 2021-04-27 17:46:34 -04:00
OncePunchedMan
9278407b85
Setting: Creates folders according to manga title (#4861)
* cherry-picking my changes

* Update SettingsDownloadController.kt

* Update SettingsDownloadController.kt

* Update ReaderPresenter.kt

Co-authored-by: arkon <arkon@users.noreply.github.com>
2021-04-27 17:38:56 -04:00
Andreas
662b71436e
Cleanup dual page split (#4956)
* Cleanup Dual Page Split

* Move where images is processed

* Change parameter name to imageStream

* Use available instead of Int.MAX_VALUE

* Update JavaDoc
2021-04-25 11:08:51 -04:00
arkon
6ba82da029 Don't automatically go to HALF_EXPANDED state for color filter tab (closes #4913) 2021-04-25 10:59:53 -04:00
arkon
5f9574541f Use popup menus for reader shortcuts instead of toggling through 2021-04-24 19:17:52 -04:00
arkon
e8d8621f06 Remove "Locked" orientation, replace with explicit orientations
Portrait/Landscape allow sensor, Locked Portrait/Landscape don't.
2021-04-23 22:37:43 -04:00
arkon
356b7c346a Clean up ChapterCache (remove Gson, Rx usage) 2021-04-18 11:30:16 -04:00
arkon
9065362fde Move reading mode toast to default bottom position
Toasts don't block user interaction, so it's probably fine.
2021-04-17 18:52:52 -04:00
arkon
54a23ddd1f Long press reader settings icon to open color filter tab
Partially addresses #4867
2021-04-16 23:06:24 -04:00
arkon
3287ca9cf2 Add checkmark beside selected popup menu item
Based on what's in J2K. Also renamed to MaterialSpinnerView to match what's there.

Co-authored-by: Jays2Kings <Jays2Kings@users.noreply.github.com>
2021-04-16 22:39:19 -04:00
arkon
b4577d6676 Avoid crash when unknown reading mode is used 2021-04-14 18:03:48 -04:00
Jays2Kings
5f0493f1e5 Fix webtoon mode not calling OnPageSelected in some cases (in upstream too)
This fix isn't 100% tested, but like 80%.

@arkon if you're reading this, this issue is happening up stream too. I can make a issue for it in the repo but haven't checked if it happens there:

Steps:
Get Cubari source, search "cubari:imgur/3iOqiIy" change to continuous vertical, crop borders. Then back out and open the chapter again. onPageSelected isn't called because recycler position is -1. Regardless of the 4 pages you should be on

also fyi just a slight scroll fixes this issue but still

(cherry picked from commit 88fd6e5c98)
2021-04-14 08:49:48 -04:00
arkon
a3f1b72126 Lint fixes/ignore some errors 2021-04-11 18:16:15 -04:00
arkon
9567d55312 Revert manga title folder for saved pages (closes #4803)
People also didn't like it making their galleries more complicate to navigate.
2021-04-10 14:33:14 -04:00
Taco
b3471234ad
Update NDK, more KTX usage (#4792)
* Update NDK

* Utilize more KTX extensions
2021-04-08 17:56:01 -04:00
arkon
dac2072eaa Use app name for page download folder and use manga title subfolders (closes #4684) 2021-04-03 10:40:35 -04:00
arkon
a3992d9fbe Minor cleanup 2021-04-03 10:12:31 -04:00
Tooster
efd2a0cb7b
Replace reading mode snackbar with toast (#4752) 2021-04-03 10:07:49 -04:00
arkon
7aa379a857 Better handle webtoon SSIV crop border change 2021-03-31 22:20:17 -04:00
arkon
1657f04d55 Add tooltips for previous/next chapter buttons
Based on d0738f5b00
2021-03-30 23:11:36 -04:00
arkon
407e798fdb Recreate webtoon SSIV when crop borders setting changes (fixes #4734) 2021-03-30 18:47:44 -04:00
arkon
4054f2a6a0 Add icon for crop border shortcut off state 2021-03-30 18:27:09 -04:00
arkon
988ec6a224 Fix nav overlay always showing on start (fixes #4736) 2021-03-29 16:54:32 -04:00
Andreas
bdbdf211e2
Remove insert page when dual page split get turned off (#4739) 2021-03-29 16:54:20 -04:00
arkon
0437703cbf Fix binding of intarray preferences (maybe fixes #4728) 2021-03-28 17:06:56 -04:00
arkon
d501c02f8b Add crop borders shortcut 2021-03-28 16:25:53 -04:00
arkon
dfa07a5f35 Clean up SpinnerPreference a bit 2021-03-28 16:13:59 -04:00
arkon
437c995d12 Show nav overlay on invert tap change
Based on db4eca90e9
2021-03-28 16:13:34 -04:00
arkon
3d99a8ebdb Fix fullscreen not applying on opening reader (fixes #4723) 2021-03-28 10:48:41 -04:00
arkon
c4b975b777 Cleanup reader spinner layouts 2021-03-27 17:59:52 -04:00
arkon
14c114756d Clean up reader sheet spinner preferences
Based on fe2543b9d5

Co-Authored-By: Jays2Kings
2021-03-27 16:28:49 -04:00
arkon
e7a8107279 Reduce height of sheet when on color filter tab 2021-03-27 15:15:31 -04:00
arkon
bff73b1b40 Add tooltips to bottom reader menu items 2021-03-27 10:53:31 -04:00
arkon
64c47bbaed Split general and reading mode sheet settings 2021-03-26 22:31:21 -04:00
arkon
e0b7698d40 Merge reader settings and color filter sheets
Heavily influenced by fe2543b9d5 (diff-8f47d7b7b53769ac18c28fe9978140c6bef44709879567acab2c6ef3270cd3a8)
2021-03-25 23:10:22 -04:00
arkon
78285bdf37 Minor code cleanup 2021-03-20 15:58:54 -04:00
Andreas
5a7f2684b3
Add navigation layout overlay (#4683)
* Add navigation layout overlay

* Minor clean up 

Destroy animator when done not on start
Move and change pref title 
Add summary
2021-03-20 15:36:01 -04:00
arkon
609d8c9685 Add icons for reading mode toggle 2021-03-14 17:13:20 -04:00
arkon
2f08515455 Less janky enum iteration 2021-03-14 17:03:43 -04:00
arkon
cdc5de3f1b Flip order of previous chapter reader transition text (closes #4608) 2021-03-14 16:18:52 -04:00
arkon
1e58b05ead Add reading mode toggle 2021-03-13 16:47:16 -05:00
arkon
938919bd9b Move reader setting related classes 2021-03-13 16:24:44 -05:00
arkon
fde6b7af4f Disable sensor when using force orientation (closes #4618) 2021-03-13 15:47:43 -05:00
Andreas
7a64bf55cb
Dual page split allow to have different setting for Paged and Webtoon (#4527) 2021-02-28 16:17:37 -05:00
Andreas
776610d0e6
Let users invert dual page split (#4470)
* Let users invert dual page split

* Use Activity lifecycleScope and cleanup invert logic
2021-02-20 09:26:57 -05:00
arkon
33992d80bf Add orientation toggle to bottom reader menu 2021-02-13 18:50:50 -05:00
arkon
89837e4ced Initial adoption of bottom reader menus from TachiyomiSY
Co-authored-by: Jobobby04 <jobobby04@users.noreply.github.com>
Co-authored-by: CrepeTF <CrepeTF@users.noreply.github.com>
2021-02-13 10:47:17 -05:00
arkon
8bb69c455b Allow clicking the toolbar to go to the manga
Co-authored-by: Jobobby04 <jobobby04@users.noreply.github.com>
2021-02-13 10:26:59 -05:00
vance
b5017eebbf
Added dual page split setting (#4252)
* Add DualPageSplit option

* remove extra line

* Split double-page into two pages

* Remove !isAnimated check and add (ALPHA) to the label

* Fix missing insert pages

* Pager cleanup

* Add dual split to Webtoon and fix Vertical

* Fix L2R/R2L

* Add comments and refactor code in ImageUtil

* Use a simpler split solution in webtoon mode

Co-authored-by: weng <>
Co-authored-by: Andreas E <andreas.everos@gmail.com>
2021-02-09 17:54:44 -05:00
arkon
291168f4de Remove unnecessary LayoutContainer implementations 2021-02-08 17:45:42 -05:00
Andreas
b63d24ac1a
Add Right and Left navigation (#4392)
and remove default navigation classes in favor of the navigation classes
2021-02-06 23:26:56 -05:00
arkon
1607658c30 Set clip data when sharing content URIs (closes #4198) 2021-02-06 09:43:33 -05:00
arkon
7eef4f7fbf Apply bottom sheet dialog with restriction consistently 2021-01-28 09:10:15 -05:00
arkon
0ecfef3f70 Address unit test compilation errors
They don't actually run since they broke a long time ago (AndroidX + Roboelectric issues?), but it addresses the annoying red squigglies in Android Studio at least.
2021-01-26 09:05:15 -05:00
Taco
5f7e34b6a1
Update Okio, use more KTX stuff (#4353)
* Update Okio to 2.10.0

* Use some more KTX extensions
2021-01-26 09:02:53 -05:00
arkon
cf7ec6aa76 Use proper method to clear notification actions 2021-01-21 18:21:21 -05:00
arkon
f667f85fa5 More consistent injectLazy style 2021-01-17 15:40:26 -05:00
arkon
c9cf9cfff0 More coroutine tweaks 2021-01-10 11:01:10 -05:00
arkon
b18a794eca Use lifecycleScope directly 2021-01-07 19:12:30 -05:00
Andreas E
9db81a5a49
Fix navigation from feedback (#4238)
* Fix navigation from feedback (fixes #4237)

* Add additional enum values to NavigationRegion mainly for PagerViewer

Co-authored-by: arkon <arkon@users.noreply.github.com>
2021-01-07 19:05:38 -05:00
arkon
6fb7a85e8a Address more coroutine scope leaks 2021-01-07 18:15:57 -05:00
arkon
135cf9960f Minor cleanup 2021-01-03 10:54:09 -05:00
Andreas E
3bf7c74f93
Navigation settings and split invert tapping for webtoon and pager (#4233) 2021-01-03 10:50:38 -05:00
Andreas E
d69e9034ab
Viewer navigation (#3869)
* Viewer navigation

Co-authored-by: Harsh Parekh <h.x.dev@outlook.com>

* Match current reader behavior and add ability to invert it

* A bit of clean up

* Clean up inversion

* Only create navigator when changed

and change tap zone when invertTapping is changed

* Clean up PagerConfig

* Change how Viewer navigation works

* Add Edge Navigation

Co-authored-by: Harsh Parekh <h.x.dev@outlook.com>
2021-01-01 18:41:20 -05:00
arkon
141f9b7730 Handle last read page being above total page count (fixes #4010) 2020-12-31 11:21:39 -05:00
arkon
3df98d576e Fix crash on updating trackers after reading with no network (closes #4207) 2020-12-29 09:21:18 -05:00
arkon
ea33179a95 Convert tracker add/update/login methods to coroutines 2020-12-24 17:50:28 -05:00
arkon
00fe4cdf2d Minor code cleanup 2020-12-13 18:11:18 -05:00
arkon
4880741b8b More crash fixes 2020-12-13 17:18:28 -05:00
arkon
836aec4396 Flip left/right key events for Webtoon viewer (fixes #4111) 2020-12-12 15:50:56 -05:00
arkon
59859e124f Update to Kotlin 1.4.21 and kotlinter 3.3.0 2020-12-08 22:31:48 -05:00
Taco
c2b8fea291
Update libraries, some lints (#4099)
* Update some plugins

* Fix some miscellaneous lints
2020-12-08 22:21:08 -05:00
arkon
560f0bba5c Use more up-to-date fork of junrar 2020-12-07 22:13:53 -05:00
Andreas E
c9c0f3d014
Enhance incognito mode (#4073)
* When in Incognito Mode don't set lastUsedSource

* When in Incognito Mode don't save chapter progress

Still allows tracking and mark as read when reaching last page

* When in Incognito Mode don't mark as read (overwritten if hasTrackers)
2020-11-29 11:15:15 -05:00
arkon
322d66d282 Replace more usages of Kotlin synthetic views 2020-11-28 14:56:57 -05:00
arkon
781971ee81 Set preview/experimental compiler flags instead of using annotations 2020-11-22 11:43:16 -05:00
Dominik Chrástecký
c9b1a425a7
add support for S Pen actions (#4029) 2020-11-20 22:25:24 -05:00
Andreas E
f1350bc33e
Fix missing chapter warning when chapter number is not recognized (#3928)
* Fix missing chapter warning when chapter number is not recognized

* Add case where ch number is recognized as zero but has no ch number

Yes this will ignore ch 0

* Use RegEx to double check if ch. name contains potential ch. number
2020-10-24 13:06:23 -04:00
Andreas E
11ab3b2c2e
Remove from queue after read (#3870)
* Add option to remove chapter from download queue after marked as read

* Begone bug

There was a bug when one queued a new download to the downloader. Which resulted in getChapterDownloadOrNull() would not find the corresponding download for the provided chapter

* Fix review comment

* Remove preference and just remove from queue
2020-10-03 12:29:51 -04:00
arkon
cf39ae0000 Add banner for Incognito Mode 2020-10-03 10:53:26 -04:00
Platiplus
79ccfcd553
[Feature Request] Option to turn off History - #3772 (#3855)
* Implementing do not save chapter history preference

* Refactor of labels

* Changing incognito mode from Readers section to More

* Fixing imports and removing unused strings
2020-10-03 10:43:01 -04:00
arkon
01ad405dd2 Center reader transition text properly (fixes #3819) 2020-09-20 12:56:04 -04:00
Jay
004e1c98ee Send manga/chapter/page details when sharing a chapter page 2020-09-15 17:59:47 -04:00
arkon
76f6fe4601 Use Kolinter Gradle plugin for linting instead of ktlint directly 2020-09-13 18:48:20 -04:00
arkon
af47103707 Replace deprecated system window insets usage 2020-09-12 15:39:51 -04:00
Andreas E
9f260c3513
Always show missing chapter warning if there are missing chapters (#3755)
* Always show missing chapter warning if there are missing chapters

* Change function parameter names
2020-09-07 16:40:05 -04:00
arkon
b55d394a1f Fix text alignment in transition view when no more chapters available 2020-09-05 10:31:49 -04:00
arkon
86e59977de Refactor common chapter transition views into separate view 2020-09-04 16:25:08 -04:00
Andreas E
7a33e198dc
Add missing chapter warning (#3745)
* Add missing chapter warning

* Flip calculation instead of flipping variables

* Change logic

* Change tint based on reader theme

* Add missing chapter warning to WebtoonTransitionHolder

* Add chapter warning between current/finished and prev/next

* Fix mix up of TextViews

* Fix review comments
2020-09-03 22:21:19 -04:00
arkon
4ef25c75b7 Use core-ktx for bolding chapter transition text 2020-08-18 17:40:17 -04:00
arkon
64bdfabbd8
Revert ktlint update, unrevert Gradle and PR build workflow reverts (#3681) 2020-08-15 16:44:46 -04:00
arkon
4a136ef2aa Automatic linting fixes 2020-08-13 09:02:15 -04:00
arkon
ecec1bd102 Revert "Use insetter library for handling inset padding" (fixes #3586)
This reverts commit 3ddd1033c3.
2020-08-03 16:55:41 -04:00
arkon
493c8b0943 Adjust vertical reading mode tap zones (closes #3551)
Basically L shapes, where top/left goes back, bottom/right goes forward, and middle opens the menu.
2020-08-03 12:17:49 -04:00
arkon
3ddd1033c3 Use insetter library for handling inset padding 2020-08-02 23:09:18 -04:00
arkon
2ef277bcef Don't show completed notification if download error notification was shown 2020-08-02 10:53:17 -04:00
arkon
85ed7a7457 Fix for reader crash in < Android 9 2020-08-01 12:10:28 -04:00
arkon
6a5af438dd Temporarily unrevert crop borders unification (closes #3487)
Reverts 1920568057
2020-07-31 14:59:34 -04:00
arkon
ec56c27071 More core-ktx usages 2020-07-31 10:29:32 -04:00
arkon
b9488645d4 Hide cutout option when appropriate in reader settings sheet (closes #2982) 2020-07-30 22:38:10 -04:00
arkon
9e51d82154 Replace custom visibility extension functions 2020-07-25 12:00:27 -04:00
arkon
dc43e41896 Use view binding for sheets 2020-07-12 17:04:12 -04:00
arkon
66ef1a8206 Hide toolbars when reader color filter sheet is opened 2020-07-11 19:21:41 -04:00
arkon
beaffc3870 Remove redundant layout for reader color filter sheet 2020-07-11 19:16:49 -04:00
arkon
8536ecb611 Remove color filter preview image 2020-07-11 19:09:13 -04:00
arkon
d7a89b0f8c Remove 32-bit color setting from reader sheet 2020-07-11 18:58:04 -04:00
arkon
b363b9fc1a Make page transitions setting apply to webtoon viewer as well 2020-07-10 22:24:55 -04:00
arkon
1920568057 Unify crop borders settings 2020-07-10 22:19:08 -04:00
arkon
04d83e9a6a
Add option to reverse tapping (#3360)
* Add option to reverse tapping

* Fix string for preference key

* Invert tapping for Webtoon and Vertical

* Use enum instead of boolean

* Add option to reader sheet

* Hide from reader sheet if tapping disabled and remove hard coded string

* Hide option if tapping disabled
2020-06-25 18:12:12 -04:00
Andreas E
1681437206
Hide from reader sheet if tapping disabled and remove hard coded string 2020-06-24 15:48:08 +02:00
Andreas E
2eaf083eee
Add option to reader sheet 2020-06-24 09:50:23 +02:00
arkon
406c5bde11 Open error log on tapping notification body (closes #3376) 2020-06-23 22:17:19 -04:00
Carlos
75d1913aaf
ignore fact that loader might be null (#3374) 2020-06-23 18:11:47 -04:00
Andreas E
c8a6a2653f
Use enum instead of boolean 2020-06-23 12:09:10 +02:00
Andreas E
0ea0eba4f0
Invert tapping for Webtoon and Vertical 2020-06-23 10:58:56 +02:00
Andreas E
7f88b56d8b
Resolve merge conflicts 2020-06-23 10:23:14 +02:00
arkon
789421c7a0 Scroll up/down when tapping top/bottom thirds in vertical reading modes (closes #3363) 2020-06-22 22:36:33 -04:00
Andreas E
c54b8e62d7
Add option to reverse tapping 2020-06-21 16:47:18 +02:00
arkon
e17605f8d9 Localize/reword "Loader not implemented" error message 2020-06-17 09:09:01 -04:00
Dimitri Rogava
f642f23366
chapter deletion logic fixed (#3320) 2020-06-15 23:03:56 -04:00
arkon
3899938b25 Reading mode snackbar 2020-06-07 11:14:19 -04:00
arkon
2194c4ba28 Localize "Page list is empty" exception message 2020-05-31 11:26:36 -04:00
arkon
e3ed12b5d2 Set reader menu visibility on system UI visibility change (closes #3149 and #2068) 2020-05-30 19:07:31 -04:00
arkon
f05b99ec1f Convert source display mode preference to flow, remove RxPreferences 2020-05-25 12:35:29 -04:00
arkon
b457cdb0c2 Scroll up/down when tapping top/bottom quarters of webtoon viewer
Includes a fix from J2K: 4e45a337da
2020-05-20 22:23:45 -04:00