From 9bc72e82b2af59f3e148d0d7571716b57604456a Mon Sep 17 00:00:00 2001 From: michaelg Date: Sat, 1 Apr 2023 15:45:02 +0100 Subject: [PATCH 1/2] update: removed unused variable --- .../feature_update_service/FeatureUpdateController.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java b/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java index 1613bee3c..505808038 100644 --- a/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java +++ b/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java @@ -130,7 +130,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac } ThriftIndexingEvent event = featureUpdate.getEvent(); - return writeToKafka(event, requestStartTimeMillis) + return writeToKafka(event) .map(responsesList -> { stats.clientResponse(requestClientId, FeatureUpdateResponseCode.SUCCESS); // only when both Realtime & RealtimeCG succeed, then it will return a success flag @@ -162,8 +162,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac * The FeatureUpdateResponse is more like an ACK message, and the upstream (feature update ingester) * will not be affected much even if it failed (as long as the kafka message is written) */ - private Future> writeToKafka(ThriftIndexingEvent event, - long requestStartTimeMillis) { + private Future> writeToKafka(ThriftIndexingEvent event) { return Futures.collect(Lists.newArrayList( writeToKafkaInternal(event, WRITE_TO_KAFKA_DECIDER_KEY, droppedKafkaUpdateEvents, kafkaUpdateEventsTopicName, -1, kafkaProducer), From 6c8a2cd9ad679382a3c35f930482aae3e8f73c27 Mon Sep 17 00:00:00 2001 From: michaelg Date: Sat, 1 Apr 2023 15:48:59 +0100 Subject: [PATCH 2/2] update: removed unused variable --- .../search/feature_update_service/FeatureUpdateController.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java b/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java index 505808038..25424fe7e 100644 --- a/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java +++ b/src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java @@ -106,8 +106,6 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac @Override public Future process(FeatureUpdateRequest featureUpdate) { - long requestStartTimeMillis = clock.nowMillis(); - // Export overall and per-client request rate stats final String requestClientId; if (featureUpdate.getRequestClientId() != null