Mirrors
/
the-algorithm
mirror of https://github.com/twitter/the-algorithm.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 6c8a2cd9ad into 72eda9a24f

This commit is contained in:
maik101010 2023-07-17 21:40:12 -05:00 committed by GitHub
parent 72eda9a24f 6c8a2cd9ad
commit 6de1858532
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java
View File

@ -106,8 +106,6 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac
@Override
public Future<FeatureUpdateResponse> process(FeatureUpdateRequest featureUpdate) {
long requestStartTimeMillis = clock.nowMillis();
// Export overall and per-client request rate stats
final String requestClientId;
if (featureUpdate.getRequestClientId() != null
@ -130,7 +128,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac
}
ThriftIndexingEvent event = featureUpdate.getEvent();
return writeToKafka(event, requestStartTimeMillis)
return writeToKafka(event)
.map(responsesList -> {
stats.clientResponse(requestClientId, FeatureUpdateResponseCode.SUCCESS);
// only when both Realtime & RealtimeCG succeed, then it will return a success flag
@ -162,8 +160,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac
* The FeatureUpdateResponse is more like an ACK message, and the upstream (feature update ingester)
* will not be affected much even if it failed (as long as the kafka message is written)
*/
private Future<List<BoxedUnit>> writeToKafka(ThriftIndexingEvent event,
long requestStartTimeMillis) {
private Future<List<BoxedUnit>> writeToKafka(ThriftIndexingEvent event) {
return Futures.collect(Lists.newArrayList(
writeToKafkaInternal(event, WRITE_TO_KAFKA_DECIDER_KEY, droppedKafkaUpdateEvents,
kafkaUpdateEventsTopicName, -1, kafkaProducer),