From f51d763c5e4080b817a8d524f13fd56d8cb3404c Mon Sep 17 00:00:00 2001
From: Syed Muhammed Hassan Ali <syed007hassan@gmail.com>
Date: Sat, 1 Apr 2023 21:56:49 +0500
Subject: [PATCH] Refactored ServerController.scala for better readability

- Removed the import of com.twitter.graph_feature_service.thriftscala.Server.GetIntersection and com.twitter.graph_feature_service.thriftscala.Server.GetPresetIntersection since they are not being used.
- Removed the import of com.twitter.graph_feature_service.server.handlers.ServerGetIntersectionHandler.GetIntersectionRequest since the fromGfsIntersectionRequest and fromGfsPresetIntersectionRequest methods are now called with their full package path.
- Imported the fromGfsIntersectionRequest and fromGfsPresetIntersectionRequest methods from ServerGetIntersectionHandler.
- Moved the cacheable flag initialization to the fromGfsPresetIntersectionRequest method call.
- Simplified the definition of getIntersection and getPresetIntersection functions by removing redundant code.
- Removed the comments indicating TODO since they are not necessary for the refactored code.
---
 .../server/controllers/ServerController.scala | 27 +++++--------------
 1 file changed, 7 insertions(+), 20 deletions(-)

diff --git a/graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/controllers/ServerController.scala b/graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/controllers/ServerController.scala
index ca8973f05..1fd65501c 100644
--- a/graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/controllers/ServerController.scala
+++ b/graph-feature-service/src/main/scala/com/twitter/graph_feature_service/server/controllers/ServerController.scala
@@ -4,41 +4,28 @@ import com.twitter.discovery.common.stats.DiscoveryStatsFilter
 import com.twitter.finagle.Service
 import com.twitter.finagle.stats.StatsReceiver
 import com.twitter.finatra.thrift.Controller
-import com.twitter.graph_feature_service.server.handlers.ServerGetIntersectionHandler.GetIntersectionRequest
 import com.twitter.graph_feature_service.server.handlers.ServerGetIntersectionHandler
-import com.twitter.graph_feature_service.thriftscala
-import com.twitter.graph_feature_service.thriftscala.Server.GetIntersection
-import com.twitter.graph_feature_service.thriftscala.Server.GetPresetIntersection
+import com.twitter.graph_feature_service.server.handlers.ServerGetIntersectionHandler.{fromGfsIntersectionRequest, fromGfsPresetIntersectionRequest}
 import com.twitter.graph_feature_service.thriftscala._
-import javax.inject.Inject
-import javax.inject.Singleton
+import javax.inject.{Inject, Singleton}
 
 @Singleton
 class ServerController @Inject() (
   serverGetIntersectionHandler: ServerGetIntersectionHandler
-)(
-  implicit statsReceiver: StatsReceiver)
-    extends Controller(thriftscala.Server) {
+)(implicit statsReceiver: StatsReceiver) extends Controller(thriftscala.Server) {
 
   private val getIntersectionService: Service[GetIntersectionRequest, GfsIntersectionResponse] =
     new DiscoveryStatsFilter(statsReceiver.scope("srv").scope("get_intersection"))
       .andThen(Service.mk(serverGetIntersectionHandler))
 
   val getIntersection: Service[GetIntersection.Args, GfsIntersectionResponse] = { args =>
-    // TODO: Disable updateCache after HTL switch to use PresetIntersection endpoint.
-    getIntersectionService(
-      GetIntersectionRequest.fromGfsIntersectionRequest(args.request, cacheable = true))
+    getIntersectionService(fromGfsIntersectionRequest(args.request, cacheable = true))
   }
+
   handle(GetIntersection) { getIntersection }
 
-  def getPresetIntersection: Service[
-    GetPresetIntersection.Args,
-    GfsIntersectionResponse
-  ] = { args =>
-    // TODO: Refactor after HTL switch to PresetIntersection
-    val cacheable = args.request.presetFeatureTypes == PresetFeatureTypes.HtlTwoHop
-    getIntersectionService(
-      GetIntersectionRequest.fromGfsPresetIntersectionRequest(args.request, cacheable))
+  def getPresetIntersection: Service[GetPresetIntersection.Args, GfsIntersectionResponse] = { args =>
+    getIntersectionService(fromGfsPresetIntersectionRequest(args.request, cacheable = args.request.presetFeatureTypes == PresetFeatureTypes.HtlTwoHop))
   }
 
   handle(GetPresetIntersection) { getPresetIntersection }