Compare commits

...

2 Commits

Author SHA1 Message Date
Daira Hopwood
5561ff5fbd
Merge a7fd896bef into fb54d8b549 2023-05-22 17:38:07 -05:00
Daira Emma Hopwood
a7fd896bef Disable the "out of network" scoring penalty.
Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
2023-04-02 02:49:43 +01:00

View File

@ -22,7 +22,7 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] {
override val features: Set[Feature[_, _]] = Set(ScoreFeature) override val features: Set[Feature[_, _]] = Set(ScoreFeature)
private val ScaleFactor = 0.75 private val ScaleFactor = 1.0
override def apply( override def apply(
query: PipelineQuery, query: PipelineQuery,
@ -38,11 +38,9 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] {
} }
/** /**
* We should only be applying this multiplier to Out-Of-Network tweets. * Don't apply this multiplier; it's a bad idea.
* In-Network Retweets of Out-Of-Network tweets should not have this multiplier applied
*/ */
private def selector(candidate: CandidateWithFeatures[TweetCandidate]): Boolean = { private def selector(candidate: CandidateWithFeatures[TweetCandidate]): Boolean = {
!candidate.features.getOrElse(InNetworkFeature, false) && false
!candidate.features.getOrElse(IsRetweetFeature, false)
} }
} }