The-Homebrew-Cloud/Cemu
2
0
Fork 0
mirror of https://github.com/cemu-project/Cemu.git synced 2025-02-27 15:13:36 +01:00
Code Issues Packages Projects Releases Wiki Activity

don't release autoreleased objects

Browse Source
This commit is contained in:
Samuliak 2024-11-19 19:13:15 +01:00
parent c5bef60dbb
commit 7f5040a6e0
No known key found for this signature in database
5 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Cafe/HW/Latte/Renderer/Metal/MetalOutputShaderCache.cpp
View File

@ -31,7 +31,6 @@ MTL::RenderPipelineState* MetalOutputShaderCache::GetPipeline(RendererOutputShad
if (error) if (error)
{ {
cemuLog_log(LogType::Force, "error creating output render pipeline state: {}", error->localizedDescription()->utf8String()); cemuLog_log(LogType::Force, "error creating output render pipeline state: {}", error->localizedDescription()->utf8String());
error->release();
} }
return renderPipelineState; return renderPipelineState;

1
src/Cafe/HW/Latte/Renderer/Metal/MetalPipelineCompiler.cpp
View File

@ -389,7 +389,6 @@ bool MetalPipelineCompiler::Compile(bool forceCompile, bool isRenderThread, bool
if (error) if (error)
{ {
cemuLog_log(LogType::Force, "error creating render pipeline state: {}", error->localizedDescription()->utf8String()); cemuLog_log(LogType::Force, "error creating render pipeline state: {}", error->localizedDescription()->utf8String());
error->release();
} }
if (showInOverlay) if (showInOverlay)

6
src/Cafe/HW/Latte/Renderer/Metal/MetalRenderer.cpp
View File

@ -125,8 +125,6 @@ MetalRenderer::MetalRenderer()
if (error) if (error)
{ {
cemuLog_log(LogType::Force, "failed to create utility library (error: {})", error->localizedDescription()->utf8String()); cemuLog_log(LogType::Force, "failed to create utility library (error: {})", error->localizedDescription()->utf8String());
error->release();
throw;
return; return;
} }
@ -1666,7 +1664,7 @@ void MetalRenderer::EndEncoding()
if (m_commandEncoder) if (m_commandEncoder)
{ {
m_commandEncoder->endEncoding(); m_commandEncoder->endEncoding();
m_commandEncoder->release(); //m_commandEncoder->release();
m_commandEncoder = nullptr; m_commandEncoder = nullptr;
m_encoderType = MetalEncoderType::None; m_encoderType = MetalEncoderType::None;
@ -1720,7 +1718,7 @@ void MetalRenderer::ProcessFinishedCommandBuffers()
if (CommandBufferCompleted(commandBuffer)) if (CommandBufferCompleted(commandBuffer))
{ {
m_memoryManager->GetTemporaryBufferAllocator().CommandBufferFinished(commandBuffer); m_memoryManager->GetTemporaryBufferAllocator().CommandBufferFinished(commandBuffer);
commandBuffer->release(); //commandBuffer->release();
it = m_executingCommandBuffers.erase(it); it = m_executingCommandBuffers.erase(it);
atLeastOneCompleted = true; atLeastOneCompleted = true;
} }

1
src/Cafe/HW/Latte/Renderer/Metal/MetalVoidVertexPipeline.cpp
View File

@ -16,7 +16,6 @@ MetalVoidVertexPipeline::MetalVoidVertexPipeline(class MetalRenderer* mtlRendere
if (error) if (error)
{ {
cemuLog_log(LogType::Force, "error creating hybrid render pipeline state: {}", error->localizedDescription()->utf8String()); cemuLog_log(LogType::Force, "error creating hybrid render pipeline state: {}", error->localizedDescription()->utf8String());
error->release();
} }
} }

1
src/Cafe/HW/Latte/Renderer/Metal/RendererShaderMtl.cpp
View File

@ -185,7 +185,6 @@ void RendererShaderMtl::CompileInternal()
if (error) if (error)
{ {
cemuLog_log(LogType::Force, "failed to create library: {} -> {}", error->localizedDescription()->utf8String(), m_mslCode.c_str()); cemuLog_log(LogType::Force, "failed to create library: {} -> {}", error->localizedDescription()->utf8String(), m_mslCode.c_str());
error->release();
FinishCompilation(); FinishCompilation();
return; return;
} }