The-Homebrew-Cloud/Cemu
2
0
Fork 0
mirror of https://github.com/cemu-project/Cemu.git synced 2024-11-25 18:46:55 +01:00
Code Issues Packages Projects Releases Wiki Activity

Vulkan: Only create imgui renderpass once (#972)

Browse Source
This commit is contained in:
goeiecool9999 2023-09-20 19:01:56 +02:00 committed by GitHub
parent 1d398551e2
commit b4aa10bee4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 36 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Cafe/HW/Latte/Renderer/Vulkan/VulkanRenderer.cpp
View File

@ -1508,6 +1508,8 @@ void VulkanRenderer::DeleteNullObjects()
void VulkanRenderer::ImguiInit() void VulkanRenderer::ImguiInit()
{ {
if (m_imguiRenderPass == VK_NULL_HANDLE)
{
// TODO: renderpass swapchain format may change between srgb and rgb -> need reinit // TODO: renderpass swapchain format may change between srgb and rgb -> need reinit
VkAttachmentDescription colorAttachment = {}; VkAttachmentDescription colorAttachment = {};
colorAttachment.format = m_mainSwapchainInfo->m_surfaceFormat.format; colorAttachment.format = m_mainSwapchainInfo->m_surfaceFormat.format;
@ -1536,6 +1538,7 @@ void VulkanRenderer::ImguiInit()
const auto result = vkCreateRenderPass(m_logicalDevice, &renderPassInfo, nullptr, &m_imguiRenderPass); const auto result = vkCreateRenderPass(m_logicalDevice, &renderPassInfo, nullptr, &m_imguiRenderPass);
if (result != VK_SUCCESS) if (result != VK_SUCCESS)
throw VkException(result, "can't create imgui renderpass"); throw VkException(result, "can't create imgui renderpass");
}
ImGui_ImplVulkan_InitInfo info{}; ImGui_ImplVulkan_InitInfo info{};
info.Instance = m_instance; info.Instance = m_instance;
@ -1564,6 +1567,12 @@ void VulkanRenderer::Shutdown()
Renderer::Shutdown(); Renderer::Shutdown();
SubmitCommandBuffer(); SubmitCommandBuffer();
WaitDeviceIdle(); WaitDeviceIdle();
if (m_imguiRenderPass != VK_NULL_HANDLE)
{
vkDestroyRenderPass(m_logicalDevice, m_imguiRenderPass, nullptr);
m_imguiRenderPass = VK_NULL_HANDLE;
}
} }
void VulkanRenderer::UnrecoverableError(const char* errMsg) const void VulkanRenderer::UnrecoverableError(const char* errMsg) const

2
src/Cafe/HW/Latte/Renderer/Vulkan/VulkanRenderer.h
View File

@ -441,7 +441,7 @@ private:
bool m_destroyPadSwapchainNextAcquire = false; bool m_destroyPadSwapchainNextAcquire = false;
bool IsSwapchainInfoValid(bool mainWindow) const; bool IsSwapchainInfoValid(bool mainWindow) const;
VkRenderPass m_imguiRenderPass = nullptr; VkRenderPass m_imguiRenderPass = VK_NULL_HANDLE;
VkDescriptorPool m_descriptorPool; VkDescriptorPool m_descriptorPool;