The-Homebrew-Cloud/Lime3DS
2
0
Fork 0
mirror of https://github.com/Lime3DS/Lime3DS.git synced 2024-11-02 08:25:07 +01:00
Code Issues Packages Projects Releases Wiki Activity

telemetry: Remove unnecessary Field constructor

Browse Source 
We can just take the value parameter by value which allows both moving
into it, and copies at the same time, depending on the calling code.
This commit is contained in:
Lioncash 2018-07-18 16:18:30 -04:00
parent 3244042c4c
commit 0a8563fb79
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/common/telemetry.h
View File

@ -52,10 +52,7 @@ public:
template <typename T> template <typename T>
class Field : public FieldInterface { class Field : public FieldInterface {
public: public:
Field(FieldType type, std::string name, const T& value) Field(FieldType type, std::string name, T value)
: name(std::move(name)), type(type), value(value) {}
Field(FieldType type, std::string name, T&& value)
: name(std::move(name)), type(type), value(std::move(value)) {} : name(std::move(name)), type(type), value(std::move(value)) {}
Field(const Field& other) = default; Field(const Field& other) = default;