From 1cca713e3ba18c9bc8d6f354baf17081f9059b55 Mon Sep 17 00:00:00 2001
From: Charles Lombardo <clombardo169@gmail.com>
Date: Thu, 9 Mar 2023 11:24:32 -0500
Subject: [PATCH] citra_android: New settings fragment animations (#6332)

---
 .../settings/ui/SettingsActivity.java         |  8 +++---
 .../anim_pop_settings_fragment_out.xml        | 16 +++++++++++
 .../anim-ldrtl/anim_settings_fragment_in.xml  | 16 +++++++++++
 .../anim/anim_pop_settings_fragment_out.xml   | 16 +++++++++++
 .../res/anim/anim_settings_fragment_in.xml    | 16 +++++++++++
 .../res/anim/anim_settings_fragment_out.xml   | 10 +++++++
 .../src/main/res/animator/settings_enter.xml  | 28 -------------------
 .../src/main/res/animator/settings_exit.xml   | 28 -------------------
 .../main/res/animator/settings_pop_enter.xml  | 28 -------------------
 .../main/res/animator/setttings_pop_exit.xml  | 27 ------------------
 10 files changed, 78 insertions(+), 115 deletions(-)
 create mode 100644 src/android/app/src/main/res/anim-ldrtl/anim_pop_settings_fragment_out.xml
 create mode 100644 src/android/app/src/main/res/anim-ldrtl/anim_settings_fragment_in.xml
 create mode 100644 src/android/app/src/main/res/anim/anim_pop_settings_fragment_out.xml
 create mode 100644 src/android/app/src/main/res/anim/anim_settings_fragment_in.xml
 create mode 100644 src/android/app/src/main/res/anim/anim_settings_fragment_out.xml
 delete mode 100644 src/android/app/src/main/res/animator/settings_enter.xml
 delete mode 100644 src/android/app/src/main/res/animator/settings_exit.xml
 delete mode 100644 src/android/app/src/main/res/animator/settings_pop_enter.xml
 delete mode 100644 src/android/app/src/main/res/animator/setttings_pop_exit.xml

diff --git a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.java b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.java
index 23c3c4c9e..91adf7dae 100644
--- a/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.java
+++ b/src/android/app/src/main/java/org/citra/citra_emu/features/settings/ui/SettingsActivity.java
@@ -107,10 +107,10 @@ public final class SettingsActivity extends AppCompatActivity implements Setting
         if (addToStack) {
             if (areSystemAnimationsEnabled()) {
                 transaction.setCustomAnimations(
-                        R.animator.settings_enter,
-                        R.animator.settings_exit,
-                        R.animator.settings_pop_enter,
-                        R.animator.setttings_pop_exit);
+                        R.anim.anim_settings_fragment_in,
+                        R.anim.anim_settings_fragment_out,
+                        0,
+                        R.anim.anim_pop_settings_fragment_out);
             }
 
             transaction.addToBackStack(null);
diff --git a/src/android/app/src/main/res/anim-ldrtl/anim_pop_settings_fragment_out.xml b/src/android/app/src/main/res/anim-ldrtl/anim_pop_settings_fragment_out.xml
new file mode 100644
index 000000000..9f49c133a
--- /dev/null
+++ b/src/android/app/src/main/res/anim-ldrtl/anim_pop_settings_fragment_out.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <alpha
+        android:duration="125"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromAlpha="1"
+        android:toAlpha="0" />
+
+    <translate
+        android:duration="125"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromXDelta="0"
+        android:toXDelta="-75" />
+
+</set>
diff --git a/src/android/app/src/main/res/anim-ldrtl/anim_settings_fragment_in.xml b/src/android/app/src/main/res/anim-ldrtl/anim_settings_fragment_in.xml
new file mode 100644
index 000000000..82fd719db
--- /dev/null
+++ b/src/android/app/src/main/res/anim-ldrtl/anim_settings_fragment_in.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <alpha
+        android:duration="@android:integer/config_shortAnimTime"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromAlpha="0"
+        android:toAlpha="1" />
+
+    <translate
+        android:duration="@android:integer/config_shortAnimTime"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromXDelta="-200"
+        android:toXDelta="0" />
+
+</set>
diff --git a/src/android/app/src/main/res/anim/anim_pop_settings_fragment_out.xml b/src/android/app/src/main/res/anim/anim_pop_settings_fragment_out.xml
new file mode 100644
index 000000000..5892128f1
--- /dev/null
+++ b/src/android/app/src/main/res/anim/anim_pop_settings_fragment_out.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <alpha
+        android:duration="125"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromAlpha="1"
+        android:toAlpha="0" />
+
+    <translate
+        android:duration="125"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromXDelta="0"
+        android:toXDelta="75" />
+
+</set>
diff --git a/src/android/app/src/main/res/anim/anim_settings_fragment_in.xml b/src/android/app/src/main/res/anim/anim_settings_fragment_in.xml
new file mode 100644
index 000000000..98e0cf8bd
--- /dev/null
+++ b/src/android/app/src/main/res/anim/anim_settings_fragment_in.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <alpha
+        android:duration="@android:integer/config_shortAnimTime"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromAlpha="0"
+        android:toAlpha="1" />
+
+    <translate
+        android:duration="@android:integer/config_shortAnimTime"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromXDelta="200"
+        android:toXDelta="0" />
+
+</set>
diff --git a/src/android/app/src/main/res/anim/anim_settings_fragment_out.xml b/src/android/app/src/main/res/anim/anim_settings_fragment_out.xml
new file mode 100644
index 000000000..77a40a4d1
--- /dev/null
+++ b/src/android/app/src/main/res/anim/anim_settings_fragment_out.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<set xmlns:android="http://schemas.android.com/apk/res/android">
+
+    <alpha
+        android:duration="@android:integer/config_shortAnimTime"
+        android:interpolator="@android:anim/decelerate_interpolator"
+        android:fromAlpha="1"
+        android:toAlpha="0" />
+
+</set>
diff --git a/src/android/app/src/main/res/animator/settings_enter.xml b/src/android/app/src/main/res/animator/settings_enter.xml
deleted file mode 100644
index 3c216a054..000000000
--- a/src/android/app/src/main/res/animator/settings_enter.xml
+++ /dev/null
@@ -1,28 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="yFraction"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="1.0"
-        android:valueTo="0" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="translationZ"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="100.0"
-        android:valueTo="0" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="elevation"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="100.0"
-        android:valueTo="0" />
-
-</set>
\ No newline at end of file
diff --git a/src/android/app/src/main/res/animator/settings_exit.xml b/src/android/app/src/main/res/animator/settings_exit.xml
deleted file mode 100644
index a233b6757..000000000
--- a/src/android/app/src/main/res/animator/settings_exit.xml
+++ /dev/null
@@ -1,28 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/accelerate_cubic"
-        android:propertyName="visibleness"
-        android:valueFrom="1.0f"
-        android:valueTo="0.6f"
-        android:valueType="floatType" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="translationZ"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="0"
-        android:valueTo="-100.0" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="elevation"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="0"
-        android:valueTo="-100.0" />
-
-</set>
\ No newline at end of file
diff --git a/src/android/app/src/main/res/animator/settings_pop_enter.xml b/src/android/app/src/main/res/animator/settings_pop_enter.xml
deleted file mode 100644
index 080bc27c4..000000000
--- a/src/android/app/src/main/res/animator/settings_pop_enter.xml
+++ /dev/null
@@ -1,28 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="visibleness"
-        android:valueFrom="0.6f"
-        android:valueTo="1.0f"
-        android:valueType="floatType" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="translationZ"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="-100.0"
-        android:valueTo="0" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="elevation"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="-100.0"
-        android:valueTo="0" />
-
-</set>
\ No newline at end of file
diff --git a/src/android/app/src/main/res/animator/setttings_pop_exit.xml b/src/android/app/src/main/res/animator/setttings_pop_exit.xml
deleted file mode 100644
index 4fccbcca2..000000000
--- a/src/android/app/src/main/res/animator/setttings_pop_exit.xml
+++ /dev/null
@@ -1,27 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<set xmlns:android="http://schemas.android.com/apk/res/android">
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/accelerate_cubic"
-        android:propertyName="yFraction"
-        android:valueFrom="0"
-        android:valueTo="1.0" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="translationZ"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="0.0"
-        android:valueTo="100" />
-
-    <objectAnimator
-        android:duration="@android:integer/config_mediumAnimTime"
-        android:interpolator="@android:interpolator/decelerate_cubic"
-        android:propertyName="elevation"
-        android:startOffset="@android:integer/config_shortAnimTime"
-        android:valueFrom="0.0"
-        android:valueTo="100" />
-
-</set>
\ No newline at end of file