The-Homebrew-Cloud/N64FlashcartMenu
2
0
Fork 0
mirror of https://github.com/Polprzewodnikowy/N64FlashcartMenu.git synced 2024-11-22 02:29:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve savedb comments

Browse Source
This commit is contained in:
Robin Jones 2023-04-05 00:27:28 +00:00
parent 4e3699cba7
commit 3acaae4e6d
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/menu/rom_database.c
View File

@ -1,13 +1,19 @@
#include "rom_database.h" #include "rom_database.h"
#include <stdint.h> #include <stdint.h>
uint8_t rom_db_match_save_type(uint16_t id, uint32_t crc) { // TODO: make sure this can also handle an external input file.
uint8_t rom_db_match_save_type(uint16_t id, uint32_t crc) { //FIXME: the ID should be 4 chars (uint32)
// These are ordered to ensure they are handled correctly...
// First: Match by the `ED` Developer ID
// TODO: if appropriate this can be improved with other unused codes... e.g. | `AA` | `ZZ`
if (id == *(uint16_t *)"ED") { if (id == *(uint16_t *)"ED") {
return DB_SAVE_TYPE_CART_SPECIFIED; return DB_SAVE_TYPE_CART_SPECIFIED;
} }
// Match the default entries for crc_high. // Second: Match the default entries for crc_high.
if (crc == 0xbcb1f89f)return DB_SAVE_TYPE_EEPROM_4K; // kirby v1.3 if (crc == 0xbcb1f89f)return DB_SAVE_TYPE_EEPROM_4K; // kirby v1.3
if (crc == 0x46039fb4)return DB_SAVE_TYPE_EEPROM_16K; // kirby U if (crc == 0x46039fb4)return DB_SAVE_TYPE_EEPROM_16K; // kirby U
if (crc == 0x0d93ba11)return DB_SAVE_TYPE_EEPROM_16K; // kirby U if (crc == 0x0d93ba11)return DB_SAVE_TYPE_EEPROM_16K; // kirby U
@ -17,7 +23,9 @@ uint8_t rom_db_match_save_type(uint16_t id, uint32_t crc) {
if (crc == 0xeb85ebc9)return DB_SAVE_TYPE_FLASHRAM; // DOUBUTSU BANCHOU (ANIMAL LEADER, Cubivore) - Contains no game ID if (crc == 0xeb85ebc9)return DB_SAVE_TYPE_FLASHRAM; // DOUBUTSU BANCHOU (ANIMAL LEADER, Cubivore) - Contains no game ID
// Match the default entries for ROM ID. // FIXME: we need to take into account the Category (first char) and the Region code (last char) before a general match of the ID.
// Finally: Match the default entries for "unique" ROM ID.
// It is useful to use this rather than CRC's so that ROM hacks continue to work. // It is useful to use this rather than CRC's so that ROM hacks continue to work.
static char *cart_ids[] = { static char *cart_ids[] = {
// EEP4K // EEP4K