From e7c80d27ab8c019785771dc0545fd2c1e88e8065 Mon Sep 17 00:00:00 2001
From: Robin Jones <networkfusion@users.noreply.github.com>
Date: Wed, 17 Jul 2024 22:52:24 +0100
Subject: [PATCH] Rom info improvements (#122)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
improves upon #121

## Motivation and Context
<!--- What does this sample do? What problem does it solve? -->
<!--- If it fixes/closes/resolves an open issue, please link to the
issue here -->

## How Has This Been Tested?
<!-- (if applicable) -->
<!--- Please describe in detail how you tested your sample/changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots
<!-- (if appropriate): -->

![image](https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/11439699/d91185a0-dc39-42d9-aedc-3dbd4b6c965d)


![image](https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/11439699/13d18d06-d14c-4e2a-8974-1c62ea8863f4)


## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Improvement (non-breaking change that adds a new feature)
- [ ] Bug fix (fixes an issue)
- [ ] Breaking change (breaking change)
- [ ] Config and build (change in the configuration and build system,
has no impact on code or features)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

<!--- It would be nice if you could sign off your contribution by
replacing the name with your GitHub user name and GitHub email contact.
-->
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>
---
 src/menu/views/load_rom.c | 49 +++++++++++++++++++++------------------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/src/menu/views/load_rom.c b/src/menu/views/load_rom.c
index 5e2f2b70..ee60b4a7 100644
--- a/src/menu/views/load_rom.c
+++ b/src/menu/views/load_rom.c
@@ -237,34 +237,23 @@ static void draw (menu_t *menu, surface_t *d) {
             "\n"
             "\n"
             "\n"
-            " Endianness: %s\n"
-            " Title: %.20s\n"
-            " Game code: %c%c%c%c\n"
-            " Media type: %s\n"
-            " Destination market: %s\n"
-            " Version: %hhu\n"
-            " Check code: 0x%016llX\n"
-            " Save type: %s\n"
-            " TV type: %s\n"
-            " Expansion PAK: %s\n"
-            " CIC: %s\n",
-            format_rom_endianness(menu->load.rom_info.endianness),
-            menu->load.rom_info.title,
-            menu->load.rom_info.game_code[0], menu->load.rom_info.game_code[1], menu->load.rom_info.game_code[2], menu->load.rom_info.game_code[3],
-            format_rom_media_type(menu->load.rom_info.category_code),
-            format_rom_destination_market(menu->load.rom_info.destination_code),
-            menu->load.rom_info.version,
-            menu->load.rom_info.check_code,
+            "Description:\n None.\n\n\n\n\n\n\n\n"
+            "Expansion PAK:      %s\n"
+            "Save type:          %s\n"
+            "TV type:            %s\n"
+            "CIC:                %s\n"
+            "GS/AR Cheats:       Off\n"
+            "Patches:            Off\n",
+            format_rom_expansion_pak_info(menu->load.rom_info.features.expansion_pak),
             format_rom_save_type(rom_info_get_save_type(&menu->load.rom_info)),
             format_rom_tv_type(rom_info_get_tv_type(&menu->load.rom_info)),
-            format_rom_expansion_pak_info(menu->load.rom_info.features.expansion_pak),
             format_cic_type(rom_info_get_cic_type(&menu->load.rom_info))
         );
 
         component_actions_bar_text_draw(
             ALIGN_LEFT, VALIGN_TOP,
             "A: Load and run ROM\n"
-            "B: Exit"
+            "B: Back"
         );
 
         component_actions_bar_text_draw(
@@ -279,10 +268,24 @@ static void draw (menu_t *menu, surface_t *d) {
             component_messagebox_draw(
                 "EXTRA ROM INFO\n"
                 "\n"
-                " Boot address: 0x%08lX\n"
-                " SDK version: %.1f%c\n"
-                " Clock Rate: %.2fMHz\n\n\n"
+                "Endianness: %s\n"
+                "Title: %.20s\n"
+                "Game code: %c%c%c%c\n"
+                "Media type: %s\n"
+                "Variant: %s\n"
+                "Version: %hhu\n"
+                "Check code: 0x%016llX\n"
+                "Boot address: 0x%08lX\n"
+                "SDK version: %.1f%c\n"
+                "Clock Rate: %.2fMHz\n\n\n"
                 "Press L|Z to return.\n",
+                format_rom_endianness(menu->load.rom_info.endianness),
+                menu->load.rom_info.title,
+                menu->load.rom_info.game_code[0], menu->load.rom_info.game_code[1], menu->load.rom_info.game_code[2], menu->load.rom_info.game_code[3],
+                format_rom_media_type(menu->load.rom_info.category_code),
+                format_rom_destination_market(menu->load.rom_info.destination_code),
+                menu->load.rom_info.version,
+                menu->load.rom_info.check_code,
                 menu->load.rom_info.boot_address,
                 (menu->load.rom_info.libultra.version / 10.0f), menu->load.rom_info.libultra.revision,
                 menu->load.rom_info.clock_rate