The-Homebrew-Cloud/N64FlashcartMenu
2
0
Fork 0
mirror of https://github.com/Polprzewodnikowy/N64FlashcartMenu.git synced 2025-02-19 19:42:53 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rom info improvements (controller pak) (#123)

Browse Source 
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
Show whether a ROM supports (or requires) a controller pak
Builds on #122 

## Motivation and Context
<!--- What does this sample do? What problem does it solve? -->
<!--- If it fixes/closes/resolves an open issue, please link to the
issue here -->

## How Has This Been Tested?
<!-- (if applicable) -->
<!--- Please describe in detail how you tested your sample/changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots
<!-- (if appropriate): -->

![image](https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/11439699/2a83965e-c92a-408f-bb9e-af693b63f738)


![image](https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/11439699/e9bb0d12-6ec0-4737-80f8-62bfa75944cb)



![image](https://github.com/Polprzewodnikowy/N64FlashcartMenu/assets/11439699/0897f55f-fb01-4bbe-b6d6-b51aaff6e13c)



## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Improvement (non-breaking change that adds a new feature)
- [ ] Bug fix (fixes an issue)
- [ ] Breaking change (breaking change)
- [ ] Config and build (change in the configuration and build system,
has no impact on code or features)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

<!--- It would be nice if you could sign off your contribution by
replacing the name with your GitHub user name and GitHub email contact.
-->
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>
This commit is contained in:
Robin Jones 2024-07-17 23:01:22 +01:00 committed by GitHub
parent e7c80d27ab
commit f299bdcac9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/menu/views/load_rom.c
View File

@ -66,16 +66,16 @@ static const char *format_rom_destination_market (rom_destination_type_t market_
}
}
static const char *format_rom_save_type (rom_save_type_t save_type) {
static const char *format_rom_save_type (rom_save_type_t save_type, bool supports_cpak) {
switch (save_type) {
case SAVE_TYPE_NONE: return "None";
case SAVE_TYPE_EEPROM_4KBIT: return "EEPROM 4kbit";
case SAVE_TYPE_EEPROM_16KBIT: return "EEPROM 16kbit";
case SAVE_TYPE_SRAM_256KBIT: return "SRAM 256kbit";
case SAVE_TYPE_SRAM_BANKED: return "SRAM 768kbit / 3 banks";
case SAVE_TYPE_SRAM_1MBIT: return "SRAM 1Mbit";
case SAVE_TYPE_FLASHRAM_1MBIT: return "FlashRAM 1Mbit";
case SAVE_TYPE_FLASHRAM_PKST2: return "FlashRAM (Pokemon Stadium 2)";
case SAVE_TYPE_NONE: return supports_cpak ? "Controller PAK" : "None";
case SAVE_TYPE_EEPROM_4KBIT: return supports_cpak ? "EEPROM 4kbit | Controller PAK" : "EEPROM 4kbit";
case SAVE_TYPE_EEPROM_16KBIT: return supports_cpak ? "EEPROM 16kbit | Controller PAK" : "EEPROM 16kbit";
case SAVE_TYPE_SRAM_256KBIT: return supports_cpak ? "SRAM 256kbit | Controller PAK" : "SRAM 256kbit";
case SAVE_TYPE_SRAM_BANKED: return supports_cpak ? "SRAM 768kbit / 3 banks | Controller PAK" : "SRAM 768kbit / 3 banks";
case SAVE_TYPE_SRAM_1MBIT: return supports_cpak ? "SRAM 1Mbit | Controller PAK" : "SRAM 1Mbit";
case SAVE_TYPE_FLASHRAM_1MBIT: return supports_cpak ? "FlashRAM 1Mbit | Controller PAK" : "FlashRAM 1Mbit";
case SAVE_TYPE_FLASHRAM_PKST2: return supports_cpak ? "FlashRAM (Pokemon Stadium 2) | Controller PAK" : "FlashRAM (Pokemon Stadium 2)";
default: return "Unknown";
}
}
@ -238,16 +238,16 @@ static void draw (menu_t *menu, surface_t *d) {
"\n"
"\n"
"Description:\n None.\n\n\n\n\n\n\n\n"
"Expansion PAK: %s\n"
"Save type: %s\n"
"TV type: %s\n"
"CIC: %s\n"
"GS/AR Cheats: Off\n"
"Patches: Off\n",
"Expansion PAK: %s\n"
"TV type: %s\n"
"CIC: %s\n"
"GS/AR Cheats: Off\n"
"Patches: Off\n"
"Save type: %s\n",
format_rom_expansion_pak_info(menu->load.rom_info.features.expansion_pak),
format_rom_save_type(rom_info_get_save_type(&menu->load.rom_info)),
format_rom_tv_type(rom_info_get_tv_type(&menu->load.rom_info)),
format_cic_type(rom_info_get_cic_type(&menu->load.rom_info))
format_cic_type(rom_info_get_cic_type(&menu->load.rom_info)),
format_rom_save_type(rom_info_get_save_type(&menu->load.rom_info), menu->load.rom_info.features.controller_pak)
);
component_actions_bar_text_draw(