Ross Gouldthorpe 3bd0a2eb97
Fix for crashing when deleting a favorite (#216)
Fix for crashing when deleting a favorite

## Description
Fixed a bounds check that allowed the copy loop to go out of bounds.

## Motivation and Context
<!--- What does this sample do? What problem does it solve? -->
<!--- If it fixes/closes/resolves an open issue, please link to the
issue here -->

## How Has This Been Tested?
<!-- (if applicable) -->
<!--- Please describe in detail how you tested your sample/changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots
<!-- (if appropriate): -->

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [ ] Improvement (non-breaking change that adds a new feature)
- [x] Bug fix (fixes an issue)
- [ ] Breaking change (breaking change)
- [ ] Documentation Improvement
- [ ] Config and build (change in the configuration and build system,
has no impact on code or features)

## Checklist:
<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

<!--- It would be nice if you could sign off your contribution by
replacing the name with your GitHub user name and GitHub email contact.
-->
Signed-off-by: GITHUB_USER <GITHUB_USER_EMAIL>
2025-02-07 07:42:24 +00:00
2024-12-23 18:34:41 +00:00
2025-01-12 12:22:22 +00:00
2023-12-08 19:49:50 +01:00
2024-04-26 23:04:19 +02:00
2024-11-10 00:48:55 +00:00
2025-01-12 23:41:32 +00:00
2025-01-27 02:37:10 +00:00

Build GitHub Org's stars Average time to resolve an issue Percentage of issues still open #yourfirstpr

N64 Flashcart Menu

An open source menu for N64 flashcarts and aims to support as many as possible. The menu is not affiliated with any partuclar flashcart and does not necessarily expose all capable firmware features.
This project considers flashcart sellers that include this menu or copyrighted ROM's as part of their product offering as licence offenders which may result in future action.

Flashcart Supported

This menu aims to support as many N64 flashcarts as possible. The current state is:

Supported

  • SummerCart64
  • 64Drive

Work in Progress

  • ED64 (X and V series)
  • ED64P (clones)

Not yet planned

  • Doctor V64
  • PicoCart
  • DaisyDrive

Current (notable) menu features

  • Fully Open Source.
  • Loads all known N64 games, even if they are byteswapped.
  • Fully emulates the 64DD and loads 64DD disks (SummerCart64 only).
  • Emulator support (NES, SNES, GB, GBC, SMS, GG, CHF) ROMs.
  • N64 ROM box art image support.
  • Background image (PNG) support.
  • Comprehensive ROM save database (including homebrew headers).
  • Comprehensive ROM information display.
  • Real Time Clock support.
  • Music playback (MP3).
  • Menu sound effects.
  • N64 ROM autoload.
  • ROM information descriptions.
  • ROM history and favorites (pre-release only).

Documentation

Please take a moment to browse the current documentation:
Index

Aims

  • Support as many N64 Flashcarts as possible.
  • Be open source, using permissively licensed third-party libraries.
  • Be testable in an emulated environment (Ares).
  • Encourage active development from community members and N64 FlashCart owners.
  • Support as many common mods and features as possible (flashcart dependent).

Flashcart specific

SC64

  • Ensure the cart has the latest firmware installed.
  • Download the latest sc64menu.n64 file from the releases page, then put it in the root directory of your SD card.

SC64 flashcart information

64drive

  • Ensure the cart has the latest firmware installed.
  • Download the latest menu.bin file from the releases page, then put it in the root directory of your SD card.

ED64 - WIP - UNTESTED AND UNSUPPORTED - USE AT OWN RISK

Currently not supported, but work is in progress (See PRs). Warning: The menu may be able to load ROMs but cannot guarantee save functionality. Existing saves may be corrupted.

ED64 (Vseries)

The aim is to reach feature parity with ED64-UnofficialOS / ED64-OfficialOS. Download the OS64.v64 ROM from the latest [action run - assets] and place it in the /ED64 folder.

ED64 (X series)

The aim is to reach feature parity with OS for now. Download the OS64.v64 ROM from the latest [action run - assets] and place it in the /ED64 folder.

ED64 (P clone)

Download the OS64P.v64 ROM from the latest [action run - assets] and place it in the /ED64P folder. The aim is to reach feature parity with Altra64

Open source software and licenses used

libraries

Sounds

See License for the following sounds:

Description
Universal N64 flashcart menu for wide variety of devices
Readme 15 MiB
Languages
C 97.8%
Makefile 1.2%
Assembly 0.5%
Dockerfile 0.2%
Batchfile 0.2%