The-Homebrew-Cloud/PayloadLoaderPayload
2
0
Fork 0
mirror of https://github.com/wiiu-env/PayloadLoaderPayload.git synced 2024-06-26 13:26:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update main.cpp

Browse Source 
Memory fixes, head_end doesnt get freed and you shouldnt use ->prev pointer after its freed. Also memory leak when payload is selected.
This commit is contained in:
Maniac- 2022-01-15 17:29:33 +02:00 committed by GitHub
parent 6098af25eb
commit 5074c962aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main.cpp
View File

@ -95,14 +95,15 @@ extern "C" int _start(int argc, char **argv) {
// Somewhere in this loader is a memory leak. // Somewhere in this loader is a memory leak.
// This is a hacky solution to free that memory. // This is a hacky solution to free that memory.
uint32_t head_end = (uint32_t) malloc(1024); uint32_t head_end = (uint32_t) malloc(1024);
MEMExpHeapBlock *curUsedBlock = (MEMExpHeapBlock *) (head_end - 0x14); MEMExpHeapBlock *prevBlock, *curUsedBlock = (MEMExpHeapBlock *) (head_end - 0x14);
while (curUsedBlock != 0) { while (curUsedBlock != 0) {
curUsedBlock = curUsedBlock->prev; prevBlock = curUsedBlock->prev;
free(&curUsedBlock[1]); free(&curUsedBlock[1]);
if(((uint32_t) &curUsedBlock[1]) == memory_start){ if(((uint32_t) &curUsedBlock[1]) == memory_start){
break; break;
} }
curUsedBlock = prevBlock;
} }
int res = -1; int res = -1;
@ -256,6 +257,7 @@ std::string PayloadSelectionScreen(const std::map<std::string, std::string> &pay
OSSleepTicks(OSMillisecondsToTicks(16)); OSSleepTicks(OSMillisecondsToTicks(16));
} }
free(screenBuffer);
int i = 0; int i = 0;
for (auto const&[key, val] : payloads) { for (auto const&[key, val] : payloads) {
if (i == selected) { if (i == selected) {
@ -263,6 +265,5 @@ std::string PayloadSelectionScreen(const std::map<std::string, std::string> &pay
} }
i++; i++;
} }
free(screenBuffer);
return ""; return "";
} }