mirror of
https://github.com/Ryujinx/SDL.git
synced 2024-09-23 15:38:35 +02:00
177f19aff0
Jason Wyatt After hiding the window, SDL_WINDOW_HIDDEN/SDL_WINDOW_SHOWN flags on a window are correctly updated. However on the next SDL_PumpEvents, they are set incorrectly. This appears to be because X11_GetNetWMState does not check whether the _NET_WM_STATE property exists (it shouldn't on unmapped windows, see https://specifications.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336). This results in an empty list of atoms for the state, which would imply that the window is not hidden. (Seen on Fedora 24, Gnome) -- Dan Ginsburg More details on my proposed patch: I am on Kubuntu 16.04.2. I ran into this same bug, but with Jason's patch I found that actualType != None was true so the SDL_WINDOW_HIDDEN would still not be set. My fix instead is to explicitly check for whether the window is unmapped rather than relying on the returned values in XGetWindowProperty. |
||
|---|---|---|
| .. | ||
| edid-parse.c | ||
| edid.h | ||
| imKStoUCS.c | ||
| imKStoUCS.h | ||
| SDL_x11clipboard.c | ||
| SDL_x11clipboard.h | ||
| SDL_x11dyn.c | ||
| SDL_x11dyn.h | ||
| SDL_x11events.c | ||
| SDL_x11events.h | ||
| SDL_x11framebuffer.c | ||
| SDL_x11framebuffer.h | ||
| SDL_x11keyboard.c | ||
| SDL_x11keyboard.h | ||
| SDL_x11messagebox.c | ||
| SDL_x11messagebox.h | ||
| SDL_x11modes.c | ||
| SDL_x11modes.h | ||
| SDL_x11mouse.c | ||
| SDL_x11mouse.h | ||
| SDL_x11opengl.c | ||
| SDL_x11opengl.h | ||
| SDL_x11opengles.c | ||
| SDL_x11opengles.h | ||
| SDL_x11shape.c | ||
| SDL_x11shape.h | ||
| SDL_x11sym.h | ||
| SDL_x11touch.c | ||
| SDL_x11touch.h | ||
| SDL_x11video.c | ||
| SDL_x11video.h | ||
| SDL_x11window.c | ||
| SDL_x11window.h | ||
| SDL_x11xinput2.c | ||
| SDL_x11xinput2.h | ||