From 6d5b19a8a671545954005486bf9d6b7ecebabe1d Mon Sep 17 00:00:00 2001
From: David Korth <gerbilsoft@gerbilsoft.com>
Date: Sat, 8 Apr 2023 15:10:36 -0400
Subject: [PATCH] SubmitScreen.cpp: Zero an unused OTP area before hashing.

This should normally be zero anyway, but zero it again just in case.
---
 source/screens/SubmitScreen.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/source/screens/SubmitScreen.cpp b/source/screens/SubmitScreen.cpp
index b629573..03c03b8 100644
--- a/source/screens/SubmitScreen.cpp
+++ b/source/screens/SubmitScreen.cpp
@@ -174,7 +174,7 @@ size_t SubmitScreen::CurlWriteCallback(void* contents, size_t size, size_t nmemb
 
 void SubmitScreen::SubmitSystemData()
 {
-    const auto& otp = OTP::Get();
+    auto otp = OTP::Get();
     const auto& seeprom = SEEPROM::Get();
     WUT_ALIGNAS(0x40) MCPSysProdSettings sysProd{};
     int32_t mcpHandle = MCP_Open();
@@ -259,6 +259,7 @@ void SubmitScreen::SubmitSystemData()
         // is fully contained within the MLC CID.
     }
 
+    memset(&otp.miscBank, 0, 0x40);
     if (Utils::SHA256(&otp, sizeof(otp), pd->otp_sha256, sizeof(pd->otp_sha256)) != 0) {
         error = "Failed to hash otp data";
         return;