The-Homebrew-Cloud/WiiUPluginLoaderBackend
2
0
Fork 0
mirror of https://github.com/wiiu-env/WiiUPluginLoaderBackend.git synced 2024-11-22 04:39:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid memory leak in StorageUtils

Browse Source
This commit is contained in:
Maschell 2022-08-26 21:58:58 +02:00
parent 4103493388
commit 876d7f0c29
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
source/utils/StorageUtils.cpp
View File

@ -66,7 +66,7 @@ WUPSStorageError StorageUtils::OpenStorage(const char *plugin_id, wups_storage_i
file.close(); file.close();
j = nlohmann::json::parse(json_data, nullptr, false); j = nlohmann::json::parse(json_data, nullptr, false);
delete[] json_data; free(json_data);
if (j == nlohmann::detail::value_t::discarded || j.empty() || !j.is_object()) { if (j == nlohmann::detail::value_t::discarded || j.empty() || !j.is_object()) {
return WUPS_STORAGE_ERROR_INVALID_JSON; return WUPS_STORAGE_ERROR_INVALID_JSON;
@ -127,11 +127,13 @@ WUPSStorageError StorageUtils::CloseStorage(const char *plugin_id, wups_storage_
j["storageitems"] = processItems(items); j["storageitems"] = processItems(items);
std::string jsonString = j.dump(4); std::string jsonString = j.dump(4);
auto writeSize = jsonString.size(); auto writeResult = file.write((const uint8_t *) jsonString.c_str(), jsonString.size());
auto *data = (uint8_t *) memalign(0x40, ROUNDUP(writeSize, 0x40));
memcpy(data, jsonString.c_str(), writeSize);
file.write(data, writeSize);
file.close(); file.close();
if (writeResult != (int32_t) jsonString.size()) {
return WUPS_STORAGE_ERROR_IO;
}
return WUPS_STORAGE_ERROR_SUCCESS; return WUPS_STORAGE_ERROR_SUCCESS;
} }