The-Homebrew-Cloud/WiiUPluginSystem
2
0
Fork 0
mirror of https://github.com/wiiu-env/WiiUPluginSystem.git synced 2025-02-09 05:43:23 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix potential memory leak when creating config items fails

Browse Source
This commit is contained in:
Maschell 2022-09-18 22:05:44 +02:00
parent bf8d300588
commit 7b9868bd0e
5 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/wups/config_imports.h
View File

@ -5,6 +5,8 @@
extern "C" int32_t WUPSConfigItem_Create(WUPSConfigItemHandle *out, const char *configID, const char *displayName, WUPSConfigCallbacks_t callbacks, void *context); extern "C" int32_t WUPSConfigItem_Create(WUPSConfigItemHandle *out, const char *configID, const char *displayName, WUPSConfigCallbacks_t callbacks, void *context);
extern "C" int32_t WUPSConfigItem_Destroy(WUPSConfigItemHandle handle);
extern "C" int32_t WUPSConfig_Destroy(WUPSConfigHandle handle); extern "C" int32_t WUPSConfig_Destroy(WUPSConfigHandle handle);
extern "C" int32_t WUPSConfigItem_SetDisplayName(WUPSConfigItemHandle handle, const char *displayName); extern "C" int32_t WUPSConfigItem_SetDisplayName(WUPSConfigItemHandle handle, const char *displayName);

1
libraries/libwups/WUPSConfigItemBoolean.cpp
View File

@ -90,6 +90,7 @@ WUPSConfigItemBoolean_AddToCategoryEx(WUPSConfigCategoryHandle cat, const char *
} }
if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) { if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) {
WUPSConfigItem_Destroy(item->handle);
return false; return false;
} }
return true; return true;

1
libraries/libwups/WUPSConfigItemIntegerRange.cpp
View File

@ -98,6 +98,7 @@ extern "C" bool WUPSConfigItemIntegerRange_AddToCategory(WUPSConfigCategoryHandl
}; };
if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) { if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) {
WUPSConfigItem_Destroy(item->handle);
return false; return false;
} }
return true; return true;

1
libraries/libwups/WUPSConfigItemMultipleValues.cpp
View File

@ -127,6 +127,7 @@ WUPSConfigItemMultipleValues_AddToCategory(WUPSConfigCategoryHandle cat, const c
} }
if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) { if (WUPSConfigCategory_AddItem(cat, item->handle) < 0) {
WUPSConfigItem_Destroy(item->handle);
return false; return false;
} }
return true; return true;

1
libraries/libwups/config.def
View File

@ -2,6 +2,7 @@
:TEXT :TEXT
WUPSConfigItem_Create WUPSConfigItem_Create
WUPSConfigItem_Destroy
WUPSConfigItem_SetDisplayName WUPSConfigItem_SetDisplayName
WUPSConfigItem_GetDisplayName WUPSConfigItem_GetDisplayName
WUPSConfigItem_SetConfigID WUPSConfigItem_SetConfigID