The-Homebrew-Cloud/cemu-DS4Windows
2
0
Fork 0
mirror of https://github.com/cemu-project/DS4Windows.git synced 2024-11-26 11:04:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Only access length property once in for loop

Browse Source
This commit is contained in:
Travis Nickles 2017-04-11 19:26:08 -07:00
parent 4ea9289a0d
commit beadb313ff
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
DS4Windows/DS4Library/DS4Device.cs
View File

@ -574,6 +574,7 @@ namespace DS4Windows
case 6: cState.DpadUp = false; cState.DpadDown = false; cState.DpadLeft = true; cState.DpadRight = false; break; case 6: cState.DpadUp = false; cState.DpadDown = false; cState.DpadLeft = true; cState.DpadRight = false; break;
case 7: cState.DpadUp = true; cState.DpadDown = false; cState.DpadLeft = true; cState.DpadRight = false; break; case 7: cState.DpadUp = true; cState.DpadDown = false; cState.DpadLeft = true; cState.DpadRight = false; break;
case 8: cState.DpadUp = false; cState.DpadDown = false; cState.DpadLeft = false; cState.DpadRight = false; break; case 8: cState.DpadUp = false; cState.DpadDown = false; cState.DpadLeft = false; cState.DpadRight = false; break;
default: break;
} }
cState.R3 = ((byte)inputReport[6] & (1 << 7)) != 0; cState.R3 = ((byte)inputReport[6] & (1 << 7)) != 0;
@ -700,6 +701,7 @@ namespace DS4Windows
{ {
hDevice.flush_Queue(); hDevice.flush_Queue();
} }
private void sendOutputReport(bool synchronous) private void sendOutputReport(bool synchronous)
{ {
setTestRumble(); setTestRumble();
@ -730,7 +732,9 @@ namespace DS4Windows
outputReportBuffer[10] = ledFlashOff; //flash off duration outputReportBuffer[10] = ledFlashOff; //flash off duration
outputReportBuffer[19] = outputReportBuffer[20] = Convert.ToByte(audio.Volume); outputReportBuffer[19] = outputReportBuffer[20] = Convert.ToByte(audio.Volume);
} }
bool quitOutputThread = false; bool quitOutputThread = false;
lock (outputReport) lock (outputReport)
{ {
if (synchronous) if (synchronous)
@ -753,7 +757,7 @@ namespace DS4Windows
else else
{ {
bool output = false; bool output = false;
for (int i = 0; !output && i < outputReport.Length; i++) for (int i = 0, arlen = outputReport.Length; !output && i < arlen; i++)
output = outputReport[i] != outputReportBuffer[i]; output = outputReport[i] != outputReportBuffer[i];
if (output) if (output)
{ {
@ -823,8 +827,6 @@ namespace DS4Windows
disconnectReport[0] = 0xe2; disconnectReport[0] = 0xe2;
disconnectReport[1] = 0x02; disconnectReport[1] = 0x02;
Array.Clear(disconnectReport, 2, 63); Array.Clear(disconnectReport, 2, 63);
//for (int i = 2; i < 65; i++)
// disconnectReport[i] = 0;
result = hDevice.WriteFeatureReport(disconnectReport); result = hDevice.WriteFeatureReport(disconnectReport);
if (result && remove) if (result && remove)