The-Homebrew-Cloud/dolphin
2
0
Fork 0
mirror of https://github.com/dolphin-emu/dolphin.git synced 2025-01-25 07:21:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

IOS/FS: On NAND redirected files, the source and target of a Rename operation may be on different partitions or devices. Implement a fallback for that.

Browse Source
This commit is contained in:
Admiral H. Curtiss 2021-10-23 02:03:11 +02:00
parent fe7f3a6f26
commit 0efff5167d
No known key found for this signature in database
GPG Key ID: F051B4C4044F33FB
1 changed files with 25 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Source/Core/Core/IOS/FS/HostBackend/FS.cpp
View File

@ -506,8 +506,10 @@ ResultCode HostFileSystem::Rename(Uid uid, Gid gid, const std::string& old_path,
return ResultCode::InUse; return ResultCode::InUse;
} }
const std::string host_old_path = BuildFilename(old_path).host_path; const auto host_old_info = BuildFilename(old_path);
const std::string host_new_path = BuildFilename(new_path).host_path; const auto host_new_info = BuildFilename(new_path);
const std::string& host_old_path = host_old_info.host_path;
const std::string& host_new_path = host_new_info.host_path;
// If there is already something of the same type at the new path, delete it. // If there is already something of the same type at the new path, delete it.
if (File::Exists(host_new_path)) if (File::Exists(host_new_path))
@ -524,8 +526,27 @@ ResultCode HostFileSystem::Rename(Uid uid, Gid gid, const std::string& old_path,
if (!File::Rename(host_old_path, host_new_path)) if (!File::Rename(host_old_path, host_new_path))
{ {
ERROR_LOG_FMT(IOS_FS, "Rename {} to {} - failed", host_old_path, host_new_path); if (host_old_info.is_redirect || host_new_info.is_redirect)
return ResultCode::NotFound; {
// If either path is a redirect, the source and target may be on a different partition or
// device, so a simple rename may not work. Fall back to Copy & Delete and see if that works.
if (!File::Copy(host_old_path, host_new_path))
{
ERROR_LOG_FMT(IOS_FS, "Copying {} to {} in Rename fallback failed", host_old_path,
host_new_path);
return ResultCode::NotFound;
}
if (!File::Delete(host_old_path))
{
ERROR_LOG_FMT(IOS_FS, "Deleting {} in Rename fallback failed", host_old_path);
return ResultCode::Invalid;
}
}
else
{
ERROR_LOG_FMT(IOS_FS, "Rename {} to {} - failed", host_old_path, host_new_path);
return ResultCode::NotFound;
}
} }
// Finally, remove the child from the old parent and move it to the new parent. // Finally, remove the child from the old parent and move it to the new parent.