From f205a20d3f39cea6e9329d239e2f1b14ca6cfce7 Mon Sep 17 00:00:00 2001 From: Charles Lombardo Date: Sat, 23 Sep 2023 10:48:23 -0400 Subject: [PATCH 1/2] Android: Use 0.5 unit step size and show decimal for numeric settings In some settings where the default value could not be evenly divided by the step size for the slider, there would be a crash. This increases the precision of all double numeric settings to 0.5 and now shows the decimal that you couldn't see before. --- .../features/settings/ui/SettingsFragmentPresenter.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.kt b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.kt index fa5aaf4e53..099ae980e6 100644 --- a/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.kt +++ b/Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/features/settings/ui/SettingsFragmentPresenter.kt @@ -2356,8 +2356,8 @@ class SettingsFragmentPresenter( ceil(setting.getDoubleMin()).toFloat(), floor(setting.getDoubleMax()).toFloat(), setting.getUiSuffix(), - 1.0f, - false + 0.5f, + true ) ) From fa37336ba3db739095d7c2351f15443883711aa2 Mon Sep 17 00:00:00 2001 From: Charles Lombardo Date: Sat, 23 Sep 2023 10:58:29 -0400 Subject: [PATCH 2/2] Android: Adjust settings slider dialog Move text above slider --- .../app/src/main/res/layout/dialog_slider.xml | 58 +++++++++---------- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/Source/Android/app/src/main/res/layout/dialog_slider.xml b/Source/Android/app/src/main/res/layout/dialog_slider.xml index fdb2ffdecb..f9bf46607c 100644 --- a/Source/Android/app/src/main/res/layout/dialog_slider.xml +++ b/Source/Android/app/src/main/res/layout/dialog_slider.xml @@ -1,41 +1,37 @@ - + + + + + + + + + android:layout_marginHorizontal="24dp" + android:layout_marginBottom="24dp" /> - - - - - +